milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix volume slider not working on nowplayingbar

Browse source 
Turns out, by wrapping the code in a function it takes the necessary bits out of scope, causing the nowplayingbar to become non-functional when it comes to adjusting volume.

Fixes https://github.com/jellyfin/jellyfin/issues/988
This commit is contained in:
Sparky 2019-02-23 13:30:49 -05:00
parent fe28f88a99
commit 134bbbf6c0
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
.gitignore vendored
View file

@ -71,9 +71,6 @@ coverage
# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) # Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt .grunt
# Bower dependency directory (https://bower.io/)
bower_components
# node-waf configuration # node-waf configuration
.lock-wscript .lock-wscript

6
src/bower_components/emby-webcomponents/nowplayingbar/nowplayingbar.js vendored
View file

@ -191,9 +191,9 @@ define(['require', 'datetime', 'itemHelper', 'events', 'browser', 'imageLoader',
currentPlayer.setVolume(this.value); currentPlayer.setVolume(this.value);
} }
} }
volumeSlider.addEventListener('change', setVolume.bind(this)); volumeSlider.addEventListener('change', setVolume);
volumeSlider.addEventListener('mousemove', setVolume.bind(this)); volumeSlider.addEventListener('mousemove', setVolume);
volumeSlider.addEventListener('touchmove', setVolume.bind(this)); volumeSlider.addEventListener('touchmove', setVolume);
positionSlider = elem.querySelector('.nowPlayingBarPositionSlider'); positionSlider = elem.querySelector('.nowPlayingBarPositionSlider');