milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source
This commit is contained in:
Bill Thornton 2023-09-15 13:20:31 -04:00
parent dd6c3b85ab
commit 242e6c57b2
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/controllers/itemDetails/index.js
View file

@ -751,9 +751,6 @@ function setPeopleHeader(page, item) {
} else {
page.querySelector('#peopleHeader').innerHTML = globalize.translate('HeaderCastAndCrew');
}
if (item.Type === 'Episode') {
page.querySelector('#guestCastHeader').innerHTML = globalize.translate('HeaderGuestCast');
}
}
function renderNextUp(page, item, user) {
@ -1810,9 +1807,7 @@ function renderCast(page, item) {
}
function renderGuestCast(page, item) {
const people = (item.People || []).filter(function (p) {
return p.Type === 'GuestStar';
});
const people = (item.People || []).filter(p => p.Type === 'GuestStar');
if (!people.length) {
page.querySelector('#guestCastCollapsible').classList.add('hide');

2
src/strings/en-us.json
View file

@ -381,7 +381,7 @@
"HeaderFetchImages": "Fetch Images",
"HeaderForKids": "For Kids",
"HeaderFrequentlyPlayed": "Frequently Played",
"HeaderGuestCast": "Guest Cast",
"HeaderGuestCast": "Guest Stars",
"HeaderGuideProviders": "TV Guide Data Providers",
"HeaderHttpHeaders": "HTTP Headers",
"HeaderHttpsSettings": "HTTPS Settings",