From 5e422e15c0432489860171daffc2e3ac04e9f3f4 Mon Sep 17 00:00:00 2001 From: Felix Bjerhem Aronsson Date: Thu, 30 Jul 2020 13:42:41 +0200 Subject: [PATCH] Misc suggestions from code review Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --- src/scripts/mouseManager.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/scripts/mouseManager.js b/src/scripts/mouseManager.js index b3faedbb5..d801d8239 100644 --- a/src/scripts/mouseManager.js +++ b/src/scripts/mouseManager.js @@ -32,15 +32,19 @@ define(['inputManager', 'focusManager', 'browser', 'layoutManager', 'events', 'd } function showCursor() { - isMouseIdle = false; - removeIdleClasses(); - events.trigger(self, 'mouseactive'); + if (isMouseIdle) { + isMouseIdle = false; + removeIdleClasses(); + events.trigger(self, 'mouseactive'); + } } function hideCursor() { - isMouseIdle = true; - addIdleClasses(); - events.trigger(self, 'mouseidle'); + if (!isMouseIdle) { + isMouseIdle = true; + addIdleClasses(); + events.trigger(self, 'mouseidle'); + } } var lastPointerMoveData; @@ -73,9 +77,7 @@ define(['inputManager', 'focusManager', 'browser', 'layoutManager', 'events', 'd lastMouseInputTime = new Date().getTime(); notifyApp(); - if (isMouseIdle) { - showCursor(); - } + showCursor(); } function onPointerEnter(e) {