From 5ed8dbe9c32e77964233f9b0f0afe4e7eaea612b Mon Sep 17 00:00:00 2001 From: dkanada Date: Thu, 17 Jan 2019 04:49:47 +0900 Subject: [PATCH] deminify sections of the navbar code and fix logout button --- src/components/navdrawer/navdrawer.js | 41 ++++++++++++++++++++------- src/scripts/librarymenu.js | 2 +- 2 files changed, 31 insertions(+), 12 deletions(-) diff --git a/src/components/navdrawer/navdrawer.js b/src/components/navdrawer/navdrawer.js index 3a1119e12..cbf5c1eeb 100644 --- a/src/components/navdrawer/navdrawer.js +++ b/src/components/navdrawer/navdrawer.js @@ -2,19 +2,22 @@ define(["browser", "dom", "css!./navdrawer", "scrollStyles"], function(browser, "use strict"; return function(options) { function getTouches(e) { - return e.changedTouches || e.targetTouches || e.touches + return e.changedTouches || e.targetTouches || e.touches; } function onMenuTouchStart(e) { options.target.classList.remove("transition"); - var touches = getTouches(e), - touch = touches[0] || {}; - menuTouchStartX = touch.clientX, menuTouchStartY = touch.clientY, menuTouchStartTime = (new Date).getTime() + var touches = getTouches(e); + var touch = touches[0] || {}; + + menuTouchStartX = touch.clientX; + menuTouchStartY = touch.clientY; + menuTouchStartTime = (new Date).getTime(); } function setVelocity(deltaX) { var time = (new Date).getTime() - (menuTouchStartTime || 0); - velocity = Math.abs(deltaX) / time + velocity = Math.abs(deltaX) / time; } function onMenuTouchMove(e) { @@ -29,25 +32,41 @@ define(["browser", "dom", "css!./navdrawer", "scrollStyles"], function(browser, } function onMenuTouchEnd(e) { - options.target.classList.add("transition"), scrollContainer.removeEventListener("scroll", disableEvent), dragMode = 0; + options.target.classList.add("transition"); + scrollContainer.removeEventListener("scroll", disableEvent); + dragMode = 0; + var touches = getTouches(e), touch = touches[0] || {}, endX = touch.clientX || 0, endY = touch.clientY || 0, deltaX = endX - (menuTouchStartX || 0), deltaY = endY - (menuTouchStartY || 0); - currentPos = deltaX, self.checkMenuState(deltaX, deltaY) + + currentPos = deltaX; + self.checkMenuState(deltaX, deltaY); } function onEdgeTouchStart(e) { - if (isPeeking) onMenuTouchMove(e); - else { - ((getTouches(e)[0] || {}).clientX || 0) <= options.handleSize && (isPeeking = !0, "touchstart" === e.type && (dom.removeEventListener(edgeContainer, "touchmove", onEdgeTouchMove, {}), dom.addEventListener(edgeContainer, "touchmove", onEdgeTouchMove, {})), onMenuTouchStart(e)) + if (isPeeking) { + onMenuTouchMove(e); + } else { + if (((getTouches(e)[0] || {}).clientX || 0) <= options.handleSize) { + isPeeking = true; + if (e.type === "touchstart") { + dom.removeEventListener(edgeContainer, "touchmove", onEdgeTouchMove, {}); + dom.addEventListener(edgeContainer, "touchmove", onEdgeTouchMove, {}); + } + onMenuTouchStart(e); + } } } function onEdgeTouchMove(e) { - onEdgeTouchStart(e), e.preventDefault(), e.stopPropagation() + e.preventDefault(); + e.stopPropagation(); + + onEdgeTouchStart(e); } function onEdgeTouchEnd(e) { diff --git a/src/scripts/librarymenu.js b/src/scripts/librarymenu.js index d89cc1103..6fc4cfd88 100644 --- a/src/scripts/librarymenu.js +++ b/src/scripts/librarymenu.js @@ -117,7 +117,7 @@ define(["dom", "layoutManager", "inputManager", "connectionManager", "events", " html += '' + globalize.translate("ButtonSelectServer") + ""; } // null check for local user might not be required - if (user.localUser && user.localUser.EnableAutoLogin) { + if (user.localUser && !user.localUser.EnableAutoLogin) { html += '' + globalize.translate("ButtonSignOut") + ""; } html += "";