From 7a5d66c792060b288c91162175d18ef28d51e4c2 Mon Sep 17 00:00:00 2001 From: vitorsemeano Date: Mon, 25 Mar 2019 23:43:03 +0000 Subject: [PATCH] refactor fullscreenManager suggested by JustAMan --- src/components/fullscreenManager.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/components/fullscreenManager.js b/src/components/fullscreenManager.js index 0a43a764a..079267a6c 100644 --- a/src/components/fullscreenManager.js +++ b/src/components/fullscreenManager.js @@ -81,16 +81,11 @@ define(['events', 'dom', 'apphost', 'browser'], function (events, dom, appHost, if (appHost.supports("fullscreenchange") && (browser.edgeUwp || -1 !== navigator.userAgent.toLowerCase().indexOf("electron"))) { function isTargetValid(target) { - - if (dom.parentWithTag(target, ['BUTTON', 'INPUT', 'TEXTAREA'])) { - return false; - } - - return true; + return !dom.parentWithTag(target, ['BUTTON', 'INPUT', 'TEXTAREA']); } - + dom.addEventListener(window, 'dblclick', function (e) { - + if (isTargetValid(e.target)) { if (manager.isFullScreen()) { manager.exitFullscreen(); @@ -98,7 +93,7 @@ define(['events', 'dom', 'apphost', 'browser'], function (events, dom, appHost, manager.requestFullscreen(); } } - + }, { passive: true });