milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #4607 from sttatusx/fix-some-of-the-code-smells

Browse source 
Use optional chaining in the home component
This commit is contained in:
Bill Thornton 2023-05-17 13:04:19 -04:00 • committed by GitHub
commit 7d356a0b91
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/apps/experimental/routes/home.tsx
View file

@ -111,7 +111,7 @@ const Home: FunctionComponent = () => {
const previousIndex = e.detail.previousIndex; const previousIndex = e.detail.previousIndex;
const previousTabController = previousIndex == null ? null : tabControllers[previousIndex]; const previousTabController = previousIndex == null ? null : tabControllers[previousIndex];
if (previousTabController && previousTabController.onPause) { if (previousTabController?.onPause) {
previousTabController.onPause(); previousTabController.onPause();
} }
@ -126,7 +126,7 @@ const Home: FunctionComponent = () => {
if (!currentTabController) { if (!currentTabController) {
mainTabsManager.selectedTabIndex(initialTabIndex); mainTabsManager.selectedTabIndex(initialTabIndex);
} else if (currentTabController && currentTabController.onResume) { } else if (currentTabController?.onResume) {
currentTabController.onResume({}); currentTabController.onResume({});
} }
(document.querySelector('.skinHeader') as HTMLDivElement).classList.add('noHomeButtonHeader'); (document.querySelector('.skinHeader') as HTMLDivElement).classList.add('noHomeButtonHeader');
@ -134,7 +134,7 @@ const Home: FunctionComponent = () => {
const onPause = useCallback(() => { const onPause = useCallback(() => {
const currentTabController = tabController.current; const currentTabController = tabController.current;
if (currentTabController && currentTabController.onPause) { if (currentTabController?.onPause) {
currentTabController.onPause(); currentTabController.onPause();
} }
(document.querySelector('.skinHeader') as HTMLDivElement).classList.remove('noHomeButtonHeader'); (document.querySelector('.skinHeader') as HTMLDivElement).classList.remove('noHomeButtonHeader');