milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2139 from nielsvanvelzen/patch-2

Browse source 
Support async plugin loading from window
This commit is contained in:
Bill Thornton 2020-11-29 13:33:45 -05:00 • committed by GitHub
commit 9cb24d4d3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/pluginManager.js
View file

@ -74,9 +74,14 @@ import { playbackManager } from './playback/playbackmanager';
if (typeof pluginSpec === 'string') {
if (pluginSpec in window) {
console.log(`Loading plugin (via window): ${pluginSpec}`);
let pluginInstance = await window[pluginSpec];
if (typeof pluginInstance === 'function') {
pluginInstance = await pluginInstance();
}
// init plugin and pass basic dependencies
plugin = new window[pluginSpec]({
plugin = new pluginInstance({
events: Events,
loading,
appSettings,