From 985396af14ce0fc37a1f418561f60c92fbf40664 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Tue, 30 Jun 2020 00:47:34 +0300 Subject: [PATCH 1/4] Move tvlatest tab to suggestions section --- src/controllers/shows/tvlatest.js | 64 ------ src/controllers/shows/tvrecommended.js | 276 +++++++++++++++---------- src/tv.html | 28 ++- 3 files changed, 176 insertions(+), 192 deletions(-) delete mode 100644 src/controllers/shows/tvlatest.js diff --git a/src/controllers/shows/tvlatest.js b/src/controllers/shows/tvlatest.js deleted file mode 100644 index 08e420a59..000000000 --- a/src/controllers/shows/tvlatest.js +++ /dev/null @@ -1,64 +0,0 @@ -define(['loading', 'components/groupedcards', 'cardBuilder', 'apphost', 'imageLoader'], function (loading, groupedcards, cardBuilder, appHost, imageLoader) { - 'use strict'; - - function getLatestPromise(context, params) { - loading.show(); - var userId = ApiClient.getCurrentUserId(); - var parentId = params.topParentId; - var options = { - IncludeItemTypes: 'Episode', - Limit: 30, - Fields: 'PrimaryImageAspectRatio,BasicSyncInfo', - ParentId: parentId, - ImageTypeLimit: 1, - EnableImageTypes: 'Primary,Backdrop,Thumb' - }; - return ApiClient.getJSON(ApiClient.getUrl('Users/' + userId + '/Items/Latest', options)); - } - - function loadLatest(context, params, promise) { - promise.then(function (items) { - var html = ''; - appHost.supports('imageanalysis'); - html += cardBuilder.getCardsHtml({ - items: items, - shape: 'backdrop', - preferThumb: true, - showTitle: true, - showSeriesYear: true, - showParentTitle: true, - overlayText: false, - cardLayout: false, - showUnplayedIndicator: false, - showChildCountIndicator: true, - centerText: true, - lazy: true, - overlayPlayButton: true, - lines: 2 - }); - var elem = context.querySelector('#latestEpisodes'); - elem.innerHTML = html; - imageLoader.lazyChildren(elem); - loading.hide(); - - require(['autoFocuser'], function (autoFocuser) { - autoFocuser.autoFocus(context); - }); - }); - } - - return function (view, params, tabContent) { - var self = this; - var latestPromise; - - self.preRender = function () { - latestPromise = getLatestPromise(view, params); - }; - - self.renderTab = function () { - loadLatest(tabContent, params, latestPromise); - }; - - tabContent.querySelector('#latestEpisodes').addEventListener('click', groupedcards.onItemsContainerClick); - }; -}); diff --git a/src/controllers/shows/tvrecommended.js b/src/controllers/shows/tvrecommended.js index 8087a0309..fc165cf1e 100644 --- a/src/controllers/shows/tvrecommended.js +++ b/src/controllers/shows/tvrecommended.js @@ -6,8 +6,6 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do name: globalize.translate('TabShows') }, { name: globalize.translate('TabSuggestions') - }, { - name: globalize.translate('TabLatest') }, { name: globalize.translate('TabUpcoming') }, { @@ -27,14 +25,11 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do case 'suggestions': return 1; - case 'latest': - return 2; - case 'favorites': return 1; case 'genres': - return 4; + return 3; default: return 0; @@ -59,101 +54,159 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do } } + function initSuggestedTab(page, tabContent) { + var containers = tabContent.querySelectorAll('.itemsContainer'); + + for (var i = 0, length = containers.length; i < length; i++) { + setScrollClasses(containers[i], enableScrollX()); + } + } + + function loadSuggestionsTab(view, params, tabContent) { + var parentId = params.topParentId; + var userId = ApiClient.getCurrentUserId(); + console.debug('loadSuggestionsTab'); + loadResume(tabContent, userId, parentId); + loadLatest(tabContent, userId, parentId); + loadNextUp(tabContent, userId, parentId); + } + + function loadResume(view, userId, parentId) { + var screenWidth = dom.getWindowSize().innerWidth; + var options = { + SortBy: 'DatePlayed', + SortOrder: 'Descending', + IncludeItemTypes: 'Episode', + Filters: 'IsResumable', + Limit: screenWidth >= 1920 ? 5 : screenWidth >= 1600 ? 5 : 3, + Recursive: true, + Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo', + CollapseBoxSetItems: false, + ParentId: parentId, + ImageTypeLimit: 1, + EnableImageTypes: 'Primary,Backdrop,Banner,Thumb', + EnableTotalRecordCount: false + }; + ApiClient.getItems(userId, options).then(function (result) { + if (result.Items.length) { + view.querySelector('#resumableSection').classList.remove('hide'); + } else { + view.querySelector('#resumableSection').classList.add('hide'); + } + + var allowBottomPadding = !enableScrollX(); + var container = view.querySelector('#resumableItems'); + cardBuilder.buildCards(result.Items, { + itemsContainer: container, + preferThumb: true, + shape: getThumbShape(), + scalable: true, + overlayPlayButton: true, + allowBottomPadding: allowBottomPadding, + cardLayout: false, + showTitle: true, + showYear: true, + centerText: true + }); + loading.hide(); + + require(['autoFocuser'], function (autoFocuser) { + autoFocuser.autoFocus(view); + }); + }); + } + + function loadLatest(view, userId, parentId) { + var options = { + userId: userId, + IncludeItemTypes: 'Episode', + Limit: 30, + Fields: 'PrimaryImageAspectRatio,BasicSyncInfo', + ParentId: parentId, + ImageTypeLimit: 1, + EnableImageTypes: 'Primary,Backdrop,Thumb' + }; + ApiClient.getLatestItems(options).then(function (items) { + var section = view.querySelector('#latestItemsSection'); + var allowBottomPadding = !enableScrollX(); + var container = section.querySelector('#latestEpisodesItems'); + cardBuilder.buildCards(items, { + parentContainer: section, + itemsContainer: container, + items: items, + shape: 'backdrop', + preferThumb: true, + showTitle: true, + showSeriesYear: true, + showParentTitle: true, + overlayText: false, + cardLayout: false, + allowBottomPadding: allowBottomPadding, + showUnplayedIndicator: false, + showChildCountIndicator: true, + centerText: true, + lazy: true, + overlayPlayButton: true, + lines: 2 + }); + loading.hide(); + + require(['autoFocuser'], function (autoFocuser) { + autoFocuser.autoFocus(view); + }); + }); + } + + function loadNextUp(view, userId, parentId) { + var query = { + userId: userId, + Limit: 24, + Fields: 'PrimaryImageAspectRatio,SeriesInfo,DateCreated,BasicSyncInfo', + ParentId: parentId, + ImageTypeLimit: 1, + EnableImageTypes: 'Primary,Backdrop,Thumb', + EnableTotalRecordCount: false + }; + query.ParentId = libraryMenu.getTopParentId(); + ApiClient.getNextUpEpisodes(query).then(function (result) { + if (result.Items.length) { + view.querySelector('.noNextUpItems').classList.add('hide'); + } else { + view.querySelector('.noNextUpItems').classList.remove('hide'); + } + + var section = view.querySelector('#nextUpItemsSection'); + var container = section.querySelector('#nextUpItems'); + cardBuilder.buildCards(result.Items, { + parentContainer: section, + itemsContainer: container, + preferThumb: true, + shape: 'backdrop', + scalable: true, + showTitle: true, + showParentTitle: true, + overlayText: false, + centerText: true, + overlayPlayButton: true, + cardLayout: false + }); + loading.hide(); + + require(['autoFocuser'], function (autoFocuser) { + autoFocuser.autoFocus(view); + }); + }); + } + + function enableScrollX() { + return !layoutManager.desktop; + } + + function getThumbShape() { + return enableScrollX() ? 'overflowBackdrop' : 'backdrop'; + } + return function (view, params) { - function reload() { - loading.show(); - loadResume(); - loadNextUp(); - } - - function loadNextUp() { - var query = { - Limit: 24, - Fields: 'PrimaryImageAspectRatio,SeriesInfo,DateCreated,BasicSyncInfo', - UserId: ApiClient.getCurrentUserId(), - ImageTypeLimit: 1, - EnableImageTypes: 'Primary,Backdrop,Thumb', - EnableTotalRecordCount: false - }; - query.ParentId = libraryMenu.getTopParentId(); - ApiClient.getNextUpEpisodes(query).then(function (result) { - if (result.Items.length) { - view.querySelector('.noNextUpItems').classList.add('hide'); - } else { - view.querySelector('.noNextUpItems').classList.remove('hide'); - } - - var container = view.querySelector('#nextUpItems'); - cardBuilder.buildCards(result.Items, { - itemsContainer: container, - preferThumb: true, - shape: 'backdrop', - scalable: true, - showTitle: true, - showParentTitle: true, - overlayText: false, - centerText: true, - overlayPlayButton: true, - cardLayout: false - }); - loading.hide(); - - require(['autoFocuser'], function (autoFocuser) { - autoFocuser.autoFocus(view); - }); - }); - } - - function enableScrollX() { - return !layoutManager.desktop; - } - - function getThumbShape() { - return enableScrollX() ? 'overflowBackdrop' : 'backdrop'; - } - - function loadResume() { - var parentId = libraryMenu.getTopParentId(); - var screenWidth = dom.getWindowSize().innerWidth; - var limit = screenWidth >= 1600 ? 5 : 6; - var options = { - SortBy: 'DatePlayed', - SortOrder: 'Descending', - IncludeItemTypes: 'Episode', - Filters: 'IsResumable', - Limit: limit, - Recursive: true, - Fields: 'PrimaryImageAspectRatio,SeriesInfo,UserData,BasicSyncInfo', - ExcludeLocationTypes: 'Virtual', - ParentId: parentId, - ImageTypeLimit: 1, - EnableImageTypes: 'Primary,Backdrop,Thumb', - EnableTotalRecordCount: false - }; - ApiClient.getItems(ApiClient.getCurrentUserId(), options).then(function (result) { - if (result.Items.length) { - view.querySelector('#resumableSection').classList.remove('hide'); - } else { - view.querySelector('#resumableSection').classList.add('hide'); - } - - var allowBottomPadding = !enableScrollX(); - var container = view.querySelector('#resumableItems'); - cardBuilder.buildCards(result.Items, { - itemsContainer: container, - preferThumb: true, - shape: getThumbShape(), - scalable: true, - showTitle: true, - showParentTitle: true, - overlayText: false, - centerText: true, - overlayPlayButton: true, - allowBottomPadding: allowBottomPadding, - cardLayout: false - }); - }); - } function onBeforeTabChange(e) { preLoadTab(view, parseInt(e.detail.selectedTabIndex)); @@ -184,26 +237,22 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do break; case 2: - depends.push('controllers/shows/tvlatest'); - break; - - case 3: depends.push('controllers/shows/tvupcoming'); break; - case 4: + case 3: depends.push('controllers/shows/tvgenres'); break; - case 5: + case 4: depends.push('controllers/shows/tvstudios'); break; - case 6: + case 5: depends.push('controllers/shows/episodes'); break; - case 7: + case 6: depends.push('scripts/searchtab'); } @@ -222,7 +271,7 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do if (index === 1) { controller = self; - } else if (index === 7) { + } else if (index === 6) { controller = new controllerFactory(view, tabContent, { collectionType: 'tvshows', parentId: params.topParentId @@ -289,19 +338,20 @@ define(['events', 'inputManager', 'libraryMenu', 'layoutManager', 'loading', 'do var self = this; var currentTabIndex = parseInt(params.tab || getDefaultTabIndex(params.topParentId)); var initialTabIndex = currentTabIndex; + var suggestionsTabIndex = 1; self.initTab = function () { - var tabContent = self.tabContent; - setScrollClasses(tabContent.querySelector('#resumableItems'), enableScrollX()); + var tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); + initSuggestedTab(view, tabContent); }; self.renderTab = function () { - reload(); + var tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); + loadSuggestionsTab(view, params, tabContent); }; var tabControllers = []; var renderedTabs = []; - setScrollClasses(view.querySelector('#resumableItems'), enableScrollX()); view.addEventListener('viewshow', function (e) { isViewRestored = e.detail.isRestored; initTabs(); diff --git a/src/tv.html b/src/tv.html index ceb5c51b4..c646ecdb4 100644 --- a/src/tv.html +++ b/src/tv.html @@ -23,8 +23,15 @@
+
+
+

${HeaderLatestEpisodes}

+
-
+
+
+ +

${HeaderNextUp}

@@ -33,16 +40,7 @@
-
-
-
-

${HeaderLatestEpisodes}

-
-
-
-
-
-
+
-
+
-
+
-
+
@@ -69,6 +67,6 @@
-
+
From 71c44dccd6ab690bb720b47d01ec1c9b26bcf12d Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Mon, 14 Sep 2020 00:04:55 +0300 Subject: [PATCH 2/4] move music tabs suggestions to the second position --- .../homeScreenSettings/homeScreenSettings.js | 8 ++-- src/controllers/music/music.html | 40 +++++++++---------- src/controllers/music/musicrecommended.js | 19 ++++----- src/controllers/shows/tvrecommended.js | 34 ++++++++-------- 4 files changed, 51 insertions(+), 50 deletions(-) diff --git a/src/components/homeScreenSettings/homeScreenSettings.js b/src/components/homeScreenSettings/homeScreenSettings.js index 3348348f2..5825d19a2 100644 --- a/src/components/homeScreenSettings/homeScreenSettings.js +++ b/src/components/homeScreenSettings/homeScreenSettings.js @@ -88,13 +88,13 @@ import 'emby-checkbox'; }); } else if (type === 'music') { list.push({ - name: globalize.translate('Suggestions'), - value: 'suggestions', + name: globalize.translate('Albums'), + value: 'albums', isDefault: true }); list.push({ - name: globalize.translate('Albums'), - value: 'albums' + name: globalize.translate('Suggestions'), + value: 'suggestions' }); list.push({ name: globalize.translate('HeaderAlbumArtists'), diff --git a/src/controllers/music/music.html b/src/controllers/music/music.html index 84d324857..aba8379f8 100644 --- a/src/controllers/music/music.html +++ b/src/controllers/music/music.html @@ -8,7 +8,26 @@ } } -
+
+
+
+ + + + + +
+ +
+
+ +
+
+
+
+
+
+
@@ -34,25 +53,6 @@
-
-
-
- - - - - -
- -
-
- -
-
-
-
-
-
diff --git a/src/controllers/music/musicrecommended.js b/src/controllers/music/musicrecommended.js index a93bfea4e..7b11a8eb2 100644 --- a/src/controllers/music/musicrecommended.js +++ b/src/controllers/music/musicrecommended.js @@ -177,9 +177,9 @@ import 'flexStyles'; function getTabs() { return [{ - name: globalize.translate('Suggestions') - }, { name: globalize.translate('Albums') + }, { + name: globalize.translate('Suggestions') }, { name: globalize.translate('HeaderAlbumArtists') }, { @@ -195,7 +195,7 @@ import 'flexStyles'; function getDefaultTabIndex(folderId) { switch (userSettings.get('landing-' + folderId)) { - case 'albums': + case 'suggestions': return 1; case 'albumartists': @@ -221,7 +221,7 @@ import 'flexStyles'; export default function (view, params) { function reload() { loading.show(); - const tabContent = view.querySelector(".pageTabContent[data-index='0']"); + const tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); loadSuggestionsTab(view, tabContent, params.topParentId); } @@ -268,11 +268,11 @@ import 'flexStyles'; switch (index) { case 0: - depends = 'controllers/music/musicrecommended'; + depends = 'controllers/music/musicalbums'; break; case 1: - depends = 'controllers/music/musicalbums'; + depends = 'controllers/music/musicrecommended'; break; case 2: @@ -296,7 +296,7 @@ import 'flexStyles'; import(depends).then(({default: controllerFactory}) => { let tabContent; - if (index == 0) { + if (index == 1) { tabContent = view.querySelector(".pageTabContent[data-index='" + index + "']"); this.tabContent = tabContent; } @@ -306,7 +306,7 @@ import 'flexStyles'; if (!controller) { tabContent = view.querySelector(".pageTabContent[data-index='" + index + "']"); - if (index === 0) { + if (index === 1) { controller = this; } else if (index === 7) { controller = new controllerFactory(view, tabContent, { @@ -360,9 +360,10 @@ import 'flexStyles'; } let currentTabIndex = parseInt(params.tab || getDefaultTabIndex(params.topParentId)); + const suggestionsTabIndex = 1; this.initTab = function () { - const tabContent = view.querySelector(".pageTabContent[data-index='0']"); + const tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); const containers = tabContent.querySelectorAll('.itemsContainer'); for (let i = 0, length = containers.length; i < length; i++) { diff --git a/src/controllers/shows/tvrecommended.js b/src/controllers/shows/tvrecommended.js index 048d27d45..da47f9f31 100644 --- a/src/controllers/shows/tvrecommended.js +++ b/src/controllers/shows/tvrecommended.js @@ -66,16 +66,16 @@ import 'emby-button'; } function initSuggestedTab(page, tabContent) { - var containers = tabContent.querySelectorAll('.itemsContainer'); + const containers = tabContent.querySelectorAll('.itemsContainer'); - for (var i = 0, length = containers.length; i < length; i++) { + for (let i = 0, length = containers.length; i < length; i++) { setScrollClasses(containers[i], enableScrollX()); } } function loadSuggestionsTab(view, params, tabContent) { - var parentId = params.topParentId; - var userId = ApiClient.getCurrentUserId(); + const parentId = params.topParentId; + const userId = ApiClient.getCurrentUserId(); console.debug('loadSuggestionsTab'); loadResume(tabContent, userId, parentId); loadLatest(tabContent, userId, parentId); @@ -83,8 +83,8 @@ import 'emby-button'; } function loadResume(view, userId, parentId) { - var screenWidth = dom.getWindowSize().innerWidth; - var options = { + const screenWidth = dom.getWindowSize().innerWidth; + const options = { SortBy: 'DatePlayed', SortOrder: 'Descending', IncludeItemTypes: 'Episode', @@ -105,8 +105,8 @@ import 'emby-button'; view.querySelector('#resumableSection').classList.add('hide'); } - var allowBottomPadding = !enableScrollX(); - var container = view.querySelector('#resumableItems'); + const allowBottomPadding = !enableScrollX(); + const container = view.querySelector('#resumableItems'); cardBuilder.buildCards(result.Items, { itemsContainer: container, preferThumb: true, @@ -128,7 +128,7 @@ import 'emby-button'; } function loadLatest(view, userId, parentId) { - var options = { + const options = { userId: userId, IncludeItemTypes: 'Episode', Limit: 30, @@ -138,9 +138,9 @@ import 'emby-button'; EnableImageTypes: 'Primary,Backdrop,Thumb' }; ApiClient.getLatestItems(options).then(function (items) { - var section = view.querySelector('#latestItemsSection'); - var allowBottomPadding = !enableScrollX(); - var container = section.querySelector('#latestEpisodesItems'); + const section = view.querySelector('#latestItemsSection'); + const allowBottomPadding = !enableScrollX(); + const container = section.querySelector('#latestEpisodesItems'); cardBuilder.buildCards(items, { parentContainer: section, itemsContainer: container, @@ -169,7 +169,7 @@ import 'emby-button'; } function loadNextUp(view, userId, parentId) { - var query = { + const query = { userId: userId, Limit: 24, Fields: 'PrimaryImageAspectRatio,SeriesInfo,DateCreated,BasicSyncInfo', @@ -186,8 +186,8 @@ import 'emby-button'; view.querySelector('.noNextUpItems').classList.remove('hide'); } - var section = view.querySelector('#nextUpItemsSection'); - var container = section.querySelector('#nextUpItems'); + const section = view.querySelector('#nextUpItemsSection'); + const container = section.querySelector('#nextUpItems'); cardBuilder.buildCards(result.Items, { parentContainer: section, itemsContainer: container, @@ -345,12 +345,12 @@ import 'emby-button'; const suggestionsTabIndex = 1; self.initTab = function () { - var tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); + const tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); initSuggestedTab(view, tabContent); }; self.renderTab = function () { - var tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); + const tabContent = view.querySelector(".pageTabContent[data-index='" + suggestionsTabIndex + "']"); loadSuggestionsTab(view, params, tabContent); }; From 3cc20ce480df43a23a3f6562436f4cac26112161 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Mon, 14 Sep 2020 01:09:59 +0300 Subject: [PATCH 3/4] add more Landing Screen Options --- .../homeScreenSettings/homeScreenSettings.js | 12 ++++++++---- src/controllers/movies/movies.html | 12 ++++++------ src/controllers/music/music.html | 2 +- src/controllers/shows/tvrecommended.html | 2 +- src/controllers/shows/tvrecommended.js | 10 ++++++++-- 5 files changed, 24 insertions(+), 14 deletions(-) diff --git a/src/components/homeScreenSettings/homeScreenSettings.js b/src/components/homeScreenSettings/homeScreenSettings.js index 5825d19a2..513893540 100644 --- a/src/components/homeScreenSettings/homeScreenSettings.js +++ b/src/components/homeScreenSettings/homeScreenSettings.js @@ -75,16 +75,20 @@ import 'emby-checkbox'; value: 'suggestions' }); list.push({ - name: globalize.translate('Latest'), - value: 'latest' + name: globalize.translate('Upcoming'), + value: 'upcoming' }); list.push({ name: globalize.translate('Genres'), value: 'genres' }); list.push({ - name: globalize.translate('Favorites'), - value: 'favorites' + name: globalize.translate('Networks'), + value: 'networks' + }); + list.push({ + name: globalize.translate('Episodes'), + value: 'episodes' }); } else if (type === 'music') { list.push({ diff --git a/src/controllers/movies/movies.html b/src/controllers/movies/movies.html index dddda3f7f..5c905d122 100644 --- a/src/controllers/movies/movies.html +++ b/src/controllers/movies/movies.html @@ -1,6 +1,6 @@
-
+
@@ -17,7 +17,7 @@
-
+

${HeaderContinueWatching}

@@ -43,7 +43,7 @@

${MessageNoMovieSuggestionsAvailable}

-
+
@@ -59,7 +59,7 @@
-
+
@@ -71,7 +71,7 @@
-
+
@@ -85,7 +85,7 @@
-
+
diff --git a/src/controllers/music/music.html b/src/controllers/music/music.html index aba8379f8..0ec339db9 100644 --- a/src/controllers/music/music.html +++ b/src/controllers/music/music.html @@ -85,7 +85,7 @@
-
+
diff --git a/src/controllers/shows/tvrecommended.html b/src/controllers/shows/tvrecommended.html index 0d7b7dced..75e154693 100644 --- a/src/controllers/shows/tvrecommended.html +++ b/src/controllers/shows/tvrecommended.html @@ -54,7 +54,7 @@
-
+
diff --git a/src/controllers/shows/tvrecommended.js b/src/controllers/shows/tvrecommended.js index da47f9f31..9955df6b5 100644 --- a/src/controllers/shows/tvrecommended.js +++ b/src/controllers/shows/tvrecommended.js @@ -36,12 +36,18 @@ import 'emby-button'; case 'suggestions': return 1; - case 'favorites': - return 1; + case 'upcoming': + return 2; case 'genres': return 3; + case 'networks': + return 4; + + case 'episodes': + return 5; + default: return 0; } From d3c5b83b290ab5ed3baef95f44ba7c182f5ca563 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Mon, 14 Sep 2020 01:23:20 +0300 Subject: [PATCH 4/4] clean up unused search tab condition --- src/controllers/movies/movies.html | 2 -- src/controllers/movies/moviesrecommended.js | 5 ----- src/controllers/music/music.html | 2 -- src/controllers/music/musicrecommended.js | 5 ----- src/controllers/shows/tvrecommended.html | 2 -- src/controllers/shows/tvrecommended.js | 5 ----- 6 files changed, 21 deletions(-) diff --git a/src/controllers/movies/movies.html b/src/controllers/movies/movies.html index 5c905d122..ec2a975db 100644 --- a/src/controllers/movies/movies.html +++ b/src/controllers/movies/movies.html @@ -88,6 +88,4 @@
-
-
diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index 4036128b5..44b0fe25f 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -320,11 +320,6 @@ import 'emby-button'; if (index === suggestionsTabIndex) { controller = this; - } else if (index === 6) { - controller = new controllerFactory(view, tabContent, { - collectionType: 'movies', - parentId: params.topParentId - }); } else if (index == 0 || index == 3) { controller = new controllerFactory(view, params, tabContent, { mode: index ? 'favorites' : 'movies' diff --git a/src/controllers/music/music.html b/src/controllers/music/music.html index 0ec339db9..43251226c 100644 --- a/src/controllers/music/music.html +++ b/src/controllers/music/music.html @@ -105,6 +105,4 @@
-
-
diff --git a/src/controllers/music/musicrecommended.js b/src/controllers/music/musicrecommended.js index 7b11a8eb2..6c569ddd4 100644 --- a/src/controllers/music/musicrecommended.js +++ b/src/controllers/music/musicrecommended.js @@ -308,11 +308,6 @@ import 'flexStyles'; if (index === 1) { controller = this; - } else if (index === 7) { - controller = new controllerFactory(view, tabContent, { - collectionType: 'music', - parentId: params.topParentId - }); } else { controller = new controllerFactory(view, params, tabContent); } diff --git a/src/controllers/shows/tvrecommended.html b/src/controllers/shows/tvrecommended.html index 75e154693..dbfac37b9 100644 --- a/src/controllers/shows/tvrecommended.html +++ b/src/controllers/shows/tvrecommended.html @@ -67,6 +67,4 @@
-
-
diff --git a/src/controllers/shows/tvrecommended.js b/src/controllers/shows/tvrecommended.js index 9955df6b5..db7bef2d5 100644 --- a/src/controllers/shows/tvrecommended.js +++ b/src/controllers/shows/tvrecommended.js @@ -285,11 +285,6 @@ import 'emby-button'; if (index === 1) { controller = self; - } else if (index === 6) { - controller = new controllerFactory(view, tabContent, { - collectionType: 'tvshows', - parentId: params.topParentId - }); } else { controller = new controllerFactory(view, params, tabContent); }