milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix icons on WebOS

Browse source 
WebOS 4 apparently has a ligature bug that prevents icons with an underscore from working as intended.
This replaces them with either the corresponding CSS class or unicode escape code, depending on context.
Refactoring is needed in order to be able to use CSS classes everywhere, so in the interest of time, this does the best available currently.

Fixes #678
This commit is contained in:
MrTimscampi 2020-02-16 01:31:14 +01:00
parent 23b4dfc8fa
commit a98b961b94
82 changed files with 201 additions and 201 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/subtitleeditor/subtitleeditor.js
View file

@ -132,7 +132,7 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
itemHtml += '<' + tagName + ' class="' + className + '" data-index="' + s.Index + '">';
itemHtml += '<i class="listItemIcon material-icons">closed_caption</i>';
itemHtml += '<i class="listItemIcon material-icons closed_caption"></i>';
itemHtml += '<div class="listItemBody two-line">';
@ -248,7 +248,7 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
html += '<' + tagName + ' class="' + className + '" data-subid="' + result.Id + '">';
html += '<i class="listItemIcon material-icons">closed_caption</i>';
html += '<i class="listItemIcon material-icons closed_caption"></i>';
var bodyClass = result.Comment || result.IsHashMatch ? 'three-line' : 'two-line';
@ -281,7 +281,7 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
html += '</div>';
if (!layoutManager.tv) {
html += '<button type="button" is="paper-icon-button-light" data-subid="' + result.Id + '" class="btnDownload listItemButton"><i class="material-icons">file_download</i></button>';
html += '<button type="button" is="paper-icon-button-light" data-subid="' + result.Id + '" class="btnDownload listItemButton"><i class="material-icons file_download"></i></button>';
}
html += '</' + tagName + '>';

2
src/components/subtitleeditor/subtitleeditor.template.html
View file

@ -1,5 +1,5 @@
<div class="formDialogHeader">
<button is="paper-icon-button-light" class="btnCancel autoSize" tabindex="-1"><i class="material-icons">arrow_back</i></button>
<button is="paper-icon-button-light" class="btnCancel autoSize" tabindex="-1"><i class="material-icons arrow_back"></i></button>
<h3 class="formDialogHeaderTitle">${Subtitles}</h3>
<a is="emby-linkbutton" data-autohide="true" class="button-link btnHelp flex align-items-center" href="https://docs.jellyfin.org/general/server/media/subtitles.html" target="_blank" style="margin-left:auto;margin-right:.5em;padding:.25em;" title="${Help}"><i class="material-icons">info</i><span style="margin-left:.25em;">${Help}</span></a>