Fix code issues reported by Sonar

src/components/syncPlay/ui/players/HtmlAudioPlayer.js

@@ -1,14 +1,14 @@
 /**
  * Module that manages the HtmlAudioPlayer for SyncPlay.
- * @module components/syncPlay/players/htmlAudioPlayer
+ * @module components/syncPlay/ui/players/HtmlAudioPlayer
  */
 
-import SyncPlayHtmlVideoPlayer from './htmlVideoPlayer';
+import HtmlVideoPlayer from './HtmlVideoPlayer';
 
 /**
  * Class that manages the HtmlAudioPlayer for SyncPlay.
  */
-class SyncPlayHtmlAudioPlayer extends SyncPlayHtmlVideoPlayer {
+class HtmlAudioPlayer extends HtmlVideoPlayer {
     static type = 'htmlaudioplayer';
 
     constructor(player, syncPlayManager) {
@@ -16,4 +16,4 @@ class SyncPlayHtmlAudioPlayer extends SyncPlayHtmlVideoPlayer {
     }
 }
 
-export default SyncPlayHtmlAudioPlayer;
+export default HtmlAudioPlayer;

src/components/syncPlay/ui/players/HtmlVideoPlayer.js

@@ -1,15 +1,15 @@
 /**
  * Module that manages the HtmlVideoPlayer for SyncPlay.
- * @module components/syncPlay/players/htmlVideoPlayer
+ * @module components/syncPlay/ui/players/HtmlVideoPlayer
  */
 
 import { Events } from 'jellyfin-apiclient';
-import SyncPlayNoActivePlayer from './noActivePlayer';
+import NoActivePlayer from './NoActivePlayer';
 
 /**
  * Class that manages the HtmlVideoPlayer for SyncPlay.
  */
-class SyncPlayHtmlVideoPlayer extends SyncPlayNoActivePlayer {
+class HtmlVideoPlayer extends NoActivePlayer {
     static type = 'htmlvideoplayer';
 
     constructor(player, syncPlayManager) {
@@ -152,4 +152,4 @@ class SyncPlayHtmlVideoPlayer extends SyncPlayNoActivePlayer {
     }
 }
 
-export default SyncPlayHtmlVideoPlayer;
+export default HtmlVideoPlayer;

src/components/syncPlay/ui/players/NoActivePlayer.js

@@ -1,18 +1,18 @@
 /**
  * Module that manages the PlaybackManager when there's no active player.
- * @module components/syncPlay/players/genericPlayer
+ * @module components/syncPlay/ui/players/NoActivePlayer
  */
 
 import { playbackManager } from '../../../playback/playbackmanager';
 import SyncPlay from 'SyncPlay';
-import QueueManager from './queueManager';
+import QueueManager from './QueueManager';
 
 let syncPlayManager;
 
 /**
  * Class that manages the PlaybackManager when there's no active player.
  */
-class SyncPlayNoActivePlayer extends SyncPlay.Players.GenericPlayer {
+class NoActivePlayer extends SyncPlay.Players.GenericPlayer {
     static type = 'default';
 
     constructor(player, _syncPlayManager) {
@@ -143,25 +143,25 @@ class SyncPlayNoActivePlayer extends SyncPlay.Players.GenericPlayer {
     /**
      * Overrides PlaybackManager's sendCommand method.
      */
-    sendCommandRequest(cmd, player) {
-        console.debug('SyncPlay sendCommand:', cmd.Name, cmd);
+    sendCommandRequest(command, player) {
+        console.debug('SyncPlay sendCommand:', command.Name, command);
         const controller = syncPlayManager.getController();
         const playerWrapper = syncPlayManager.getPlayerWrapper();
 
-        const defaultAction = (command, player) => {
-            playerWrapper.localSendCommand(command);
+        const defaultAction = (_command, _player) => {
+            playerWrapper.localSendCommand(_command);
         };
 
-        const ignoreCallback = (command, player) => {
+        const ignoreCallback = (_command, _player) => {
             // Do nothing.
         };
 
-        const SetRepeatModeCallback = (command, player) => {
-            controller.setRepeatMode(command.Arguments.RepeatMode);
+        const SetRepeatModeCallback = (_command, _player) => {
+            controller.setRepeatMode(_command.Arguments.RepeatMode);
         };
 
-        const SetShuffleQueueCallback = (command, player) => {
-            controller.setShuffleMode(command.Arguments.ShuffleMode);
+        const SetShuffleQueueCallback = (_command, _player) => {
+            controller.setShuffleMode(_command.Arguments.ShuffleMode);
         };
 
         // Commands to override.
@@ -172,11 +172,11 @@ class SyncPlayNoActivePlayer extends SyncPlay.Players.GenericPlayer {
         };
 
         // Handle command.
-        const commandHandler = overrideCommands[cmd.Name];
+        const commandHandler = overrideCommands[command.Name];
         if (typeof commandHandler === 'function') {
-            commandHandler(cmd, player);
+            commandHandler(command, player);
         } else {
-            defaultAction(cmd, player);
+            defaultAction(command, player);
         }
     }
 
@@ -441,4 +441,4 @@ class SyncPlayNoActivePlayer extends SyncPlay.Players.GenericPlayer {
     }
 }
 
-export default SyncPlayNoActivePlayer;
+export default NoActivePlayer;

src/components/syncPlay/ui/players/QueueManager.js

@@ -1,6 +1,6 @@
 /**
  * Module that replaces the PlaybackManager's queue.
- * @module components/syncPlay/players/queueManager
+ * @module components/syncPlay/ui/players/QueueManager
  */
 
 /**