From 24250cb4b05b1a54cf672eb7ea11f3ab331b8ca4 Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sat, 29 Jun 2019 23:45:07 -0700
Subject: [PATCH 1/3] deminify usernew page

---
 src/controllers/usernew.js | 96 ++++++++++++++++++++++++--------------
 src/usernew.html           |  3 +-
 2 files changed, 61 insertions(+), 38 deletions(-)

diff --git a/src/controllers/usernew.js b/src/controllers/usernew.js
index a9119a4ae..3731df4fa 100644
--- a/src/controllers/usernew.js
+++ b/src/controllers/usernew.js
@@ -3,74 +3,98 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
 
     function loadMediaFolders(page, mediaFolders) {
         var html = "";
-        html += '<h3 class="checkboxListLabel">' + Globalize.translate("HeaderLibraries") + "</h3>", html += '<div class="checkboxList paperList" style="padding:.5em 1em;">';
-        for (var i = 0, length = mediaFolders.length; i < length; i++) {
+        html += '<h3 class="checkboxListLabel">' + Globalize.translate("HeaderLibraries") + "</h3>";
+        html += '<div class="checkboxList paperList" style="padding:.5em 1em;">';
+        for (var i = 0; i < mediaFolders.length; i++) {
             var folder = mediaFolders[i];
-            html += '<label><input type="checkbox" is="emby-checkbox" class="chkFolder" data-id="' + folder.Id + '" checked="checked"/><span>' + folder.Name + "</span></label>"
+            html += '<label><input type="checkbox" is="emby-checkbox" class="chkFolder" data-id="' + folder.Id + '" checked="checked"/><span>' + folder.Name + "</span></label>";
         }
-        html += "</div>", $(".folderAccess", page).html(html).trigger("create"), $("#chkEnableAllFolders", page).checked(!0).trigger("change")
+        html += "</div>";
+        $(".folderAccess", page).html(html).trigger("create");
+        $("#chkEnableAllFolders", page).checked(true).trigger("change");
     }
 
     function loadChannels(page, channels) {
         var html = "";
-        html += '<h3 class="checkboxListLabel">' + Globalize.translate("HeaderChannels") + "</h3>", html += '<div class="checkboxList paperList" style="padding:.5em 1em;">';
-        for (var i = 0, length = channels.length; i < length; i++) {
+        html += '<h3 class="checkboxListLabel">' + Globalize.translate("HeaderChannels") + "</h3>";
+        html += '<div class="checkboxList paperList" style="padding:.5em 1em;">';
+        for (var i = 0; i < channels.length; i++) {
             var folder = channels[i];
-            html += '<label><input type="checkbox" is="emby-checkbox" class="chkChannel" data-id="' + folder.Id + '" checked="checked"/><span>' + folder.Name + "</span></label>"
+            html += '<label><input type="checkbox" is="emby-checkbox" class="chkChannel" data-id="' + folder.Id + '" checked="checked"/><span>' + folder.Name + "</span></label>";
         }
-        html += "</div>", $(".channelAccess", page).show().html(html).trigger("create"), channels.length ? $(".channelAccessContainer", page).show() : $(".channelAccessContainer", page).hide(), $("#chkEnableAllChannels", page).checked(!0).trigger("change")
+        html += "</div>";
+        $(".channelAccess", page).show().html(html).trigger("create");
+        channels.length ? $(".channelAccessContainer", page).show() : $(".channelAccessContainer", page).hide();
+        $("#chkEnableAllChannels", page).checked(true).trigger("change");
     }
 
     function loadUser(page) {
-        $("#txtUserName", page).val(""), loading.show();
-        var promise4 = ApiClient.getJSON(ApiClient.getUrl("Library/MediaFolders", {
-                IsHidden: !1
-            })),
-            promise5 = ApiClient.getJSON(ApiClient.getUrl("Channels"));
-        Promise.all([promise4, promise5]).then(function(responses) {
-            loadMediaFolders(page, responses[0].Items), loadChannels(page, responses[1].Items), loading.hide()
+        $("#txtUserName", page).val("");
+        loading.show();
+        var promiseFolders = ApiClient.getJSON(ApiClient.getUrl("Library/MediaFolders", {
+                IsHidden: false
+        }));
+        var promiseChannels = ApiClient.getJSON(ApiClient.getUrl("Channels"));
+        Promise.all([promiseFolders, promiseChannels]).then(function(responses) {
+            loadMediaFolders(page, responses[0].Items);
+            loadChannels(page, responses[1].Items);
+            loading.hide();
         })
     }
 
     function saveUser(page) {
         var name = $("#txtUserName", page).val();
         ApiClient.createUser(name).then(function(user) {
-            user.Policy.EnableAllFolders = $("#chkEnableAllFolders", page).checked(), user.Policy.EnabledFolders = user.Policy.EnableAllFolders ? [] : $(".chkFolder", page).get().filter(function(i) {
+            user.Policy.EnableAllFolders = $("#chkEnableAllFolders", page).checked();
+            user.Policy.EnabledFolders = user.Policy.EnableAllFolders ? [] : $(".chkFolder", page).get().filter(function(i) {
                 return i.checked
             }).map(function(i) {
-                return i.getAttribute("data-id")
-            }), user.Policy.EnableAllChannels = $("#chkEnableAllChannels", page).checked(), user.Policy.EnabledChannels = user.Policy.EnableAllChannels ? [] : $(".chkChannel", page).get().filter(function(i) {
+                return i.getAttribute("data-id");
+            });
+            user.Policy.EnableAllChannels = $("#chkEnableAllChannels", page).checked();
+            user.Policy.EnabledChannels = user.Policy.EnableAllChannels ? [] : $(".chkChannel", page).get().filter(function(i) {
                 return i.checked
             }).map(function(i) {
-                return i.getAttribute("data-id")
-            }), ApiClient.updateUserPolicy(user.Id, user.Policy).then(function() {
-                Dashboard.navigate("useredit.html?userId=" + user.Id)
-            })
+                return i.getAttribute("data-id");
+            });
+            ApiClient.updateUserPolicy(user.Id, user.Policy).then(function() {
+                Dashboard.navigate("useredit.html?userId=" + user.Id);
+            });
         }, function(response) {
-            400 == response.status ? Dashboard.alert({
-                message: page.querySelector(".labelNewUserNameHelp").innerHTML
-            }) : require(["toast"], function(toast) {
-                toast(Globalize.translate("DefaultErrorMessage"))
-            }), loading.hide()
-        })
+            if (response.status == 400) {
+                Dashboard.alert({
+                    message: page.querySelector(".labelNewUserNameHelp").innerHTML
+                });
+            } else {
+                require(["toast"], function(toast) {
+                    toast(Globalize.translate("DefaultErrorMessage"));
+                });
+            }
+            loading.hide();
+        });
     }
 
     function onSubmit() {
         var page = $(this).parents(".page")[0];
-        return loading.show(), saveUser(page), !1
+        loading.show();
+        saveUser(page);
+        return false;
     }
 
     function loadData(page) {
-        loadUser(page)
+        loadUser(page);
     }
+
     $(document).on("pageinit", "#newUserPage", function() {
         var page = this;
         $("#chkEnableAllChannels", page).on("change", function() {
-            this.checked ? $(".channelAccessListContainer", page).hide() : $(".channelAccessListContainer", page).show()
-        }), $("#chkEnableAllFolders", page).on("change", function() {
-            this.checked ? $(".folderAccessListContainer", page).hide() : $(".folderAccessListContainer", page).show()
-        }), $(".newUserProfileForm").off("submit", onSubmit).on("submit", onSubmit)
+            this.checked ? $(".channelAccessListContainer", page).hide() : $(".channelAccessListContainer", page).show();
+        });
+        $("#chkEnableAllFolders", page).on("change", function() {
+            this.checked ? $(".folderAccessListContainer", page).hide() : $(".folderAccessListContainer", page).show();
+        });
+        $(".newUserProfileForm").off("submit", onSubmit).on("submit", onSubmit);
     }).on("pageshow", "#newUserPage", function() {
-        loadData(this)
-    })
+        loadData(this);
+    });
 });
\ No newline at end of file
diff --git a/src/usernew.html b/src/usernew.html
index f53bc60b9..1e5368fe2 100644
--- a/src/usernew.html
+++ b/src/usernew.html
@@ -1,8 +1,6 @@
 <div id="newUserPage" data-role="page" class="page type-interior">
-
     <div>
         <div class="content-primary">
-
             <form class="newUserProfileForm">
                 <div class="verticalSection">
                     <div class="sectionTitleContainer flex align-items-center">
@@ -29,6 +27,7 @@
                         </div>
                     </div>
                 </div>
+
                 <div class="channelAccessContainer verticalSection verticalSection-extrabottompadding" style="display:none;">
                     <h2 class="sectionTitle">${HeaderChannelAccess}</h2>
                     <div class="checkboxContainer checkboxContainer-withDescription">

From 2609bda89d8f3c11873dc4c1605b2483af0a27cb Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sun, 30 Jun 2019 01:52:57 -0700
Subject: [PATCH 2/3] add optional password field on user creation

---
 .../apiclient/apiclientcore.js                |  8 +++----
 src/controllers/usernew.js                    | 21 ++++++++-----------
 src/usernew.html                              |  6 +++++-
 3 files changed, 17 insertions(+), 18 deletions(-)

diff --git a/src/bower_components/apiclient/apiclientcore.js b/src/bower_components/apiclient/apiclientcore.js
index 2ee75beb2..ea4d05d0a 100644
--- a/src/bower_components/apiclient/apiclientcore.js
+++ b/src/bower_components/apiclient/apiclientcore.js
@@ -1190,15 +1190,13 @@ define(["events", "appStorage"], function(events, appStorage) {
             data: JSON.stringify(info),
             contentType: "application/json"
         })
-    }, ApiClient.prototype.createUser = function(name) {
+    }, ApiClient.prototype.createUser = function(user) {
         var url = this.getUrl("Users/New");
         return this.ajax({
             type: "POST",
             url: url,
-            data: {
-                Name: name
-            },
-            dataType: "json"
+            data: JSON.stringify(user),
+            contentType: "application/json"
         })
     }, ApiClient.prototype.updateUser = function(user) {
         if (!user) throw new Error("null user");
diff --git a/src/controllers/usernew.js b/src/controllers/usernew.js
index 3731df4fa..d5f924cbc 100644
--- a/src/controllers/usernew.js
+++ b/src/controllers/usernew.js
@@ -29,7 +29,8 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
     }
 
     function loadUser(page) {
-        $("#txtUserName", page).val("");
+        $("#txtUsername", page).val("");
+        $("#txtPassword", page).val("");
         loading.show();
         var promiseFolders = ApiClient.getJSON(ApiClient.getUrl("Library/MediaFolders", {
                 IsHidden: false
@@ -43,8 +44,10 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
     }
 
     function saveUser(page) {
-        var name = $("#txtUserName", page).val();
-        ApiClient.createUser(name).then(function(user) {
+        var user = {};
+        user.Name = $("#txtUsername", page).val();
+        user.Password = $("#txtPassword", page).val();
+        ApiClient.createUser(user).then(function(user) {
             user.Policy.EnableAllFolders = $("#chkEnableAllFolders", page).checked();
             user.Policy.EnabledFolders = user.Policy.EnableAllFolders ? [] : $(".chkFolder", page).get().filter(function(i) {
                 return i.checked
@@ -61,15 +64,9 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
                 Dashboard.navigate("useredit.html?userId=" + user.Id);
             });
         }, function(response) {
-            if (response.status == 400) {
-                Dashboard.alert({
-                    message: page.querySelector(".labelNewUserNameHelp").innerHTML
-                });
-            } else {
-                require(["toast"], function(toast) {
-                    toast(Globalize.translate("DefaultErrorMessage"));
-                });
-            }
+            require(["toast"], function(toast) {
+                toast(Globalize.translate("DefaultErrorMessage"));
+            });
             loading.hide();
         });
     }
diff --git a/src/usernew.html b/src/usernew.html
index 1e5368fe2..207a68ffe 100644
--- a/src/usernew.html
+++ b/src/usernew.html
@@ -9,7 +9,11 @@
                     </div>
 
                     <div class="inputContainer">
-                        <input is="emby-input" id="txtUserName" required type="text" label="${LabelName}" />
+                        <input is="emby-input" id="txtUsername" required type="text" label="${LabelName}" />
+                    </div>
+
+                    <div class="inputContainer">
+                        <input is="emby-input" id="txtPassword" type="password" label="${LabelPassword}" />
                     </div>
                 </div>
 

From b5b4bb7c7a2829dfa8dea2d49385d4133519dacd Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Mon, 1 Jul 2019 12:42:15 -0700
Subject: [PATCH 3/3] add suggested changes

---
 src/controllers/usernew.js | 44 +++++++++++++++++++++++++++-----------
 1 file changed, 31 insertions(+), 13 deletions(-)

diff --git a/src/controllers/usernew.js b/src/controllers/usernew.js
index d5f924cbc..10fa6fc4f 100644
--- a/src/controllers/usernew.js
+++ b/src/controllers/usernew.js
@@ -24,7 +24,11 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
         }
         html += "</div>";
         $(".channelAccess", page).show().html(html).trigger("create");
-        channels.length ? $(".channelAccessContainer", page).show() : $(".channelAccessContainer", page).hide();
+        if (channels.length) {
+            $(".channelAccessContainer", page).show();
+        } else {
+            $(".channelAccessContainer", page).hide();
+        }
         $("#chkEnableAllChannels", page).checked(true).trigger("change");
     }
 
@@ -49,17 +53,23 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
         user.Password = $("#txtPassword", page).val();
         ApiClient.createUser(user).then(function(user) {
             user.Policy.EnableAllFolders = $("#chkEnableAllFolders", page).checked();
-            user.Policy.EnabledFolders = user.Policy.EnableAllFolders ? [] : $(".chkFolder", page).get().filter(function(i) {
-                return i.checked
-            }).map(function(i) {
-                return i.getAttribute("data-id");
-            });
+            user.Policy.EnabledFolders = [];
+            if (!user.Policy.EnableAllFolders) {
+                user.Policy.EnabledFolders = $(".chkFolder", page).get().filter(function(i) {
+                    return i.checked
+                }).map(function(i) {
+                    return i.getAttribute("data-id");
+                });
+            }
             user.Policy.EnableAllChannels = $("#chkEnableAllChannels", page).checked();
-            user.Policy.EnabledChannels = user.Policy.EnableAllChannels ? [] : $(".chkChannel", page).get().filter(function(i) {
-                return i.checked
-            }).map(function(i) {
-                return i.getAttribute("data-id");
-            });
+            user.Policy.EnabledChannels = [];
+            if (!user.Policy.EnableAllChannels) {
+                user.Policy.EnabledChannels = $(".chkChannel", page).get().filter(function(i) {
+                    return i.checked
+                }).map(function(i) {
+                    return i.getAttribute("data-id");
+                });
+            }
             ApiClient.updateUserPolicy(user.Id, user.Policy).then(function() {
                 Dashboard.navigate("useredit.html?userId=" + user.Id);
             });
@@ -85,10 +95,18 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox"], function($, loading)
     $(document).on("pageinit", "#newUserPage", function() {
         var page = this;
         $("#chkEnableAllChannels", page).on("change", function() {
-            this.checked ? $(".channelAccessListContainer", page).hide() : $(".channelAccessListContainer", page).show();
+            if (this.checked) {
+                $(".channelAccessListContainer", page).hide();
+            } else {
+                $(".channelAccessListContainer", page).show();
+            }
         });
         $("#chkEnableAllFolders", page).on("change", function() {
-            this.checked ? $(".folderAccessListContainer", page).hide() : $(".folderAccessListContainer", page).show();
+            if (this.checked) {
+                $(".folderAccessListContainer", page).hide();
+            } else {
+                $(".folderAccessListContainer", page).show();
+            }
         });
         $(".newUserProfileForm").off("submit", onSubmit).on("submit", onSubmit);
     }).on("pageshow", "#newUserPage", function() {