Merge pull request #1980 from jellyfin/ux

Minor UX improvements

.gitignore

@@ -3,6 +3,9 @@ dist
 web
 node_modules
 
+# config
+config.json
+
 # ide
 .idea
 .vscode

package.json

@@ -245,7 +245,7 @@
           "src/controllers/dashboard/plugins/installed/index.js",
           "src/controllers/dashboard/plugins/available/index.js",
           "src/controllers/dashboard/plugins/repositories/index.js",
-          "src/controllers/dashboard/quickconnect.js",
+          "src/controllers/dashboard/quickConnect.js",
           "src/controllers/dashboard/scheduledtasks/scheduledtask.js",
           "src/controllers/dashboard/scheduledtasks/scheduledtasks.js",
           "src/controllers/dashboard/serveractivity.js",

src/config.json

@@ -1 +0,0 @@
-config.template.json

src/config.json

@@ -0,0 +1,39 @@
+{
+  "multiserver": false,
+  "themes": [
+    {
+      "name": "Apple TV",
+      "id": "appletv"
+    }, {
+      "name": "Blue Radiance",
+      "id": "blueradiance"
+    }, {
+      "name": "Dark",
+      "id": "dark",
+      "default": true
+    }, {
+      "name": "Light",
+      "id": "light"
+    }, {
+      "name": "Purple Haze",
+      "id": "purplehaze"
+    }, {
+      "name": "WMC",
+      "id": "wmc"
+    }
+  ],
+  "plugins": [
+    "plugins/playAccessValidation/plugin",
+    "plugins/experimentalWarnings/plugin",
+    "plugins/htmlAudioPlayer/plugin",
+    "plugins/htmlVideoPlayer/plugin",
+    "plugins/photoPlayer/plugin",
+    "plugins/comicsPlayer/plugin",
+    "plugins/bookPlayer/plugin",
+    "plugins/youtubePlayer/plugin",
+    "plugins/backdropScreensaver/plugin",
+    "plugins/logoScreensaver/plugin",
+    "plugins/sessionPlayer/plugin",
+    "plugins/chromecastPlayer/plugin"
+  ]
+}

src/config.template.json

@@ -1,39 +0,0 @@
-{
-    "multiserver": false,
-    "themes": [
-        {
-            "name": "Apple TV",
-            "id": "appletv"
-        }, {
-            "name": "Blue Radiance",
-            "id": "blueradiance"
-        }, {
-            "name": "Dark",
-            "id": "dark",
-            "default": true
-        }, {
-            "name": "Light",
-            "id": "light"
-        }, {
-            "name": "Purple Haze",
-            "id": "purplehaze"
-        }, {
-            "name": "WMC",
-            "id": "wmc"
-        }
-    ],
-    "plugins": [
-        "plugins/playAccessValidation/plugin",
-        "plugins/experimentalWarnings/plugin",
-        "plugins/htmlAudioPlayer/plugin",
-        "plugins/htmlVideoPlayer/plugin",
-        "plugins/photoPlayer/plugin",
-        "plugins/comicsPlayer/plugin",
-        "plugins/bookPlayer/plugin",
-        "plugins/youtubePlayer/plugin",
-        "plugins/backdropScreensaver/plugin",
-        "plugins/logoScreensaver/plugin",
-        "plugins/sessionPlayer/plugin",
-        "plugins/chromecastPlayer/plugin"
-    ]
-}

src/controllers/dashboard/dashboard.html

@@ -16,6 +16,9 @@
                     </div>
 
                     <div style="margin-top:1em;">
+                        <button is="emby-button" type="button" class="raised btnRefresh">
+                            <span>${ButtonScanAllLibraries}</span>
+                        </button>
                         <button is="emby-button" type="button" id="btnRestartServer" class="raised" onclick="DashboardPage.restart(this);" style="margin-left:0;">
                             <span>${Restart}</span>
                         </button>

src/controllers/dashboard/dashboard.js

@@ -3,6 +3,7 @@ import events from 'events';
 import itemHelper from 'itemHelper';
 import serverNotifications from 'serverNotifications';
 import dom from 'dom';
+import taskButton from 'scripts/taskbutton';
 import globalize from 'globalize';
 import * as datefns from 'date-fns';
 import dfnshelper from 'dfnshelper';
@@ -550,13 +551,13 @@ import 'emby-itemscontainer';
                 row.classList.remove('playingSession');
             }
 
-            if (session.ServerId && session.SupportedCommands.indexOf('DisplayMessage') !== -1 && session.DeviceId !== window.connectionManager.deviceId()) {
+            if (session.ServerId && session.SupportedCommands.indexOf('DisplayMessage') !== -1) {
                 row.querySelector('.btnSessionSendMessage').classList.remove('hide');
             } else {
                 row.querySelector('.btnSessionSendMessage').classList.add('hide');
             }
 
-            if (session.TranscodingInfo && session.TranscodingInfo.TranscodeReasons && session.TranscodingInfo && session.TranscodingInfo.TranscodeReasons.length) {
+            if (session.TranscodingInfo && session.TranscodingInfo.TranscodeReasons && session.TranscodingInfo) {
                 row.querySelector('.btnSessionInfo').classList.remove('hide');
             } else {
                 row.querySelector('.btnSessionInfo').classList.add('hide');
@@ -564,7 +565,7 @@ import 'emby-itemscontainer';
 
             const btnSessionPlayPause = row.querySelector('.btnSessionPlayPause');
 
-            if (session.ServerId && nowPlayingItem && session.SupportsRemoteControl && session.DeviceId !== window.connectionManager.deviceId()) {
+            if (session.ServerId && nowPlayingItem && session.SupportsRemoteControl) {
                 btnSessionPlayPause.classList.remove('hide');
                 row.querySelector('.btnSessionStop').classList.remove('hide');
             } else {
@@ -827,9 +828,17 @@ import 'emby-itemscontainer';
                 refreshActiveRecordings(view, apiClient);
                 loading.hide();
             }
+
+            taskButton({
+                mode: 'on',
+                taskKey: 'RefreshLibrary',
+                button: page.querySelector('.btnRefresh')
+            });
         });
         view.addEventListener('viewbeforehide', function () {
             const apiClient = ApiClient;
+            const page = this;
+
             events.off(serverNotifications, 'RestartRequired', onRestartRequired);
             events.off(serverNotifications, 'ServerShuttingDown', onServerShuttingDown);
             events.off(serverNotifications, 'ServerRestarting', onServerRestarting);
@@ -841,6 +850,12 @@ import 'emby-itemscontainer';
             if (apiClient) {
                 DashboardPage.stopInterval(apiClient);
             }
+
+            taskButton({
+                mode: 'off',
+                taskKey: 'RefreshLibrary',
+                button: page.querySelector('.btnRefresh')
+            });
         });
         view.addEventListener('viewdestroy', function () {
             const page = this;

src/scripts/routes.js

@@ -159,10 +159,11 @@ import 'detailtablecss';
     });
 
     defineRoute({
-        path: '/quickconnect.html',
+        alias: '/quickConnect.html',
+        path: '/controllers/dashboard/quickConnect.html',
         autoFocus: false,
         roles: 'admin',
-        controller: 'dashboard/quickconnect'
+        controller: 'dashboard/quickConnect'
     });
 
     defineRoute({

src/scripts/settings/userSettings.js

@@ -209,7 +209,7 @@ export class UserSettings {
         }
 
         val = this.get('enableBackdrops', false);
-        return val !== 'false';
+        return val === 'true';
     }
 
     /**

src/scripts/taskbutton.js

@@ -13,7 +13,7 @@ export default function (options) {
 
     function updateTasks(tasks) {
         const task = tasks.filter(function (t) {
-            return t.ScheduledTask.Key == options.taskKey;
+            return t.Key == options.taskKey;
         })[0];
 
         if (options.panel) {