diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js index 308acd79f..08c836109 100644 --- a/src/components/playback/playbackmanager.js +++ b/src/components/playback/playbackmanager.js @@ -2345,30 +2345,23 @@ class PlaybackManager { let prevRelIndex = 0; for (const stream of prevSource.MediaStreams) { - if (stream.Type != streamType) - continue; + if (stream.Type != streamType) continue; - if (stream.Index == prevIndex) - break; + if (stream.Index == prevIndex) break; prevRelIndex += 1; } let newRelIndex = 0; for (const stream of mediaSource.MediaStreams) { - if (stream.Type != streamType) - continue; + if (stream.Type != streamType) continue; let score = 0; - if (prevStream.Codec == stream.Codec) - score += 1; - if (prevRelIndex == newRelIndex) - score += 1; - if (prevStream.DisplayTitle && prevStream.DisplayTitle == stream.DisplayTitle) - score += 2; - if (prevStream.Language && prevStream.Language != 'und' && prevStream.Language == stream.Language) - score += 2; + if (prevStream.Codec == stream.Codec) score += 1; + if (prevRelIndex == newRelIndex) score += 1; + if (prevStream.DisplayTitle && prevStream.DisplayTitle == stream.DisplayTitle) score += 2; + if (prevStream.Language && prevStream.Language != 'und' && prevStream.Language == stream.Language) score += 2; console.debug(`AutoSet ${streamType} - Score ${score} for ${stream.Index} - ${stream.DisplayTitle}`); if (score > bestStreamScore && score >= 3) { @@ -2388,8 +2381,9 @@ class PlaybackManager { mediaSource.DefaultSubtitleStreamIndex = bestStreamIndex; } } - if (streamType == 'Audio') + if (streamType == 'Audio') { mediaSource.DefaultAudioStreamIndex = bestStreamIndex; + } } else { console.debug(`AutoSet ${streamType} - Threshold not met. Using default.`); } diff --git a/src/components/slideshow/slideshow.js b/src/components/slideshow/slideshow.js index 0913ed25f..c57886e0b 100644 --- a/src/components/slideshow/slideshow.js +++ b/src/components/slideshow/slideshow.js @@ -514,10 +514,12 @@ export default function (options) { function toggleFullscreenButtons(isFullscreen) { const btnFullscreen = dialog.querySelector('.btnFullscreen'); const btnFullscreenExit = dialog.querySelector('.btnFullscreenExit'); - if (btnFullscreen) + if (btnFullscreen) { btnFullscreen.classList.toggle('hide', isFullscreen); - if (btnFullscreenExit) + } + if (btnFullscreenExit) { btnFullscreenExit.classList.toggle('hide', !isFullscreen); + } } /** diff --git a/src/controllers/dashboard/devices/devices.js b/src/controllers/dashboard/devices/devices.js index f28064e09..1c5ede953 100644 --- a/src/controllers/dashboard/devices/devices.js +++ b/src/controllers/dashboard/devices/devices.js @@ -110,10 +110,11 @@ function load(page, devices) { deviceHtml += '
'; if (canDelete(device.Id)) { - if (globalize.getIsRTL()) + if (globalize.getIsRTL()) { deviceHtml += '
'; - else + } else { deviceHtml += '
'; + } deviceHtml += ''; deviceHtml += '
'; } diff --git a/src/controllers/dashboard/library.js b/src/controllers/dashboard/library.js index 08203b76f..51ca3af71 100644 --- a/src/controllers/dashboard/library.js +++ b/src/controllers/dashboard/library.js @@ -309,9 +309,7 @@ function getVirtualFolderHtml(page, virtualFolder, index) { html += '
'; // always show menu unless explicitly hidden if (virtualFolder.showMenu !== false) { - let dirTextAlign = 'right'; - if (globalize.getIsRTL()) - dirTextAlign = 'left'; + const dirTextAlign = globalize.getIsRTL() ? 'left' : 'right'; html += '
'; html += ''; html += '
'; diff --git a/src/controllers/dashboard/plugins/installed/index.js b/src/controllers/dashboard/plugins/installed/index.js index 13d0132c9..f6442710f 100644 --- a/src/controllers/dashboard/plugins/installed/index.js +++ b/src/controllers/dashboard/plugins/installed/index.js @@ -83,10 +83,11 @@ function getPluginCardHtml(plugin, pluginConfigurationPages) { html += '
'; if (configPage || plugin.CanUninstall) { - if (globalize.getIsRTL()) + if (globalize.getIsRTL()) { html += '
'; - else + } else { html += '
'; + } html += ''; html += '
'; } diff --git a/src/controllers/dashboard/scheduledtasks/scheduledtasks.js b/src/controllers/dashboard/scheduledtasks/scheduledtasks.js index 8ae447aab..f17bc5c93 100644 --- a/src/controllers/dashboard/scheduledtasks/scheduledtasks.js +++ b/src/controllers/dashboard/scheduledtasks/scheduledtasks.js @@ -57,9 +57,7 @@ function populateList(page, tasks) { html += ''; html += ''; html += '
'; - let textAlignStyle = 'left'; - if (globalize.getIsRTL()) - textAlignStyle = 'right'; + const textAlignStyle = globalize.getIsRTL() ? 'right' : 'left'; html += ""; html += "

" + task.Name + '

'; html += "
" + getTaskProgressHtml(task) + '
'; diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index 0feb6e375..80adc2db4 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -306,8 +306,7 @@ export default function (view) { function onHideAnimationComplete(e) { const elem = e.target; - if (elem != osdBottomElement) - return; + if (elem != osdBottomElement) return; elem.classList.add('hide'); dom.removeEventListener(elem, transitionEndEventName, onHideAnimationComplete, { once: true diff --git a/src/elements/emby-slider/emby-slider.js b/src/elements/emby-slider/emby-slider.js index ec93e61fd..afd949092 100644 --- a/src/elements/emby-slider/emby-slider.js +++ b/src/elements/emby-slider/emby-slider.js @@ -30,8 +30,9 @@ function mapClientToFraction(range, clientX) { const rect = range.sliderBubbleTrack.getBoundingClientRect(); let fraction = (clientX - rect.left) / rect.width; - if (globalize.getIsElementRTL(range)) + if (globalize.getIsElementRTL(range)) { fraction = (rect.right - clientX) / rect.width; + } // Snap to step const valueRange = range.max - range.min; @@ -490,10 +491,11 @@ EmbySliderPrototype.setKeyboardSteps = function (stepDown, stepUp) { function setRange(elem, startPercent, endPercent) { const style = elem.style; - if (globalize.getIsRTL()) + if (globalize.getIsRTL()) { style.right = Math.max(startPercent, 0) + '%'; - else + } else { style.left = Math.max(startPercent, 0) + '%'; + } const widthPercent = endPercent - startPercent; style.width = Math.max(Math.min(widthPercent, 100), 0) + '%'; diff --git a/src/libraries/navdrawer/navdrawer.js b/src/libraries/navdrawer/navdrawer.js index ef6dd1e04..a41085a5f 100644 --- a/src/libraries/navdrawer/navdrawer.js +++ b/src/libraries/navdrawer/navdrawer.js @@ -206,10 +206,11 @@ class NavDrawer { options.target.classList.add('touch-menu-la'); options.target.style.width = options.width + 'px'; - if (globalize.getIsRTL()) + if (globalize.getIsRTL()) { options.target.style.right = -options.width + 'px'; - else + } else { options.target.style.left = -options.width + 'px'; + } if (!options.disableMask) { this.mask = document.createElement('div'); diff --git a/src/libraries/scroller.js b/src/libraries/scroller.js index 12edc468c..a6f72c709 100644 --- a/src/libraries/scroller.js +++ b/src/libraries/scroller.js @@ -189,8 +189,9 @@ const scrollerFactory = function (frame, options) { // Set position limits & relatives self._pos.end = Math.max(slideeSize - frameSize, 0); - if (globalize.getIsRTL()) + if (globalize.getIsRTL()) { self._pos.end *= -1; + } } } diff --git a/src/plugins/comicsPlayer/plugin.js b/src/plugins/comicsPlayer/plugin.js index 58461ddc5..dd0f77da6 100644 --- a/src/plugins/comicsPlayer/plugin.js +++ b/src/plugins/comicsPlayer/plugin.js @@ -95,10 +95,11 @@ export class ComicsPlayer { onDirChanged = () => { let langDir = this.comicsPlayerSettings.langDir; - if (!langDir || langDir === 'ltr') + if (!langDir || langDir === 'ltr') { langDir = 'rtl'; - else + } else { langDir = 'ltr'; + } this.changeLanguageDirection(langDir); @@ -125,10 +126,11 @@ export class ComicsPlayer { onViewChanged = () => { let view = this.comicsPlayerSettings.pagesPerView; - if (!view || view === 1) + if (!view || view === 1) { view = 2; - else + } else { view = 1; + } this.changeView(view); diff --git a/src/scripts/globalize.js b/src/scripts/globalize.js index 21260e2be..1743890e1 100644 --- a/src/scripts/globalize.js +++ b/src/scripts/globalize.js @@ -64,8 +64,9 @@ function checkAndProcessDir(culture) { function setDocumentDirection(direction) { document.getElementsByTagName('body')[0].setAttribute('dir', direction); document.getElementsByTagName('html')[0].setAttribute('dir', direction); - if (direction === Direction.rtl) + if (direction === Direction.rtl) { import('../styles/rtl.scss'); + } } export function getIsElementRTL(element) {