From e676a3a23624e22f7cd8780fc529b0b626c86384 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Wed, 2 Dec 2020 15:43:31 -0500 Subject: [PATCH 1/2] Add console warning when plugin fails to load --- src/scripts/site.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/scripts/site.js b/src/scripts/site.js index 30b47e8e4..ace0bbbe6 100644 --- a/src/scripts/site.js +++ b/src/scripts/site.js @@ -136,13 +136,9 @@ function loadPlugins() { list = list.concat(window.NativeShell.getPlugins()); } - Promise.all(list.map((plugin) => { - return pluginManager.loadPlugin(plugin); - })) - .then(function () { - console.debug('finished loading plugins'); - }) - .catch(() => console.debug('failed loading plugins')) + Promise.all(list.map(plugin => pluginManager.loadPlugin(plugin))) + .then(() => console.debug('finished loading plugins')) + .catch(e => console.warn('failed loading plugins', e)) .finally(() => { console.groupEnd('loading installed plugins'); packageManager.init(); From 2dede415df2558c9be4baa48260a69cc10dea8e5 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Wed, 2 Dec 2020 16:24:29 -0500 Subject: [PATCH 2/2] Support plugins as classes --- src/components/pluginManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/pluginManager.js b/src/components/pluginManager.js index 9fe44ab43..6c48b7ef7 100644 --- a/src/components/pluginManager.js +++ b/src/components/pluginManager.js @@ -77,7 +77,7 @@ import { playbackManager } from './playback/playbackmanager'; let pluginInstance = await window[pluginSpec]; if (typeof pluginInstance === 'function') { - pluginInstance = await pluginInstance(); + pluginInstance = await new pluginInstance(); } // init plugin and pass basic dependencies