From 25e4d378435adb0f22739712b5cde85f0066d795 Mon Sep 17 00:00:00 2001
From: lucaperl <52839381+lucaperl@users.noreply.github.com>
Date: Sat, 28 Jan 2023 19:13:50 +0100
Subject: [PATCH 1/4] Added "Light Grey" and "Dark Grey" subtitle colors

For OLED screens and HDR content, where white subtitles would be blinding.
---
 src/components/subtitlesettings/subtitlesettings.template.html | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/components/subtitlesettings/subtitlesettings.template.html b/src/components/subtitlesettings/subtitlesettings.template.html
index 685b03997..e530b83f9 100644
--- a/src/components/subtitlesettings/subtitlesettings.template.html
+++ b/src/components/subtitlesettings/subtitlesettings.template.html
@@ -102,6 +102,8 @@
         <div class="selectContainer hide">
             <select is="emby-select" id="selectTextColor" label="${LabelTextColor}">
                 <option value="#ffffff">${White}</option>
+                <option value="#dadada">${Light Grey}</option>
+                <option value="#787878">${Dark Grey}</option>
                 <option value="#ffff00">${Yellow}</option>
                 <option value="#008000">${Green}</option>
                 <option value="#00ffff">${Cyan}</option>

From ba8abda7df0b0ad6a38fcc7bf4423116decb76ac Mon Sep 17 00:00:00 2001
From: lucaperl <52839381+lucaperl@users.noreply.github.com>
Date: Sun, 29 Jan 2023 18:44:07 +0100
Subject: [PATCH 2/4] Update subtitle color selection

Changed "Light Gray" to #d3d3d3 and "Dark Gray" to "Gray" (#808080).
---
 .../subtitlesettings/subtitlesettings.template.html           | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/subtitlesettings/subtitlesettings.template.html b/src/components/subtitlesettings/subtitlesettings.template.html
index e530b83f9..b4ef9775d 100644
--- a/src/components/subtitlesettings/subtitlesettings.template.html
+++ b/src/components/subtitlesettings/subtitlesettings.template.html
@@ -102,8 +102,8 @@
         <div class="selectContainer hide">
             <select is="emby-select" id="selectTextColor" label="${LabelTextColor}">
                 <option value="#ffffff">${White}</option>
-                <option value="#dadada">${Light Grey}</option>
-                <option value="#787878">${Dark Grey}</option>
+                <option value="#d3d3d3">${LightGray}</option>
+                <option value="#808080">${Gray}</option>
                 <option value="#ffff00">${Yellow}</option>
                 <option value="#008000">${Green}</option>
                 <option value="#00ffff">${Cyan}</option>

From c7dab8daa40a6ad4cb823170467ee2036049b0e6 Mon Sep 17 00:00:00 2001
From: lucaperl <52839381+lucaperl@users.noreply.github.com>
Date: Sun, 29 Jan 2023 19:10:20 +0100
Subject: [PATCH 3/4] Update subtitle color string keys

---
 .../subtitlesettings.template.html            | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/components/subtitlesettings/subtitlesettings.template.html b/src/components/subtitlesettings/subtitlesettings.template.html
index b4ef9775d..5f1f14ae9 100644
--- a/src/components/subtitlesettings/subtitlesettings.template.html
+++ b/src/components/subtitlesettings/subtitlesettings.template.html
@@ -101,16 +101,16 @@
 
         <div class="selectContainer hide">
             <select is="emby-select" id="selectTextColor" label="${LabelTextColor}">
-                <option value="#ffffff">${White}</option>
-                <option value="#d3d3d3">${LightGray}</option>
-                <option value="#808080">${Gray}</option>
-                <option value="#ffff00">${Yellow}</option>
-                <option value="#008000">${Green}</option>
-                <option value="#00ffff">${Cyan}</option>
-                <option value="#0000ff">${Blue}</option>
-                <option value="#ff00ff">${Magenta}</option>
-                <option value="#ff0000">${Red}</option>
-                <option value="#000000">${Black}</option>
+                <option value="#ffffff">${SubtitleWhite}</option>
+                <option value="#d3d3d3">${SubtitleLightGray}</option>
+                <option value="#808080">${SubtitleGray}</option>
+                <option value="#ffff00">${SubtitleYellow}</option>
+                <option value="#008000">${SubtitleGreen}</option>
+                <option value="#00ffff">${SubtitleCyan}</option>
+                <option value="#0000ff">${SubtitleBlue}</option>
+                <option value="#ff00ff">${SubtitleMagenta}</option>
+                <option value="#ff0000">${SubtitleRed}</option>
+                <option value="#000000">${SubtitleBlack}</option>
             </select>
         </div>
 

From 85e4f67005babefc7b08656da7d9f857e236cdd5 Mon Sep 17 00:00:00 2001
From: lucaperl <52839381+lucaperl@users.noreply.github.com>
Date: Sun, 29 Jan 2023 19:22:22 +0100
Subject: [PATCH 4/4] Add Subtitle color strings

Subtitle color strings as added in #3549 and #4311
---
 src/strings/en-us.json | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 7a2bd2168..af48ce9b8 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -1448,10 +1448,20 @@
     "Subtitle": "Subtitle",
     "SubtitleAppearanceSettingsAlsoPassedToCastDevices": "These settings also apply to any Google Cast playback started by this device.",
     "SubtitleAppearanceSettingsDisclaimer": "Following settings do not apply to the graphical subtitles mentioned above or ASS/SSA subtitles that embed their own styles.",
+    "SubtitleBlack": "Black",
+    "SubtitleBlue": "Blue",
+    "SubtitleCyan": "Cyan",
     "SubtitleDownloadersHelp": "Enable and rank your preferred subtitle downloaders in order of priority.",
+    "SubtitleGray": "Gray",
+    "SubtitleGreen": "Green",
+    "SubtitleLightGray": "Light Gray",
+    "SubtitleMagenta": "Magenta",
     "SubtitleOffset": "Subtitle Offset",
+    "SubtitleRed": "Red",
     "Subtitles": "Subtitles",
     "SubtitleVerticalPositionHelp": "Line number where text appears. Positive numbers indicate top down. Negative numbers indicate bottom up.",
+    "SubtitleWhite": "White",
+    "SubtitleYellow": "Yellow",
     "Suggestions": "Suggestions",
     "Sunday": "Sunday",
     "Sync": "Sync",