From 73083424cf1cea0402229aacffbe799c288d8f1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cosmin=20Cioacl=C4=83?= Date: Thu, 5 Oct 2023 20:00:38 +0200 Subject: [PATCH] chore: enable no-undef-init lint rule --- .eslintrc.js | 1 + src/apps/dashboard/components/activityTable/LogLevelChip.tsx | 2 +- src/components/images/imageLoader.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 4caf5f2b9..042c347fe 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -63,6 +63,7 @@ module.exports = { '@typescript-eslint/no-shadow': ['error'], 'no-throw-literal': ['error'], 'no-trailing-spaces': ['error'], + 'no-undef-init': ['error'], 'no-unused-expressions': ['off'], '@typescript-eslint/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }], 'no-unused-private-class-members': ['error'], diff --git a/src/apps/dashboard/components/activityTable/LogLevelChip.tsx b/src/apps/dashboard/components/activityTable/LogLevelChip.tsx index 8053f770c..9795c96b1 100644 --- a/src/apps/dashboard/components/activityTable/LogLevelChip.tsx +++ b/src/apps/dashboard/components/activityTable/LogLevelChip.tsx @@ -5,7 +5,7 @@ import React from 'react'; import globalize from 'scripts/globalize'; const LogLevelChip = ({ level }: { level: LogLevel }) => { - let color: 'info' | 'warning' | 'error' | undefined = undefined; + let color: 'info' | 'warning' | 'error' | undefined; switch (level) { case LogLevel.Information: color = 'info'; diff --git a/src/components/images/imageLoader.js b/src/components/images/imageLoader.js index 178312a31..561c96862 100644 --- a/src/components/images/imageLoader.js +++ b/src/components/images/imageLoader.js @@ -74,7 +74,7 @@ export function fillImage(entry) { throw new Error('entry cannot be null'); } const target = entry.target; - let source = undefined; + let source; if (target) { source = target.getAttribute('data-src');