Merge pull request #3989 from thornbill/eslint-no-useless-constructor

.eslintrc.js

@@ -57,6 +57,7 @@ module.exports = {
         'no-sequences': ['error', { 'allowInParentheses': false }],
         'no-trailing-spaces': ['error'],
         '@babel/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }],
+        'no-useless-constructor': ['error'],
         'no-void': ['error', { 'allowAsStatement': true }],
         'no-nested-ternary': ['error'],
         'one-var': ['error', 'never'],
@@ -257,7 +258,11 @@ module.exports = {
                 'plugin:react/recommended',
                 'plugin:react-hooks/recommended',
                 'plugin:jsx-a11y/recommended'
-            ]
+            ],
+            rules: {
+                'no-useless-constructor': ['off'],
+                '@typescript-eslint/no-useless-constructor': ['error']
+            }
         }
     ]
 };

src/plugins/syncPlay/core/timeSync/TimeSyncServer.js

@@ -9,10 +9,6 @@ import TimeSync from './TimeSync';
  * Class that manages time syncing with server.
  */
 class TimeSyncServer extends TimeSync {
-    constructor(syncPlayManager) {
-        super(syncPlayManager);
-    }
-
     /**
      * Makes a ping request to the server.
      */

src/plugins/syncPlay/ui/players/HtmlAudioPlayer.js

@@ -10,10 +10,6 @@ import HtmlVideoPlayer from './HtmlVideoPlayer';
  */
 class HtmlAudioPlayer extends HtmlVideoPlayer {
     static type = 'htmlaudioplayer';
-
-    constructor(player, syncPlayManager) {
-        super(player, syncPlayManager);
-    }
 }
 
 export default HtmlAudioPlayer;