milas/jellyfish-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source
This commit is contained in:
Matt Montgomery 2020-09-10 15:04:06 -05:00
parent 723472aca5
commit fa7d8bf4da
3 changed files with 45 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

90
src/controllers/dashboard/quickconnect.js
View file

@ -2,57 +2,57 @@ import loading from 'loading';
import toast from 'toast';
import globalize from 'globalize';
/* eslint-disable indent */
const unavailable = 'Unavailable';
const available = 'Available';
const active = 'Active';
let page;
let page;
export default function(view) {
view.addEventListener('viewshow', function () {
page = this;
loading.show();
page.querySelector('#btnQuickConnectSubmit').onclick = onSubmit;
updatePage();
});
}
function loadPage(status) {
let available = status === 'Available' || status === 'Active';
page.querySelector('#quickConnectStatus').textContent = status.toLocaleLowerCase();
page.querySelector('#chkQuickConnectAvailable').checked = available;
loading.hide();
}
function onSubmit() {
export default function(view) {
view.addEventListener('viewshow', function () {
page = this;
loading.show();
page.querySelector('#btnQuickConnectSubmit').onclick = onSubmit;
updatePage();
});
}
let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? 'Available' : 'Unavailable';
function loadPage(status) {
let check = status === available || status === active;
let url = ApiClient.getUrl('/QuickConnect/Available?Status=' + newStatus);
page.querySelector('#quickConnectStatus').textContent = status.toLocaleLowerCase();
page.querySelector('#chkQuickConnectAvailable').checked = check;
ApiClient.ajax({
type: 'POST',
url: url
}, true).then(() => {
toast(globalize.translate('SettingsSaved'));
setTimeout(updatePage, 500);
loading.hide();
}
return true;
}).catch((e) => {
console.error('Unable to set quick connect status. error:', e);
});
function onSubmit() {
loading.show();
loading.hide();
return false;
}
let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? available : unavailable;
function updatePage() {
ApiClient.getQuickConnect('Status').then((response) => {
loadPage(response);
return true;
}).catch((e) => {
console.error('Unable to get quick connect status. error:', e);
});
}
let url = ApiClient.getUrl('/QuickConnect/Available?Status=' + newStatus);
/* eslint-enable indent */
ApiClient.ajax({
type: 'POST',
url: url
}, true).then(() => {
toast(globalize.translate('SettingsSaved'));
setTimeout(updatePage, 500);
return true;
}).catch((e) => {
console.error('Unable to set quick connect status. error:', e);
});
loading.hide();
return false;
}
function updatePage() {
ApiClient.getQuickConnect('Status').then((response) => {
loadPage(response);
return true;
}).catch((e) => {
console.error('Unable to get quick connect status. error:', e);
});
}

5
src/controllers/user/quickConnect/index.js
View file

@ -33,11 +33,6 @@ export default function (view) {
renderPage();
});
view.addEventListener('viewbeforehide', function () {
if (quickConnectSettingsInstance) {
quickConnectSettingsInstance.submit();
}
});
function renderPage(forceActive = false) {
ApiClient.getQuickConnect('Status').then((status) => {