From a6b114ce13a9f46b99d0f97f3a25e10dd35f89bd Mon Sep 17 00:00:00 2001 From: matjaz321 Date: Tue, 11 Aug 2020 22:15:26 +0200 Subject: [PATCH 1/5] Removed code that was changing checked flag for keypress event, because it is already handled by browswer --- src/elements/emby-checkbox/emby-checkbox.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/elements/emby-checkbox/emby-checkbox.js b/src/elements/emby-checkbox/emby-checkbox.js index 84961848c..7b906286e 100644 --- a/src/elements/emby-checkbox/emby-checkbox.js +++ b/src/elements/emby-checkbox/emby-checkbox.js @@ -13,8 +13,6 @@ import 'webcomponents'; if (e.keyCode === 13 || e.keyCode === 32) { e.preventDefault(); - this.checked = !this.checked; - this.dispatchEvent(new CustomEvent('change', { bubbles: true })); From 41f627a07e6084310e2f494ca9a0ff4526088f75 Mon Sep 17 00:00:00 2001 From: matjaz321 Date: Wed, 12 Aug 2020 21:06:10 +0200 Subject: [PATCH 2/5] Added firefox browser condition --- src/elements/emby-checkbox/emby-checkbox.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/elements/emby-checkbox/emby-checkbox.js b/src/elements/emby-checkbox/emby-checkbox.js index 7b906286e..74a169629 100644 --- a/src/elements/emby-checkbox/emby-checkbox.js +++ b/src/elements/emby-checkbox/emby-checkbox.js @@ -10,9 +10,11 @@ import 'webcomponents'; function onKeyDown(e) { // Don't submit form on enter // Real (non-emulator) Tizen does nothing on Space - if (e.keyCode === 13 || e.keyCode === 32) { + if ((e.keyCode === 13 || e.keyCode === 32) && !browser.firefox) { e.preventDefault(); + this.checked = !this.checked; + this.dispatchEvent(new CustomEvent('change', { bubbles: true })); From d6ab99b59db6c73878758d4d02ed326e4478e8be Mon Sep 17 00:00:00 2001 From: Matjaz Zavski Date: Thu, 13 Aug 2020 21:22:42 +0200 Subject: [PATCH 3/5] Update src/elements/emby-checkbox/emby-checkbox.js Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --- src/elements/emby-checkbox/emby-checkbox.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/emby-checkbox/emby-checkbox.js b/src/elements/emby-checkbox/emby-checkbox.js index 74a169629..d44c58ed4 100644 --- a/src/elements/emby-checkbox/emby-checkbox.js +++ b/src/elements/emby-checkbox/emby-checkbox.js @@ -10,7 +10,7 @@ import 'webcomponents'; function onKeyDown(e) { // Don't submit form on enter // Real (non-emulator) Tizen does nothing on Space - if ((e.keyCode === 13 || e.keyCode === 32) && !browser.firefox) { + if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) { e.preventDefault(); this.checked = !this.checked; From ee54714603fb446e1cb7cc48b7f6ea75beda934c Mon Sep 17 00:00:00 2001 From: matjaz321 Date: Thu, 13 Aug 2020 21:25:38 +0200 Subject: [PATCH 4/5] Applied the same fix to the emby-radio.js --- src/elements/emby-radio/emby-radio.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/emby-radio/emby-radio.js b/src/elements/emby-radio/emby-radio.js index 6fd252908..8bd4f9fb8 100644 --- a/src/elements/emby-radio/emby-radio.js +++ b/src/elements/emby-radio/emby-radio.js @@ -9,7 +9,7 @@ import 'webcomponents'; function onKeyDown(e) { // Don't submit form on enter // Real (non-emulator) Tizen does nothing on Space - if (e.keyCode === 13 || e.keyCode === 32) { + if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) { e.preventDefault(); if (!this.checked) { From ffcc1181dcbca59438d36744991206b48df7f194 Mon Sep 17 00:00:00 2001 From: matjaz321 Date: Thu, 13 Aug 2020 22:41:49 +0200 Subject: [PATCH 5/5] small cr fix --- src/elements/emby-radio/emby-radio.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/elements/emby-radio/emby-radio.js b/src/elements/emby-radio/emby-radio.js index 8bd4f9fb8..7c468a84a 100644 --- a/src/elements/emby-radio/emby-radio.js +++ b/src/elements/emby-radio/emby-radio.js @@ -1,6 +1,7 @@ import layoutManager from 'layoutManager'; import 'css!./emby-radio'; import 'webcomponents'; +import browser from 'browser'; /* eslint-disable indent */