mirrors/fcast
1
0
Fork 0
mirror of https://gitlab.com/futo-org/fcast.git synced 2025-06-24 21:25:23 +00:00
Code Activity

Receivers: Fixed crash when ConnectionMonitor and ListenerService state is out-of-sync

Browse source
This commit is contained in:
Michael Hollister 2025-06-24 08:43:30 -05:00
parent c6106b8edc
commit d69bd8fe92
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
receivers/common/web/ConnectionMonitor.ts
View file

@ -70,6 +70,11 @@ export class ConnectionMonitor {
listener.send(Opcode.Ping, null, sessionId); listener.send(Opcode.Ping, null, sessionId);
ConnectionMonitor.heartbeatRetries.set(sessionId, ConnectionMonitor.heartbeatRetries.get(sessionId) + 1); ConnectionMonitor.heartbeatRetries.set(sessionId, ConnectionMonitor.heartbeatRetries.get(sessionId) + 1);
} }
else if (listener.getSessionProtocolVersion(sessionId) === undefined) {
ConnectionMonitor.logger.warn(`Session ${sessionId} was not found in the list of active sessions. Removing...`);
ConnectionMonitor.backendConnections.delete(sessionId);
ConnectionMonitor.heartbeatRetries.delete(sessionId);
}
} }
} }
}, ConnectionMonitor.connectionPingTimeout); }, ConnectionMonitor.connectionPingTimeout);

2
receivers/common/web/ListenerService.ts
View file

@ -82,7 +82,7 @@ export abstract class ListenerService {
} }
public getSessionProtocolVersion(sessionId: string) { public getSessionProtocolVersion(sessionId: string) {
return this.sessionMap.get(sessionId).protocolVersion; return this.sessionMap.get(sessionId)?.protocolVersion;
} }
private isSubscribedToEvent(sessionId: string, event: EventSubscribeObject) { private isSubscribedToEvent(sessionId: string, event: EventSubscribeObject) {