mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

fix some bugs reported by sonarCloud

Browse source
This commit is contained in:
vitorsemeano 2020-11-06 00:18:43 +00:00
parent 92b1cb3aa3
commit 03a6269b5f
3 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/multiSelect/multiSelect.js
View file

@ -249,12 +249,10 @@ import confirm from '../confirm/confirm';
dispatchNeedsRefresh(); dispatchNeedsRefresh();
break; break;
case 'playlist': case 'playlist':
import('../playlisteditor/playlisteditor').then((playlistEditor) => {
new playlistEditor({ new playlistEditor({
items: items, items: items,
serverId: serverId serverId: serverId
}); });
});
hideSelections(); hideSelections();
dispatchNeedsRefresh(); dispatchNeedsRefresh();
break; break;

2
src/components/playback/playbackmanager.js
View file

@ -3126,7 +3126,7 @@ class PlaybackManager {
} }
}); });
pluginManager.ofType('mediaplayer').map(initMediaPlayer); pluginManager.ofType('mediaplayer').forEach(initMediaPlayer);
function sendProgressUpdate(player, progressEventName, reportPlaylist) { function sendProgressUpdate(player, progressEventName, reportPlaylist) {
if (!player) { if (!player) {

6
src/components/playback/playersettingsmenu.js
View file

@ -33,18 +33,18 @@ function showQualityMenu(player, btn) {
return opt; return opt;
}); });
let selectedId = options.filter(function (o) { const selectedId = options.filter(function (o) {
return o.selected; return o.selected;
}); });
selectedId = selectedId.length ? selectedId[0].bitrate : null; const selectedBitrate = selectedId.length ? selectedId[0].bitrate : null;
return actionsheet.show({ return actionsheet.show({
items: menuItems, items: menuItems,
positionTo: btn positionTo: btn
}).then(function (id) { }).then(function (id) {
const bitrate = parseInt(id); const bitrate = parseInt(id);
if (bitrate !== selectedId) { if (bitrate !== selectedBitrate) {
playbackManager.setMaxStreamingBitrate({ playbackManager.setMaxStreamingBitrate({
enableAutomaticBitrateDetection: bitrate ? false : true, enableAutomaticBitrateDetection: bitrate ? false : true,
maxBitrate: bitrate maxBitrate: bitrate