From 2cf6ccef0e2e01aa039dfbd40be46d53787023ce Mon Sep 17 00:00:00 2001
From: MrTimscampi <julien.machiels@protonmail.com>
Date: Tue, 27 Jul 2021 23:52:54 +0200
Subject: [PATCH] Add new or missing person types

---
 src/components/metadataEditor/metadataEditor.js          | 4 +++-
 src/components/metadataEditor/personEditor.template.html | 6 ++++++
 src/strings/en-us.json                                   | 9 +++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js
index 49c8eb886f..c856a01f3c 100644
--- a/src/components/metadataEditor/metadataEditor.js
+++ b/src/components/metadataEditor/metadataEditor.js
@@ -925,7 +925,9 @@ import template from './metadataEditor.template.html';
             html += '</div>';
 
             if (person.Role && person.Role !== lastType) {
-                html += '<div class="secondary">' + (person.Role) + '</div>';
+                html += '<div class="secondary">' + person.Role + '</div>';
+            } else {
+                html += '<div class="secondary">' + globalize.translate(person.Type) + '</div>';
             }
 
             html += '</button>';
diff --git a/src/components/metadataEditor/personEditor.template.html b/src/components/metadataEditor/personEditor.template.html
index d2ad6a78d2..394473ed27 100644
--- a/src/components/metadataEditor/personEditor.template.html
+++ b/src/components/metadataEditor/personEditor.template.html
@@ -20,6 +20,12 @@
                 <option value="GuestStar">${GuestStar}</option>
                 <option value="Producer">${Producer}</option>
                 <option value="Writer">${Writer}</option>
+                <option value="Conductor">${Conductor}</option>
+                <option value="Lyricist">${Lyricist}</option>
+                <option value="Arranger">${Arranger}</option>
+                <option value="Engineer">${Engineer}</option>
+                <option value="Mixer">${Mixer}</option>
+                <option value="Remixer">${Remixer}</option>
             </select>
         </div>
 
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index e99165a698..21d4f536fb 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -37,6 +37,7 @@
     "Anytime": "Anytime",
     "ApiKeysCaption": "List of the currently enabled API keys",
     "AroundTime": "Around",
+    "Arranger": "Arranger",
     "Art": "Art",
     "Artist": "Artist",
     "Artists": "Artists",
@@ -133,6 +134,7 @@
     "ColorTransfer": "Color transfer",
     "CommunityRating": "Community rating",
     "Composer": "Composer",
+    "Conductor": "Conductor",
     "ConfigureDateAdded": "Configure how date added is determined in the dashboard under the library settings",
     "ConfirmDeleteImage": "Delete image?",
     "ConfirmDeleteItem": "Deleting this item will delete it from both the file system and your media library. Are you sure you wish to continue?",
@@ -230,6 +232,7 @@
     "EncoderPresetHelp": "Choose a faster value to improve performance, or a slower value to improve quality.",
     "Ended": "Ended",
     "EndsAtValue": "Ends at {0}",
+    "Engineer": "Engineer",
     "Episode": "Episode",
     "Episodes": "Episodes",
     "ErrorAddingListingsToSchedulesDirect": "There was an error adding the lineup to your Schedules Direct account. Schedules Direct only allows a limited number of lineups per account. You may need to log into the Schedules Direct website and remove others listings from your account before proceeding.",
@@ -938,6 +941,7 @@
     "LiveBroadcasts": "Live broadcasts",
     "LiveTV": "Live TV",
     "Logo": "Logo",
+    "Lyricist": "Lyricist",
     "ManageLibrary": "Manage library",
     "ManageRecording": "Manage recording",
     "MapChannels": "Map Channels",
@@ -1054,6 +1058,7 @@
     "MillisecondsUnit": "ms",
     "MinutesAfter": "minutes after",
     "MinutesBefore": "minutes before",
+    "Mixer": "Mixer",
     "Mobile": "Mobile",
     "Monday": "Monday",
     "MoreFromValue": "More from {0}",
@@ -1200,6 +1205,7 @@
     "OptionWeekly": "Weekly",
     "OriginalAirDateValue": "Original air date: {0}",
     "Other": "Other",
+    "OtherArtist": "Other Artist",
     "Overview": "Overview",
     "PackageInstallCancelled": "{0} (version {1}) installation cancelled.",
     "PackageInstallCompleted": "{0} (version {1}) installation completed.",
@@ -1282,7 +1288,9 @@
     "RefreshMetadata": "Refresh metadata",
     "RefreshQueued": "Refresh queued.",
     "ReleaseDate": "Release date",
+    "ReleaseGroup": "Release Group",
     "RememberMe": "Remember Me",
+    "Remixer": "Remixer",
     "RemoveFromCollection": "Remove from collection",
     "RemoveFromPlaylist": "Remove from playlist",
     "Repeat": "Repeat",
@@ -1410,6 +1418,7 @@
     "TitlePlayback": "Playback",
     "TonemappingAlgorithmHelp": "Tone mapping can be fine-tuned. If you are not familiar with these options, just keep the default. The recommended value is Hable.",
     "TonemappingRangeHelp": "Select the output color range. Auto is the same as the input range.",
+    "Track": "Track",
     "TrackCount": "{0} tracks",
     "Trailers": "Trailers",
     "Transcoding": "Transcoding",