From cca897bb152ddce4ac239ba4ff0c660643b1f2f8 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Fri, 17 Jan 2020 23:39:58 +0300 Subject: [PATCH 1/5] fix scroll for movie recommendation --- src/controllers/movies/moviesrecommended.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index 0327217e44..f7201307f2 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -115,7 +115,12 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" if (enableScrollX()) { allowBottomPadding = false; - html += '
'; + var scrollXClass = "scrollX hiddenScrollX"; + if (layoutManager.tv) { + scrollXClass += " smoothScrollX"; + } + + html += '
'; } else { html += '
'; } From 5b8756addf53313c610bab9331de67221a969874 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Sat, 18 Jan 2020 00:17:16 +0300 Subject: [PATCH 2/5] Fix focus --- src/controllers/movies/moviesrecommended.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index f7201307f2..2fe3d2e686 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -114,15 +114,10 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" var allowBottomPadding = true; if (enableScrollX()) { - allowBottomPadding = false; - var scrollXClass = "scrollX hiddenScrollX"; - if (layoutManager.tv) { - scrollXClass += " smoothScrollX"; - } - - html += '
'; + html += '
'; + html += '
'; } else { - html += '
'; + html += '
'; } html += cardBuilder.getCardsHtml(recommendation.Items, { @@ -131,7 +126,11 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" overlayPlayButton: true, allowBottomPadding: allowBottomPadding }); - html += "
"; + + if (enableScrollX()) { + html += '
'; + } + html += "
"; return html; } From 75185f0b23bcca9cb3e85b3fa91b470960ef49c4 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Sat, 18 Jan 2020 23:47:19 +0300 Subject: [PATCH 3/5] define emby-scroller --- src/controllers/movies/moviesrecommended.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index 2fe3d2e686..ea090553ed 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -1,4 +1,4 @@ -define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu", "mainTabsManager", "cardBuilder", "dom", "imageLoader", "playbackManager", "emby-itemscontainer", "emby-tabs", "emby-button"], function (events, layoutManager, inputManager, userSettings, libraryMenu, mainTabsManager, cardBuilder, dom, imageLoader, playbackManager) { +define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu", "mainTabsManager", "cardBuilder", "dom", "imageLoader", "playbackManager", "emby-scroller", "emby-itemscontainer", "emby-tabs", "emby-button"], function (events, layoutManager, inputManager, userSettings, libraryMenu, mainTabsManager, cardBuilder, dom, imageLoader, playbackManager) { "use strict"; function enableScrollX() { @@ -114,7 +114,7 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" var allowBottomPadding = true; if (enableScrollX()) { - html += '
'; + html += '
'; html += '
'; } else { html += '
'; From 779e3782884da0dcfe11b43c7e7c597abe559a59 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Tue, 21 Jan 2020 00:09:41 +0300 Subject: [PATCH 4/5] show title and year on movie suggestion --- src/controllers/movies/moviesrecommended.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index ea090553ed..cdcc681aa1 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -124,7 +124,10 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" shape: getPortraitShape(), scalable: true, overlayPlayButton: true, - allowBottomPadding: allowBottomPadding + allowBottomPadding: allowBottomPadding, + showTitle: true, + showYear: true, + centerText: true }); if (enableScrollX()) { From 5a6eb5eeec2aa2508fd6549390ad6ddae71f0c12 Mon Sep 17 00:00:00 2001 From: grafixeyehero Date: Wed, 22 Jan 2020 19:06:35 +0300 Subject: [PATCH 5/5] apply suggeustion --- src/controllers/movies/moviesrecommended.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index cdcc681aa1..31ded5c594 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -133,7 +133,7 @@ define(["events", "layoutManager", "inputManager", "userSettings", "libraryMenu" if (enableScrollX()) { html += '
'; } - + html += "
"; html += "
"; return html; }