From 16c75e9e5ec3d3ddef3a8b7374ee57409b9a09d7 Mon Sep 17 00:00:00 2001 From: Thibault Nocchi <1619359+ThibaultNocchi@users.noreply.github.com> Date: Thu, 30 Jan 2020 21:08:01 +0100 Subject: [PATCH] Showing toast when copying stream URL fails --- src/components/itemcontextmenu.js | 9 +++++---- src/strings/en-us.json | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/components/itemcontextmenu.js b/src/components/itemcontextmenu.js index 63c7350fd4..4e9bab6849 100644 --- a/src/components/itemcontextmenu.js +++ b/src/components/itemcontextmenu.js @@ -351,14 +351,15 @@ define(["apphost", "globalize", "connectionManager", "itemHelper", "appRouter", document.body.appendChild(textArea); textArea.focus(); textArea.select(); - try { - document.execCommand("copy"); - + if (document.execCommand("copy")) { require(["toast"], function (toast) { toast(globalize.translate("CopyStreamURLSuccess")); }); - } catch (err) { + } else { console.error("Failed to copy to clipboard"); + require(["toast"], function (toast) { + toast(globalize.translate("CopyStreamURLError")); + }); } document.body.removeChild(textArea); diff --git a/src/strings/en-us.json b/src/strings/en-us.json index f90e436645..95ce4675c9 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -161,6 +161,7 @@ "Continuing": "Continuing", "CopyStreamURL": "Copy Stream URL", "CopyStreamURLSuccess": "URL copied successfully.", + "CopyStreamURLError": "There was an error copying the URL.", "CriticRating": "Critic rating", "CustomDlnaProfilesHelp": "Create a custom profile to target a new device or override a system profile.", "DateAdded": "Date added",