diff --git a/src/RootApp.tsx b/src/RootApp.tsx
index afd9831474..53baea3c24 100644
--- a/src/RootApp.tsx
+++ b/src/RootApp.tsx
@@ -1,4 +1,3 @@
-import loadable from '@loadable/component';
import { History } from '@remix-run/router';
import { QueryClientProvider } from '@tanstack/react-query';
import { ReactQueryDevtools } from '@tanstack/react-query-devtools';
@@ -8,26 +7,17 @@ import { ApiProvider } from 'hooks/useApi';
import { WebConfigProvider } from 'hooks/useWebConfig';
import { queryClient } from 'utils/query/queryClient';
-const StableAppRouter = loadable(() => import('./apps/stable/AppRouter'));
-const RootAppRouter = loadable(() => import('./RootAppRouter'));
+import RootAppRouter from 'RootAppRouter';
-const RootApp = ({ history }: Readonly<{ history: History }>) => {
- const layoutMode = localStorage.getItem('layout');
- const isExperimentalLayout = layoutMode === 'experimental';
-
- return (
-
-
-
- {isExperimentalLayout ?
- :
-
- }
-
-
-
-
- );
-};
+const RootApp = ({ history }: Readonly<{ history: History }>) => (
+
+
+
+
+
+
+
+
+);
export default RootApp;
diff --git a/src/RootAppRouter.tsx b/src/RootAppRouter.tsx
index 1fc2293703..8d63a6724d 100644
--- a/src/RootAppRouter.tsx
+++ b/src/RootAppRouter.tsx
@@ -4,21 +4,26 @@ import React from 'react';
import {
RouterProvider,
createHashRouter,
- Outlet
+ Outlet,
+ useLocation
} from 'react-router-dom';
import { EXPERIMENTAL_APP_ROUTES } from 'apps/experimental/routes/routes';
import AppHeader from 'components/AppHeader';
import Backdrop from 'components/Backdrop';
import { useLegacyRouterSync } from 'hooks/useLegacyRouterSync';
-import { DASHBOARD_APP_ROUTES } from 'apps/dashboard/routes/routes';
+import { DASHBOARD_APP_PATHS, DASHBOARD_APP_ROUTES } from 'apps/dashboard/routes/routes';
import UserThemeProvider from 'themes/UserThemeProvider';
+import { STABLE_APP_ROUTES } from 'apps/stable/routes/routes';
+
+const layoutMode = localStorage.getItem('layout');
+const isExperimentalLayout = layoutMode === 'experimental';
const router = createHashRouter([
{
element: ,
children: [
- ...EXPERIMENTAL_APP_ROUTES,
+ ...(isExperimentalLayout ? EXPERIMENTAL_APP_ROUTES : STABLE_APP_ROUTES),
...DASHBOARD_APP_ROUTES
]
}
@@ -35,10 +40,14 @@ export default function RootAppRouter({ history }: Readonly<{ history: History}>
* NOTE: The app will crash if these get removed from the DOM.
*/
function RootAppLayout() {
+ const location = useLocation();
+ const isNewLayoutPath = Object.values(DASHBOARD_APP_PATHS)
+ .some(path => location.pathname.startsWith(`/${path}`));
+
return (
-
+
diff --git a/src/apps/dashboard/AppLayout.tsx b/src/apps/dashboard/AppLayout.tsx
index ff47e53cc6..2d954acc2e 100644
--- a/src/apps/dashboard/AppLayout.tsx
+++ b/src/apps/dashboard/AppLayout.tsx
@@ -13,23 +13,20 @@ import { useApi } from 'hooks/useApi';
import AppTabs from './components/AppTabs';
import AppDrawer from './components/drawer/AppDrawer';
+import { DASHBOARD_APP_PATHS } from './routes/routes';
import './AppOverrides.scss';
-interface AppLayoutProps {
- drawerlessPaths: string[]
-}
+const DRAWERLESS_PATHS = [ DASHBOARD_APP_PATHS.MetadataManager ];
-const AppLayout: FC = ({
- drawerlessPaths
-}) => {
+export const Component: FC = () => {
const [ isDrawerActive, setIsDrawerActive ] = useState(false);
const location = useLocation();
const { user } = useApi();
const isMediumScreen = useMediaQuery((t: Theme) => t.breakpoints.up('md'));
const isDrawerAvailable = Boolean(user)
- && !drawerlessPaths.some(path => location.pathname.startsWith(`/${path}`));
+ && !DRAWERLESS_PATHS.some(path => location.pathname.startsWith(`/${path}`));
const isDrawerOpen = isDrawerActive && isDrawerAvailable;
const onToggleDrawer = useCallback(() => {
@@ -86,5 +83,3 @@ const AppLayout: FC = ({
);
};
-
-export default AppLayout;
diff --git a/src/apps/dashboard/routes/routes.tsx b/src/apps/dashboard/routes/routes.tsx
index 16385ddf3e..bd7d926f03 100644
--- a/src/apps/dashboard/routes/routes.tsx
+++ b/src/apps/dashboard/routes/routes.tsx
@@ -1,13 +1,12 @@
import React from 'react';
import { RouteObject } from 'react-router-dom';
-import AppLayout from '../AppLayout';
import ConnectionRequired from 'components/ConnectionRequired';
import { ASYNC_ADMIN_ROUTES } from './_asyncRoutes';
import { toAsyncPageRoute } from 'components/router/AsyncRoute';
import { toViewManagerPageRoute } from 'components/router/LegacyRoute';
import { LEGACY_ADMIN_ROUTES } from './_legacyRoutes';
import ServerContentPage from 'components/ServerContentPage';
-import ErrorBoundary from '../../../components/router/ErrorBoundary';
+import ErrorBoundary from 'components/router/ErrorBoundary';
export const DASHBOARD_APP_PATHS = {
Dashboard: 'dashboard',
@@ -20,7 +19,7 @@ export const DASHBOARD_APP_ROUTES: RouteObject[] = [
element: ,
children: [
{
- element: ,
+ lazy: () => import('../AppLayout'),
children: [
{
path: DASHBOARD_APP_PATHS.Dashboard,
diff --git a/src/apps/experimental/AppLayout.tsx b/src/apps/experimental/AppLayout.tsx
index fd02220a7f..a91cbcad00 100644
--- a/src/apps/experimental/AppLayout.tsx
+++ b/src/apps/experimental/AppLayout.tsx
@@ -15,7 +15,7 @@ import AppDrawer, { isDrawerPath } from './components/drawers/AppDrawer';
import './AppOverrides.scss';
-const AppLayout = () => {
+export const Component = () => {
const [ isDrawerActive, setIsDrawerActive ] = useState(false);
const { user } = useApi();
const location = useLocation();
@@ -76,5 +76,3 @@ const AppLayout = () => {
);
};
-
-export default AppLayout;
diff --git a/src/apps/experimental/routes/routes.tsx b/src/apps/experimental/routes/routes.tsx
index c9e32899dc..b771df2581 100644
--- a/src/apps/experimental/routes/routes.tsx
+++ b/src/apps/experimental/routes/routes.tsx
@@ -8,8 +8,6 @@ import { toViewManagerPageRoute } from 'components/router/LegacyRoute';
import { toRedirectRoute } from 'components/router/Redirect';
import ErrorBoundary from 'components/router/ErrorBoundary';
-import AppLayout from '../AppLayout';
-
import { ASYNC_USER_ROUTES } from './asyncRoutes';
import { LEGACY_PUBLIC_ROUTES, LEGACY_USER_ROUTES } from './legacyRoutes';
import VideoPage from './video';
@@ -17,7 +15,7 @@ import VideoPage from './video';
export const EXPERIMENTAL_APP_ROUTES: RouteObject[] = [
{
path: '/*',
- element: ,
+ lazy: () => import('../AppLayout'),
children: [
{
/* User routes: Any child route of this layout is authenticated */
diff --git a/src/apps/stable/AppRouter.tsx b/src/apps/stable/AppRouter.tsx
deleted file mode 100644
index 40b5c2aa39..0000000000
--- a/src/apps/stable/AppRouter.tsx
+++ /dev/null
@@ -1,43 +0,0 @@
-import { History } from '@remix-run/router';
-import React from 'react';
-import { Outlet, RouterProvider, createHashRouter, useLocation } from 'react-router-dom';
-
-import { useLegacyRouterSync } from 'hooks/useLegacyRouterSync';
-import { STABLE_APP_ROUTES } from './routes/routes';
-import Backdrop from 'components/Backdrop';
-import AppHeader from 'components/AppHeader';
-import { DASHBOARD_APP_PATHS, DASHBOARD_APP_ROUTES } from 'apps/dashboard/routes/routes';
-import UserThemeProvider from 'themes/UserThemeProvider';
-
-const router = createHashRouter([{
- element: ,
- children: [
- ...STABLE_APP_ROUTES,
- ...DASHBOARD_APP_ROUTES
- ]
-}]);
-
-export default function StableAppRouter({ history }: Readonly<{ history: History }>) {
- useLegacyRouterSync({ router, history });
-
- return ;
-}
-
-/**
- * Layout component that renders legacy components required on all pages.
- * NOTE: The app will crash if these get removed from the DOM.
- */
-function StableAppLayout() {
- const location = useLocation();
- const isNewLayoutPath = Object.values(DASHBOARD_APP_PATHS)
- .some(path => location.pathname.startsWith(`/${path}`));
-
- return (
-
-
-
-
-
-
- );
-}
diff --git a/src/apps/stable/routes/routes.tsx b/src/apps/stable/routes/routes.tsx
index e5f800d20b..0eecd6b12d 100644
--- a/src/apps/stable/routes/routes.tsx
+++ b/src/apps/stable/routes/routes.tsx
@@ -16,7 +16,7 @@ import { LEGACY_PUBLIC_ROUTES, LEGACY_USER_ROUTES } from './legacyRoutes';
export const STABLE_APP_ROUTES: RouteObject[] = [
{
path: '/*',
- element: ,
+ Component: AppLayout,
children: [
{
/* User routes */