From 20fca0768a6ffb45da6ab305194e9f17acc4fd03 Mon Sep 17 00:00:00 2001 From: Ivan Schurawel Date: Mon, 12 Sep 2022 20:00:20 -0400 Subject: [PATCH] fix: set html player actionsheet to resolve on click --- src/components/actionSheet/actionSheet.js | 2 +- src/components/playback/playersettingsmenu.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/actionSheet/actionSheet.js b/src/components/actionSheet/actionSheet.js index 12d080e3b9..eacf3624b2 100644 --- a/src/components/actionSheet/actionSheet.js +++ b/src/components/actionSheet/actionSheet.js @@ -301,7 +301,7 @@ export function show(options) { resolve(selectedId); } else { - reject(); + reject('ActionSheet closed without resolving'); } } }); diff --git a/src/components/playback/playersettingsmenu.js b/src/components/playback/playersettingsmenu.js index c7f8f5a6da..efeef4f354 100644 --- a/src/components/playback/playersettingsmenu.js +++ b/src/components/playback/playersettingsmenu.js @@ -238,6 +238,7 @@ function showWithUser(options, player, user) { return actionsheet.show({ items: menuItems, + resolveOnClick: true, positionTo: options.positionTo }).then(function (id) { return handleSelectedOption(id, options, player);