From 22df1eb3a6dcc54dfd949ff63d06152c9bb2ce45 Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sat, 12 Dec 2020 00:11:52 +0900
Subject: [PATCH] Merge pull request #2210 from nyanmisaka/offset-step

Set the step of subtitle offset slider to 0.1

(cherry picked from commit c7a1c19d9e828c3908102bc6983da0b3bf2aac4c)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
---
 src/components/subtitlesync/subtitlesync.js            | 6 +++---
 src/components/subtitlesync/subtitlesync.template.html | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/subtitlesync/subtitlesync.js b/src/components/subtitlesync/subtitlesync.js
index d3477932c3..f04ce58e7a 100644
--- a/src/components/subtitlesync/subtitlesync.js
+++ b/src/components/subtitlesync/subtitlesync.js
@@ -45,11 +45,11 @@ function init(instance) {
             let inputOffset = /[-+]?\d+\.?\d*/g.exec(this.textContent);
             if (inputOffset) {
                 inputOffset = inputOffset[0];
+                inputOffset = parseFloat(inputOffset);
+                inputOffset = Math.min(30, Math.max(-30, inputOffset));
 
                 // replace current text by considered offset
                 this.textContent = inputOffset + 's';
-
-                inputOffset = parseFloat(inputOffset);
                 // set new offset
                 playbackManager.setSubtitleOffset(inputOffset, player);
                 // synchronize with slider value
@@ -121,7 +121,7 @@ function getPercentageFromOffset(value) {
     // convert fraction to percent
     percentValue *= 50;
     percentValue += 50;
-    return Math.min(100, Math.max(0, percentValue.toFixed()));
+    return Math.min(100, Math.max(0, percentValue.toFixed(1)));
 }
 
 class SubtitleSync {
diff --git a/src/components/subtitlesync/subtitlesync.template.html b/src/components/subtitlesync/subtitlesync.template.html
index fe202ebf60..8de7541635 100644
--- a/src/components/subtitlesync/subtitlesync.template.html
+++ b/src/components/subtitlesync/subtitlesync.template.html
@@ -3,7 +3,7 @@
         <button type="button" is="paper-icon-button-light" class="subtitleSync-closeButton"><span class="material-icons close"></span></button>
         <div class="subtitleSyncTextField" contenteditable="true" spellcheck="false">0s</div>
         <div class="sliderContainer subtitleSyncSliderContainer">
-            <input is="emby-slider" type="range" step="1" min="0" max="100" value="50" class="subtitleSyncSlider" data-slider-keep-progress="true" />
+            <input is="emby-slider" type="range" step=".1" min="0" max="100" value="50" class="subtitleSyncSlider" data-slider-keep-progress="true" />
         </div>
     </div>
 </div>