From 2ab12bc932b8032e96e4fe73902bb2ffc79d6e00 Mon Sep 17 00:00:00 2001
From: Bill Thornton <thornbill@users.noreply.github.com>
Date: Sun, 21 Apr 2024 12:08:39 -0400
Subject: [PATCH] Ensure loading indicator is hidden

---
 src/components/playlisteditor/playlisteditor.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/components/playlisteditor/playlisteditor.ts b/src/components/playlisteditor/playlisteditor.ts
index 940d3fb426..4335fa17ec 100644
--- a/src/components/playlisteditor/playlisteditor.ts
+++ b/src/components/playlisteditor/playlisteditor.ts
@@ -50,13 +50,13 @@ function onSubmit(this: HTMLElement, e: Event) {
         if (playlistId) {
             userSettings.set('playlisteditor-lastplaylistid', playlistId);
             addToPlaylist(panel, playlistId)
-                ?.catch(err => {
+                .catch(err => {
                     console.error('[PlaylistEditor] Failed to add to playlist %s', playlistId, err);
                 })
                 .finally(loading.hide);
         } else {
             createPlaylist(panel)
-                ?.catch(err => {
+                .catch(err => {
                     console.error('[PlaylistEditor] Failed to create playlist', err);
                 })
                 .finally(loading.hide);
@@ -105,7 +105,7 @@ function addToPlaylist(dlg: DialogElement, id: string) {
         });
         dlg.submitted = true;
         dialogHelper.close(dlg);
-        return;
+        return Promise.resolve();
     }
 
     return getPlaylistsApi(api)
@@ -131,6 +131,8 @@ function populatePlaylists(editorOptions: PlaylistEditorOptions, panel: DialogEl
         return Promise.reject(new Error('Playlist <select> element is missing'));
     }
 
+    loading.show();
+
     panel.querySelector('.newPlaylistInfo')?.classList.add('hide');
 
     const apiClient = ServerConnections.getApiClient(currentServerId);