mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Remove useless abstractions and hardcoded text for toasts

Browse source
This commit is contained in:
Bill Thornton 2021-05-26 13:12:19 -04:00
parent 5d76722a27
commit 3272d12f64
6 changed files with 10 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/recordingcreator/recordingfields.js
View file

@ -225,10 +225,6 @@ function onRecordChange(e) {
}
}
function sendToast(msg) {
toast(msg);
}
function onRecordSeriesChange(e) {
this.changed = true;
@ -252,7 +248,7 @@ function onRecordSeriesChange(e) {
} else {
if (this.SeriesTimerId) {
apiClient.cancelLiveTvSeriesTimer(this.SeriesTimerId).then(function () {
sendToast(globalize.translate('RecordingCancelled'));
toast(globalize.translate('RecordingCancelled'));
fetchData(self);
});
}

10
src/components/recordingcreator/recordinghelper.js
View file

@ -16,7 +16,7 @@ function changeRecordingToSeries(apiClient, timerId, programId, confirmTimerCanc
return apiClient.getNewLiveTvTimerDefaults({ programId: programId }).then(function (timerDefaults) {
return apiClient.createLiveTvSeriesTimer(timerDefaults).then(function () {
loading.hide();
sendToast(globalize.translate('SeriesRecordingScheduled'));
toast(globalize.translate('SeriesRecordingScheduled'));
});
});
} else {
@ -76,7 +76,7 @@ function cancelTimer(apiClient, timerId, hideLoading) {
return apiClient.cancelLiveTvTimer(timerId).then(function () {
if (hideLoading !== false) {
loading.hide();
sendToast(globalize.translate('RecordingCancelled'));
toast(globalize.translate('RecordingCancelled'));
}
});
}
@ -90,15 +90,11 @@ function createRecording(apiClient, programId, isSeries) {
return promise.then(function () {
loading.hide();
sendToast(globalize.translate('RecordingScheduled'));
toast(globalize.translate('RecordingScheduled'));
});
});
}
function sendToast(msg) {
toast(msg);
}
function showMultiCancellationPrompt(serverId, programId, timerId, timerStatus, seriesTimerId) {
return new Promise(function (resolve, reject) {
const items = [];

4
src/components/remotecontrol/remotecontrol.js
View file

@ -865,7 +865,7 @@ export default function () {
}, currentPlayer);
form.querySelector('input').value = '';
toast('Message sent.');
toast(globalize.translate('MessageSent'));
e.preventDefault();
e.stopPropagation();
@ -882,7 +882,7 @@ export default function () {
}, currentPlayer);
form.querySelector('input').value = '';
toast('Text sent.');
toast(globalize.translate('TextSent'));
e.preventDefault();
e.stopPropagation();

6
src/components/shortcuts.js
View file

@ -167,10 +167,6 @@ import toast from './toast/toast';
});
}
function sendToast(text) {
toast(text);
}
function executeAction(card, target, action) {
target = target || card;
@ -222,7 +218,7 @@ import toast from './toast/toast';
ids: [playableItemId],
serverId: serverId
});
sendToast(globalize.translate('MediaQueued'));
toast(globalize.translate('MediaQueued'));
} else {
playbackManager.queue({
ids: [playableItemId],

2
src/controllers/dashboard/dlna/profile.js
View file

@ -635,7 +635,7 @@ import toast from '../../../components/toast/toast';
data: JSON.stringify(profile),
contentType: 'application/json'
}).then(function () {
toast('Settings saved.');
toast(globalize.translate('SettingsSaved'));
}, Dashboard.processErrorResponse);
} else {
ApiClient.ajax({

2
src/strings/en-us.json
View file

@ -1024,6 +1024,7 @@
"MessagePluginInstalled": "The plugin has been successfully installed. The server will need to be restarted for changes to take effect.",
"MessagePluginInstallError": "An error occured while installing the plugin.",
"MessageReenableUser": "See below to reenable",
"MessageSent": "Message sent.",
"MessageSyncPlayCreateGroupDenied": "Permission required to create a group.",
"MessageSyncPlayDisabled": "SyncPlay disabled.",
"MessageSyncPlayEnabled": "SyncPlay enabled.",
@ -1393,6 +1394,7 @@
"Tags": "Tags",
"TagsValue": "Tags: {0}",
"TellUsAboutYourself": "Tell us about yourself",
"TextSent": "Text sent.",
"ThemeSongs": "Theme songs",
"ThemeVideos": "Theme videos",
"TheseSettingsAffectSubtitlesOnThisDevice": "These settings affect subtitles on this device",