Add some linting rules for the CI (#587)

* enable one-var rule

* enable indent rule

* enable no-multiple-empty-lines rule

* enable no-empty rule

* enable no-trailing-spaces rule

* enable no-extra-semi rule

* add eslint rules to fix block spacing

* enable max-statements-per-line rule

* enable brace-style rule

* fix some spacing issues and add future rules

* add code suggestions

src/scripts/browser.js

@@ -30,7 +30,6 @@ define([], function () {
     }
 
     function isMobile(userAgent) {
-
         var terms = [
             'mobi',
             'ipad',
@@ -144,14 +143,16 @@ define([], function () {
             }
         }
 
-        var animation = false,
-            animationstring = 'animation',
-            keyframeprefix = '',
-            domPrefixes = ['Webkit', 'O', 'Moz'],
-            pfx = '',
-            elm = document.createElement('div');
+        var animation = false;
+        var animationstring = 'animation';
+        var keyframeprefix = '';
+        var domPrefixes = ['Webkit', 'O', 'Moz'];
+        var pfx = '';
+        var elm = document.createElement('div');
 
-        if (elm.style.animationName !== undefined) { animation = true; }
+        if (elm.style.animationName !== undefined) {
+            animation = true;
+        }
 
         if (animation === false && allowPrefix) {
             for (var i = 0; i < domPrefixes.length; i++) {
@@ -204,8 +205,7 @@ define([], function () {
 
                 // http://www.neowin.net/news/ie11-fakes-user-agent-to-fool-gmail-in-windows-phone-81-gdr1-update
                 browser = "msie";
-            }
-            else if (ua.indexOf("like gecko") !== -1 && ua.indexOf('webkit') === -1 && ua.indexOf('opera') === -1 && ua.indexOf('chrome') === -1 && ua.indexOf('safari') === -1) {
+            } else if (ua.indexOf("like gecko") !== -1 && ua.indexOf('webkit') === -1 && ua.indexOf('opera') === -1 && ua.indexOf('chrome') === -1 && ua.indexOf('safari') === -1) {
                 browser = "msie";
             }
         }

src/scripts/browserdeviceprofile.js

@@ -88,18 +88,14 @@ define(['browser'], function (browser) {
             if (browser.edgeUwp) {
                 return true;
             }
-        }
-
-        else if (format === 'wma') {
+        } else if (format === 'wma') {
             if (browser.tizen || browser.orsay) {
                 return true;
             }
             if (browser.edgeUwp) {
                 return true;
             }
-        }
-
-        else if (format === 'opus') {
+        } else if (format === 'opus') {
             typeString = 'audio/ogg; codecs="opus"';
 
             if (document.createElement('audio').canPlayType(typeString).replace(/no/, '')) {
@@ -107,9 +103,7 @@ define(['browser'], function (browser) {
             }
 
             return false;
-        }
-
-        else if (format === 'mp2') {
+        } else if (format === 'mp2') {
 
             // For now
             return false;
@@ -575,9 +569,7 @@ define(['browser'], function (browser) {
                     Type: 'Audio',
                     AudioCodec: audioFormat
                 });
-            }
-
-            else if (audioFormat === 'mp3') {
+            } else if (audioFormat === 'mp3') {
 
                 profile.DirectPlayProfiles.push({
                     Container: audioFormat,

src/scripts/editorsidebar.js

@@ -2,19 +2,19 @@ define(["datetime", "jQuery", "material-icons"], function (datetime, $) {
     "use strict";
 
     function getNode(item, folderState, selected) {
-        var htmlName = getNodeInnerHtml(item),
-            node = {
-                id: item.Id,
-                text: htmlName,
-                state: {
-                    opened: item.IsFolder && folderState == "open",
-                    selected: selected
-                },
-                li_attr: {
-                    serveritemtype: item.Type,
-                    collectiontype: item.CollectionType
-                }
-            };
+        var htmlName = getNodeInnerHtml(item);
+        var node = {
+            id: item.Id,
+            text: htmlName,
+            state: {
+                opened: item.IsFolder && folderState == "open",
+                selected: selected
+            },
+            li_attr: {
+                serveritemtype: item.Type,
+                collectiontype: item.CollectionType
+            }
+        };
         if (item.IsFolder) {
             node.children = [{
                 text: "Loading...",
@@ -44,20 +44,15 @@ define(["datetime", "jQuery", "material-icons"], function (datetime, $) {
         var htmlName = "<div class='editorNode'>";
         if (item.IsFolder) {
             htmlName += '<i class="md-icon metadataSidebarIcon">folder</i>';
-        }
-        else if (item.MediaType === "Video") {
+        } else if (item.MediaType === "Video") {
             htmlName += '<i class="md-icon metadataSidebarIcon">movie</i>';
-        }
-        else if (item.MediaType === "Audio") {
+        } else if (item.MediaType === "Audio") {
             htmlName += '<i class="md-icon metadataSidebarIcon">audiotrack</i>';
-        }
-        else if (item.Type === "TvChannel") {
+        } else if (item.Type === "TvChannel") {
             htmlName += '<i class="md-icon metadataSidebarIcon">live_tv</i>';
-        }
-        else if (item.MediaType === "Photo") {
+        } else if (item.MediaType === "Photo") {
             htmlName += '<i class="md-icon metadataSidebarIcon">photo</i>';
-        }
-        else if (item.MediaType === "Book") {
+        } else if (item.MediaType === "Book") {
             htmlName += '<i class="md-icon metadataSidebarIcon">book</i>';
         }
         if (item.LockData) {

src/scripts/librarybrowser.js

@@ -156,7 +156,8 @@ define(["userSettings"], function (userSettings) {
                 html += '<h2 style="margin:0 0 .5em;">';
                 html += Globalize.translate("HeaderSortBy");
                 html += "</h2>";
-                var i, length;
+                var i;
+                var length;
                 var isChecked;
                 html += '<div>';
                 for (i = 0, length = options.items.length; i < length; i++) {

src/scripts/librarymenu.js

@@ -189,7 +189,6 @@ define(["dom", "layoutManager", "inputManager", "connectionManager", "events", "
             html += "</div>";
         }
 
-
         // add buttons to navigation drawer
         navDrawerScrollContainer.innerHTML = html;
         // bind logout button click to method

src/scripts/routes.js

@@ -447,6 +447,6 @@ define([
     defineRoute({
         path: "/",
         isDefaultRoute: true,
-        autoFocus: false,
+        autoFocus: false
     });
 });