From 3ab41f77eac83dff409d7c20b374ea4d5013f446 Mon Sep 17 00:00:00 2001 From: Nathan Mascitelli Date: Thu, 29 Apr 2021 22:19:20 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --- src/components/homesections/homesections.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/components/homesections/homesections.js b/src/components/homesections/homesections.js index bc31d60495..85b5583f7b 100644 --- a/src/components/homesections/homesections.js +++ b/src/components/homesections/homesections.js @@ -153,7 +153,7 @@ import ServerConnections from '../ServerConnections'; loadNextUp(elem, apiClient); } else if (section === 'onnow' || section === 'livetv') { return loadOnNow(elem, apiClient, user); - } else if (section == 'resumebook') { + } else if (section === 'resumebook') { return loadResume(elem, apiClient, 'HeaderContinueReading', 'Book'); } else { elem.innerHTML = ''; @@ -369,23 +369,22 @@ import ServerConnections from '../ServerConnections'; imageLoader.lazyChildren(elem); } + const dataMonitorHints = { + 'Audio': 'audioplayback,markplayed', + 'Video': 'videoplayback,markplayed' + }; + function loadResume(elem, apiClient, headerText, mediaType) { let html = ''; - let dataMonitor = 'data-monitor="'; - if (mediaType == 'Video') { - dataMonitor += 'videoplayback,' - } else if (mediaType == 'Audio') { - dataMonitor += 'audioplayback,' - } - dataMonitor += 'markplayed">'; + const dataMonitor = dataMonitorHints[mediaType] || 'markplayed'; html += '

' + globalize.translate(headerText) + '

'; if (enableScrollX()) { html += '
'; - html += '
`; } else { - html += '
`; } if (enableScrollX()) {