From 3ad2c1bfd1cb225b93711388a9ece1f167d6f10c Mon Sep 17 00:00:00 2001 From: grafixeyehero <32230989+grafixeyehero@users.noreply.github.com> Date: Sat, 9 Oct 2021 23:00:04 +0300 Subject: [PATCH] fix sonarcloud Code Smell Refactoring Cognitive Complexity --- src/components/pages/NewUserPage.tsx | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/src/components/pages/NewUserPage.tsx b/src/components/pages/NewUserPage.tsx index 77571c5495..8e65d46fe2 100644 --- a/src/components/pages/NewUserPage.tsx +++ b/src/components/pages/NewUserPage.tsx @@ -76,11 +76,8 @@ const NewUserPage: FunctionComponent = () => { const channelAccess = element?.current?.querySelector('.channelAccess'); channelAccess.dispatchEvent(new CustomEvent('create')); - if (channels.length) { - element?.current?.querySelector('.channelAccessContainer').classList.remove('hide'); - } else { - element?.current?.querySelector('.channelAccessContainer').classList.add('hide'); - } + const channelAccessContainer = element?.current?.querySelector('.channelAccessContainer'); + channels.length ? channelAccessContainer.classList.remove('hide') : channelAccessContainer.classList.add('hide'); element.current.querySelector('.chkEnableAllChannels').checked = false; }; @@ -129,22 +126,14 @@ const NewUserPage: FunctionComponent = () => { return false; }; - const chkEnableAllChannels = element?.current?.querySelector('.chkEnableAllChannels'); - chkEnableAllChannels.addEventListener('change', function (this: HTMLInputElement) { - if (this.checked) { - element?.current?.querySelector('.channelAccessListContainer').classList.add('hide'); - } else { - element?.current?.querySelector('.channelAccessListContainer').classList.remove('hide'); - } + element?.current?.querySelector('.chkEnableAllChannels').addEventListener('change', function (this: HTMLInputElement) { + const channelAccessListContainer = element?.current?.querySelector('.channelAccessListContainer'); + this.checked ? channelAccessListContainer.classList.add('hide') : channelAccessListContainer.classList.remove('hide'); }); - const chkEnableAllFolders = element?.current?.querySelector('.chkEnableAllFolders'); - chkEnableAllFolders.addEventListener('change', function (this: HTMLInputElement) { - if (this.checked) { - element?.current?.querySelector('.folderAccessListContainer').classList.add('hide'); - } else { - element?.current?.querySelector('.folderAccessListContainer').classList.remove('hide'); - } + element?.current?.querySelector('.chkEnableAllFolders').addEventListener('change', function (this: HTMLInputElement) { + const folderAccessListContainer = element?.current?.querySelector('.folderAccessListContainer'); + this.checked ? folderAccessListContainer.classList.add('hide') : folderAccessListContainer.classList.remove('hide'); }); element?.current?.querySelector('.newUserProfileForm').addEventListener('submit', onSubmit);