1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00

Fixed code smell and removed plugin helper

This commit is contained in:
Cromefire_ 2020-04-27 14:20:32 +02:00
parent 0ee1c1ec80
commit 3b5e5cf7cf
No known key found for this signature in database
GPG key ID: D3D3DB179F435F0C

View file

@ -4,7 +4,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou
// TODO: replace with each plugin version // TODO: replace with each plugin version
var cacheParam = new Date().getTime(); var cacheParam = new Date().getTime();
function loadStrings(plugin, globalize) { function loadStrings(plugin) {
var strings = plugin.getTranslations ? plugin.getTranslations() : []; var strings = plugin.getTranslations ? plugin.getTranslations() : [];
return globalize.loadStrings({ return globalize.loadStrings({
name: plugin.id || plugin.packageName, name: plugin.id || plugin.packageName,
@ -44,7 +44,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou
return Promise.resolve(plugin); return Promise.resolve(plugin);
} else { } else {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
loadStrings(plugin, globalize) loadStrings(plugin)
.then(function () { .then(function () {
resolve(plugin); resolve(plugin);
}) })
@ -95,8 +95,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou
}); });
} else if (pluginSpec.then) { } else if (pluginSpec.then) {
return pluginSpec.then(pluginBuilder => { return pluginSpec.then(pluginBuilder => {
const pluginHelper = {}; // TODO: Advance this return pluginBuilder();
return pluginBuilder(pluginHelper);
}).then(plugin => { }).then(plugin => {
return registerPlugin(plugin); return registerPlugin(plugin);
}); });