From 3d9a119d389431bdaaa1832ad5f0f2121c3b727b Mon Sep 17 00:00:00 2001
From: venkata nadha reddy <45334400+venkat-karasani@users.noreply.github.com>
Date: Fri, 19 Jul 2024 16:53:44 +0000
Subject: [PATCH] Fix stuck page titles on admin dashboard (#5735)

* Fixed stuck page titles on admin dashboard.

* Updating contributors
---
 CONTRIBUTORS.md                                              | 1 +
 src/apps/dashboard/routes/playback/trickplay.tsx             | 1 +
 src/apps/dashboard/routes/users/index.tsx                    | 1 +
 src/controllers/dashboard/apikeys.html                       | 2 +-
 src/controllers/dashboard/dashboard.html                     | 2 +-
 src/controllers/dashboard/devices/devices.html               | 2 +-
 src/controllers/dashboard/encodingsettings.html              | 2 +-
 src/controllers/dashboard/general.html                       | 2 +-
 src/controllers/dashboard/library.html                       | 2 +-
 src/controllers/dashboard/librarydisplay.html                | 2 +-
 src/controllers/dashboard/logs.html                          | 2 +-
 src/controllers/dashboard/metadataimages.html                | 2 +-
 src/controllers/dashboard/metadatanfo.html                   | 2 +-
 src/controllers/dashboard/networking.html                    | 2 +-
 src/controllers/dashboard/playback.html                      | 2 +-
 src/controllers/dashboard/plugins/available/index.html       | 2 +-
 src/controllers/dashboard/plugins/installed/index.html       | 2 +-
 src/controllers/dashboard/plugins/repositories/index.html    | 2 +-
 src/controllers/dashboard/scheduledtasks/scheduledtasks.html | 2 +-
 src/controllers/dashboard/streaming.html                     | 2 +-
 src/controllers/livetvsettings.html                          | 2 +-
 src/controllers/livetvstatus.html                            | 2 +-
 22 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
index 2a928215b3..db04495ec6 100644
--- a/CONTRIBUTORS.md
+++ b/CONTRIBUTORS.md
@@ -89,6 +89,7 @@
 - [Pithaya](https://github.com/Pithaya)
 - [Peter Santos](https://github.com/prsantos-com)
 - [Chaitanya Shahare](https://github.com/Chaitanya-Shahare)
+- [Venkat Karasani](https://github.com/venkat-karasani)
 
 ## Emby Contributors
 
diff --git a/src/apps/dashboard/routes/playback/trickplay.tsx b/src/apps/dashboard/routes/playback/trickplay.tsx
index 56f155be6b..90eec1641d 100644
--- a/src/apps/dashboard/routes/playback/trickplay.tsx
+++ b/src/apps/dashboard/routes/playback/trickplay.tsx
@@ -142,6 +142,7 @@ const PlaybackTrickplay: FC = () => {
         <Page
             id='trickplayConfigurationPage'
             className='mainAnimatedPage type-interior playbackConfigurationPage'
+            title={globalize.translate('Trickplay')}
         >
             <div ref={element} className='content-primary'>
                 <div className='verticalSection'>
diff --git a/src/apps/dashboard/routes/users/index.tsx b/src/apps/dashboard/routes/users/index.tsx
index 78676b3487..5c31c902cd 100644
--- a/src/apps/dashboard/routes/users/index.tsx
+++ b/src/apps/dashboard/routes/users/index.tsx
@@ -159,6 +159,7 @@ const UserProfiles = () => {
         <Page
             id='userProfilesPage'
             className='mainAnimatedPage type-interior userProfilesPage fullWidthContent'
+            title={globalize.translate('HeaderUsers')}
         >
             <div ref={element} className='content-primary'>
                 <div className='verticalSection'>
diff --git a/src/controllers/dashboard/apikeys.html b/src/controllers/dashboard/apikeys.html
index 400a3e5f60..fd8ade8bba 100644
--- a/src/controllers/dashboard/apikeys.html
+++ b/src/controllers/dashboard/apikeys.html
@@ -1,4 +1,4 @@
-<div id="apiKeysPage" data-role="page" class="page type-interior advancedConfigurationPage fullWidthContent">
+<div id="apiKeysPage" data-role="page" class="page type-interior advancedConfigurationPage fullWidthContent" data-title="${HeaderApiKeys}">
     <div>
         <div class="content-primary">
             <div class="detailSectionHeader">
diff --git a/src/controllers/dashboard/dashboard.html b/src/controllers/dashboard/dashboard.html
index 4dd260877c..aafe8de61b 100644
--- a/src/controllers/dashboard/dashboard.html
+++ b/src/controllers/dashboard/dashboard.html
@@ -1,4 +1,4 @@
-<div id="dashboardPage" data-role="page" class="page type-interior dashboardHomePage fullWidthContent">
+<div id="dashboardPage" data-role="page" class="page type-interior dashboardHomePage fullWidthContent" data-title="${TabDashboard}">
     <div class="content-primary">
         <div class="dashboardSections" style="padding-top:.5em;">
             <div class="dashboardColumn dashboardColumn-2-60 dashboardColumn-3-46">
diff --git a/src/controllers/dashboard/devices/devices.html b/src/controllers/dashboard/devices/devices.html
index 48aca5ef83..c5a4d732b5 100644
--- a/src/controllers/dashboard/devices/devices.html
+++ b/src/controllers/dashboard/devices/devices.html
@@ -1,4 +1,4 @@
-<div id="devicesPage" data-role="page" class="page type-interior devicesPage noSecondaryNavPage">
+<div id="devicesPage" data-role="page" class="page type-interior devicesPage noSecondaryNavPage" data-title="${HeaderDevices}">
     <div>
         <div class="content-primary">
             <div class="verticalSection verticalSection">
diff --git a/src/controllers/dashboard/encodingsettings.html b/src/controllers/dashboard/encodingsettings.html
index 89dede8e49..d83d31445c 100644
--- a/src/controllers/dashboard/encodingsettings.html
+++ b/src/controllers/dashboard/encodingsettings.html
@@ -1,4 +1,4 @@
-<div id="encodingSettingsPage" data-role="page" class="page type-interior playbackConfigurationPage">
+<div id="encodingSettingsPage" data-role="page" class="page type-interior playbackConfigurationPage" data-title="${TitlePlayback}">
     <div>
         <div class="content-primary">
             <form class="encodingSettingsForm">
diff --git a/src/controllers/dashboard/general.html b/src/controllers/dashboard/general.html
index c1cb04a9e1..7ab360fdc3 100644
--- a/src/controllers/dashboard/general.html
+++ b/src/controllers/dashboard/general.html
@@ -1,4 +1,4 @@
-<div id="dashboardGeneralPage" data-role="page" class="page type-interior dashboardHomePage">
+<div id="dashboardGeneralPage" data-role="page" class="page type-interior dashboardHomePage" data-title="${General}">
     <div>
         <div class="content-primary">
             <form class="dashboardGeneralForm">
diff --git a/src/controllers/dashboard/library.html b/src/controllers/dashboard/library.html
index 843854b8b8..ba499185b3 100644
--- a/src/controllers/dashboard/library.html
+++ b/src/controllers/dashboard/library.html
@@ -1,4 +1,4 @@
-<div id="mediaLibraryPage" data-role="page" class="page type-interior mediaLibraryPage librarySectionPage fullWidthContent">
+<div id="mediaLibraryPage" data-role="page" class="page type-interior mediaLibraryPage librarySectionPage fullWidthContent" data-title="${HeaderLibraries}">
     <div>
         <div class="content-primary">
             <div class="padded-top padded-bottom">
diff --git a/src/controllers/dashboard/librarydisplay.html b/src/controllers/dashboard/librarydisplay.html
index d7bcffafda..d641e30c1e 100644
--- a/src/controllers/dashboard/librarydisplay.html
+++ b/src/controllers/dashboard/librarydisplay.html
@@ -1,4 +1,4 @@
-<div id="libraryDisplayPage" data-role="page" class="page type-interior librarySectionPage">
+<div id="libraryDisplayPage" data-role="page" class="page type-interior librarySectionPage" data-title="${Display}">
     <div>
         <div class="content-primary">
             <form>
diff --git a/src/controllers/dashboard/logs.html b/src/controllers/dashboard/logs.html
index c0ab76d9a4..a23d7750f4 100644
--- a/src/controllers/dashboard/logs.html
+++ b/src/controllers/dashboard/logs.html
@@ -1,4 +1,4 @@
-<div id="logPage" data-role="page" class="page type-interior">
+<div id="logPage" data-role="page" class="page type-interior" data-title="${TabLogs}">
     <div>
         <div class="content-primary">
             <form class="logsForm">
diff --git a/src/controllers/dashboard/metadataimages.html b/src/controllers/dashboard/metadataimages.html
index afa7a4bc96..0d7d349ecd 100644
--- a/src/controllers/dashboard/metadataimages.html
+++ b/src/controllers/dashboard/metadataimages.html
@@ -1,4 +1,4 @@
-<div id="metadataImagesConfigurationPage" data-role="page" class="page type-interior metadataConfigurationPage">
+<div id="metadataImagesConfigurationPage" data-role="page" class="page type-interior metadataConfigurationPage" data-title="${Metadata}">
 
     <div>
 
diff --git a/src/controllers/dashboard/metadatanfo.html b/src/controllers/dashboard/metadatanfo.html
index 362be76faf..62f18b2641 100644
--- a/src/controllers/dashboard/metadatanfo.html
+++ b/src/controllers/dashboard/metadatanfo.html
@@ -1,4 +1,4 @@
-<div id="metadataNfoPage" data-role="page" class="page type-interior metadataConfigurationPage">
+<div id="metadataNfoPage" data-role="page" class="page type-interior metadataConfigurationPage" data-title="${TabNfoSettings}">
 
     <div>
 
diff --git a/src/controllers/dashboard/networking.html b/src/controllers/dashboard/networking.html
index 8a9f26e8d9..fd9a910288 100644
--- a/src/controllers/dashboard/networking.html
+++ b/src/controllers/dashboard/networking.html
@@ -1,4 +1,4 @@
-<div id="networkingPage" data-role="page" class="page type-interior advancedConfigurationPage">
+<div id="networkingPage" data-role="page" class="page type-interior advancedConfigurationPage" data-title="${TabNetworking}">
     <div>
         <div class="content-primary">
             <form class="dashboardHostingForm">
diff --git a/src/controllers/dashboard/playback.html b/src/controllers/dashboard/playback.html
index ff7e2bf502..87438cf86e 100644
--- a/src/controllers/dashboard/playback.html
+++ b/src/controllers/dashboard/playback.html
@@ -1,4 +1,4 @@
-<div id="playbackConfigurationPage" data-role="page" class="page type-interior playbackConfigurationPage">
+<div id="playbackConfigurationPage" data-role="page" class="page type-interior playbackConfigurationPage" data-title="${ButtonResume}">
     <div>
         <div class="content-primary">
             <form class="playbackConfigurationForm">
diff --git a/src/controllers/dashboard/plugins/available/index.html b/src/controllers/dashboard/plugins/available/index.html
index 2a742c684c..4a9fca63e0 100644
--- a/src/controllers/dashboard/plugins/available/index.html
+++ b/src/controllers/dashboard/plugins/available/index.html
@@ -1,4 +1,4 @@
-<div id="pluginCatalogPage" data-role="page" class="page type-interior pluginConfigurationPage fullWidthContent">
+<div id="pluginCatalogPage" data-role="page" class="page type-interior pluginConfigurationPage fullWidthContent" data-title="${TabCatalog}">
     <div>
         <div class="content-primary">
             <div class="sectionTitleContainer flex align-items-center">
diff --git a/src/controllers/dashboard/plugins/installed/index.html b/src/controllers/dashboard/plugins/installed/index.html
index e44dcbe2a3..6f0d2c593c 100644
--- a/src/controllers/dashboard/plugins/installed/index.html
+++ b/src/controllers/dashboard/plugins/installed/index.html
@@ -1,4 +1,4 @@
-<div id="pluginsPage" data-role="page" class="page type-interior pluginConfigurationPage fullWidthContent">
+<div id="pluginsPage" data-role="page" class="page type-interior pluginConfigurationPage fullWidthContent" data-title="${TabPlugins}">
     <div>
         <div class="content-primary">
             <div class="sectionTitleContainer flex align-items-center">
diff --git a/src/controllers/dashboard/plugins/repositories/index.html b/src/controllers/dashboard/plugins/repositories/index.html
index e793df2532..689c261a08 100644
--- a/src/controllers/dashboard/plugins/repositories/index.html
+++ b/src/controllers/dashboard/plugins/repositories/index.html
@@ -1,4 +1,4 @@
-<div id="repositories" data-role="page" class="page type-interior fullWidthContent">
+<div id="repositories" data-role="page" class="page type-interior fullWidthContent" data-title="${TabRepositories}">
     <div>
         <div class="content-primary">
             <div class="sectionTitleContainer flex align-items-center">
diff --git a/src/controllers/dashboard/scheduledtasks/scheduledtasks.html b/src/controllers/dashboard/scheduledtasks/scheduledtasks.html
index cbff6bcd9d..299bed531f 100644
--- a/src/controllers/dashboard/scheduledtasks/scheduledtasks.html
+++ b/src/controllers/dashboard/scheduledtasks/scheduledtasks.html
@@ -1,4 +1,4 @@
-<div id="scheduledTasksPage" data-role="page" class="page type-interior scheduledTasksConfigurationPage">
+<div id="scheduledTasksPage" data-role="page" class="page type-interior scheduledTasksConfigurationPage" data-title="${TabScheduledTasks}">
     <style>
         .taskProgressOuter {
             height: 6px;
diff --git a/src/controllers/dashboard/streaming.html b/src/controllers/dashboard/streaming.html
index 4219e63a5c..54cb895623 100644
--- a/src/controllers/dashboard/streaming.html
+++ b/src/controllers/dashboard/streaming.html
@@ -1,4 +1,4 @@
-<div id="streamingSettingsPage" data-role="page" class="page type-interior playbackConfigurationPage">
+<div id="streamingSettingsPage" data-role="page" class="page type-interior playbackConfigurationPage" data-title="${TabStreaming}">
     <div>
         <div class="content-primary">
             <form class="streamingSettingsForm">
diff --git a/src/controllers/livetvsettings.html b/src/controllers/livetvsettings.html
index 4e455f34a1..3faf39e693 100644
--- a/src/controllers/livetvsettings.html
+++ b/src/controllers/livetvsettings.html
@@ -1,4 +1,4 @@
-<div id="liveTvSettingsPage" data-role="page" class="page type-interior liveTvPage">
+<div id="liveTvSettingsPage" data-role="page" class="page type-interior liveTvPage" data-title="${HeaderDVR}">
     <div>
         <div class="content-primary">
             <div class="verticalSection">
diff --git a/src/controllers/livetvstatus.html b/src/controllers/livetvstatus.html
index f3d9e15945..80d6fb4062 100644
--- a/src/controllers/livetvstatus.html
+++ b/src/controllers/livetvstatus.html
@@ -1,4 +1,4 @@
-<div id="liveTvStatusPage" data-role="page" class="page type-interior liveTvSettingsPage">
+<div id="liveTvStatusPage" data-role="page" class="page type-interior liveTvSettingsPage" data-title="${LiveTV}">
     <div>
         <div class="content-primary">
             <div class="verticalSection verticalSection-extrabottompadding">