From c0b86a39c75dbd3b83f61a0bdae59237caacda92 Mon Sep 17 00:00:00 2001 From: gnattu Date: Mon, 20 May 2024 22:37:19 +0800 Subject: [PATCH] Only connect to manuall addresses specified by user This should never be enabled on the web because users are not expected to connect to an address they don't specify. For specific use cases like auto endpoint switching between networks, this should be managed by DNS or the router itself, not by the application. Having an address that is not always connectable causes our Android users to be unable to reliably connect to the server. It also breaks many reverse-proxy setups, as this address exposed by the server usually bypasses the proxy unless explicitly configured by the user. This has far more negative impact than the benifit it brings. --- src/components/ServerConnections.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ServerConnections.js b/src/components/ServerConnections.js index e67f0e0b5c..93aff18584 100644 --- a/src/components/ServerConnections.js +++ b/src/components/ServerConnections.js @@ -65,7 +65,7 @@ class ServerConnections extends ConnectionManager { ); apiClient.enableAutomaticNetworking = false; - apiClient.manualAddressOnly = false; + apiClient.manualAddressOnly = true; this.addApiClient(apiClient);