From 5db134a85975504ad4c555db1166a78596523017 Mon Sep 17 00:00:00 2001 From: Marks Date: Thu, 8 Dec 2022 20:10:14 -0800 Subject: [PATCH 1/3] Show production studio --- src/controllers/itemDetails/index.html | 5 +++++ src/controllers/itemDetails/index.js | 28 ++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/src/controllers/itemDetails/index.html b/src/controllers/itemDetails/index.html index accc5b705d..483b38e5c4 100644 --- a/src/controllers/itemDetails/index.html +++ b/src/controllers/itemDetails/index.html @@ -143,6 +143,11 @@
+ +
+
+
+
diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index a1bcebd3aa..e4bd85c1bc 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -1031,6 +1031,33 @@ function renderDirector(page, item, context) { } } +function renderStudio(page, item, context) { + const studios = item.Studios || []; + + const html = studios.map(function (studio) { + return '' + escapeHtml(studio.Name) + ''; + }).join(', '); + + const studiosLabel = page.querySelector('.studiosLabel'); + studiosLabel.innerHTML = globalize.translate(studios.length > 1 ? 'Studios' : 'Studio'); + const studiosValue = page.querySelector('.studios'); + studiosValue.innerHTML = html; + + const studiosGroup = page.querySelector('.studiosGroup'); + if (studios.length) { + studiosGroup.classList.remove('hide'); + } else { + studiosGroup.classList.add('hide'); + } +} + function renderMiscInfo(page, item) { const primaryItemMiscInfo = page.querySelectorAll('.itemMiscInfo-primary'); @@ -1079,6 +1106,7 @@ function renderDetails(page, item, apiClient, context, isStatic) { renderMoreFromSeason(page, item, apiClient); renderMoreFromArtist(page, item, apiClient); renderDirector(page, item, context); + renderStudio(page, item, context); renderWriter(page, item, context); renderGenres(page, item, context); renderChannelGuide(page, apiClient, item); From 6ffa0782aca0f857fb3ea59d07e1e8429d6db792 Mon Sep 17 00:00:00 2001 From: mark5231 <91494227+mark5231@users.noreply.github.com> Date: Thu, 5 Jan 2023 09:28:57 -0800 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Bill Thornton --- src/controllers/itemDetails/index.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index e4bd85c1bc..ae946816de 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -1051,11 +1051,7 @@ function renderStudio(page, item, context) { studiosValue.innerHTML = html; const studiosGroup = page.querySelector('.studiosGroup'); - if (studios.length) { - studiosGroup.classList.remove('hide'); - } else { - studiosGroup.classList.add('hide'); - } + studiosGroup.classList.toggle('hide', !studios.length); } function renderMiscInfo(page, item) { From 142c52a02c594f9708bb37d2c7322bad153b0c64 Mon Sep 17 00:00:00 2001 From: mark5231 <91494227+mark5231@users.noreply.github.com> Date: Tue, 7 Feb 2023 09:16:57 -0800 Subject: [PATCH 3/3] Update src/controllers/itemDetails/index.js Co-authored-by: Bill Thornton --- src/controllers/itemDetails/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index ae946816de..71bc68b880 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -1046,7 +1046,7 @@ function renderStudio(page, item, context) { }).join(', '); const studiosLabel = page.querySelector('.studiosLabel'); - studiosLabel.innerHTML = globalize.translate(studios.length > 1 ? 'Studios' : 'Studio'); + studiosLabel.innerText = globalize.translate(studios.length > 1 ? 'Studios' : 'Studio'); const studiosValue = page.querySelector('.studios'); studiosValue.innerHTML = html;