From 55a2ca3590e051e577b3da17068c81bfc8112557 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Wed, 20 Sep 2023 12:38:43 -0400 Subject: [PATCH] Fix error on unmount in syncplay menu --- .../components/AppToolbar/menus/SyncPlayMenu.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx b/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx index cb377784e8..1163a92527 100644 --- a/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx +++ b/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx @@ -56,9 +56,12 @@ const SyncPlayMenu: FC = ({ }, []); useEffect(() => { + let isMounted = true; + const fetchGroups = async () => { if (api) { - setGroups((await getSyncPlayApi(api).syncPlayGetGroups()).data); + const response = await getSyncPlayApi(api).syncPlayGetGroups(); + if (isMounted) setGroups(response.data); } }; @@ -66,6 +69,10 @@ const SyncPlayMenu: FC = ({ .catch(err => { console.error('[SyncPlayMenu] unable to fetch SyncPlay groups', err); }); + + return () => { + isMounted = false; + }; }, [ api ]); const onGroupAddClick = useCallback(() => {