From 55d57eedccb13a9b474445f43211935eb18f7cfd Mon Sep 17 00:00:00 2001 From: Nick <20588554+nicknsy@users.noreply.github.com> Date: Fri, 22 Mar 2024 18:19:30 -0700 Subject: [PATCH] Code review suggestions --- src/apps/dashboard/routes/playback/trickplay.tsx | 2 +- .../playback/trickplay/LinkTrickplayAcceleration.tsx | 6 +++--- src/controllers/playback/video/index.js | 4 +--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/apps/dashboard/routes/playback/trickplay.tsx b/src/apps/dashboard/routes/playback/trickplay.tsx index dfdecd5084..b09c2746a3 100644 --- a/src/apps/dashboard/routes/playback/trickplay.tsx +++ b/src/apps/dashboard/routes/playback/trickplay.tsx @@ -1,5 +1,5 @@ import type { ProcessPriorityClass, ServerConfiguration, TrickplayScanBehavior } from '@jellyfin/sdk/lib/generated-client'; -import React, { FunctionComponent, useCallback, useEffect, useRef } from 'react'; +import React, { type FunctionComponent, useCallback, useEffect, useRef } from 'react'; import globalize from '../../../../scripts/globalize'; import Page from '../../../../components/Page'; diff --git a/src/components/dashboard/playback/trickplay/LinkTrickplayAcceleration.tsx b/src/components/dashboard/playback/trickplay/LinkTrickplayAcceleration.tsx index dc720b7b69..a00b839c87 100644 --- a/src/components/dashboard/playback/trickplay/LinkTrickplayAcceleration.tsx +++ b/src/components/dashboard/playback/trickplay/LinkTrickplayAcceleration.tsx @@ -1,4 +1,4 @@ -import React, { FunctionComponent } from 'react'; +import React, { type FunctionComponent } from 'react'; import globalize from '../../../../scripts/globalize'; type IProps = { @@ -22,9 +22,9 @@ const LinkTrickplayAcceleration: FunctionComponent = ({ className, title return (
); diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index 7345313f8d..3cd98c77e9 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -1779,9 +1779,7 @@ export default function (view) { showOsd(); const item = currentItem; - let ticks = currentRuntimeTicks; - ticks /= 100; - ticks *= value; + const ticks = currentRuntimeTicks * value / 100; if (trickplayResolution && item?.Trickplay) { return updateTrickplayBubbleHtml(