From 872d71df3dbeb74664793fcd81cf97ffb077f257 Mon Sep 17 00:00:00 2001 From: LJQ Date: Thu, 29 Aug 2024 15:14:57 +0800 Subject: [PATCH 1/5] Allow editing of original title for Season and Episode items --- src/components/metadataEditor/metadataEditor.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index b40a858b6b..42da2b67bf 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -540,8 +540,7 @@ function setFieldVisibilities(context, item) { } else { hideElement('#fldPath', context); } - - if (item.Type === 'Series' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { + if (item.Type === 'Series' || item.Type === 'Season' || item.Type === 'Episode' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { showElement('#fldOriginalName', context); } else { hideElement('#fldOriginalName', context); From 8d8362158cf1c53e168c08ae566897a1cac7b268 Mon Sep 17 00:00:00 2001 From: LJQ Date: Thu, 29 Aug 2024 15:15:44 +0800 Subject: [PATCH 2/5] restore newline --- src/components/metadataEditor/metadataEditor.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index 42da2b67bf..d06a4912e2 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -540,6 +540,7 @@ function setFieldVisibilities(context, item) { } else { hideElement('#fldPath', context); } + if (item.Type === 'Series' || item.Type === 'Season' || item.Type === 'Episode' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { showElement('#fldOriginalName', context); } else { From e34c10644e21d3cb3b5410b63959984cfb1d4292 Mon Sep 17 00:00:00 2001 From: LJQ Date: Thu, 29 Aug 2024 15:19:48 +0800 Subject: [PATCH 3/5] Rm Trailing spaces --- src/components/metadataEditor/metadataEditor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index d06a4912e2..d9b3aa70c4 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -540,7 +540,7 @@ function setFieldVisibilities(context, item) { } else { hideElement('#fldPath', context); } - + if (item.Type === 'Series' || item.Type === 'Season' || item.Type === 'Episode' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { showElement('#fldOriginalName', context); } else { From c02b1e651f0a9aa5f14419f2c752ec5fcf606174 Mon Sep 17 00:00:00 2001 From: LJQ Date: Thu, 5 Sep 2024 01:06:26 +0800 Subject: [PATCH 4/5] Apply suggestion --- src/components/metadataEditor/metadataEditor.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index d9b3aa70c4..1edd4148eb 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -21,7 +21,7 @@ import ServerConnections from '../ServerConnections'; import toast from '../toast/toast'; import { appRouter } from '../router/appRouter'; import template from './metadataEditor.template.html'; -import { SeriesStatus } from '@jellyfin/sdk/lib/generated-client'; +import { BaseItemKind, SeriesStatus } from '@jellyfin/sdk/lib/generated-client'; let currentContext; let metadataEditorInfo; @@ -541,7 +541,7 @@ function setFieldVisibilities(context, item) { hideElement('#fldPath', context); } - if (item.Type === 'Series' || item.Type === 'Season' || item.Type === 'Episode' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { + if ([BaseItemKind.Series, BaseItemKind.Season, BaseItemKind.Episode, BaseItemKind.Movie, BaseItemKind.Trailer, BaseItemKind.Person].includes(item.Type)) { showElement('#fldOriginalName', context); } else { hideElement('#fldOriginalName', context); From f624fa106543048a7a0998d2343727f9335a320d Mon Sep 17 00:00:00 2001 From: LJQ Date: Sat, 21 Sep 2024 02:00:16 +0800 Subject: [PATCH 5/5] Use full path for imports --- src/components/metadataEditor/metadataEditor.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index 1edd4148eb..3253cc6873 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -21,7 +21,8 @@ import ServerConnections from '../ServerConnections'; import toast from '../toast/toast'; import { appRouter } from '../router/appRouter'; import template from './metadataEditor.template.html'; -import { BaseItemKind, SeriesStatus } from '@jellyfin/sdk/lib/generated-client'; +import { BaseItemKind } from '@jellyfin/sdk/lib/generated-client/models/base-item-kind'; +import { SeriesStatus } from '@jellyfin/sdk/lib/generated-client/models/series-status'; let currentContext; let metadataEditorInfo;