mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Modernized some loops and converted more string additions to template strings

Browse source
This commit is contained in:
Cromefire_ 2020-05-08 11:48:34 +02:00
parent 6be76e5c31
commit 587b537cd6
No known key found for this signature in database
GPG key ID: D3D3DB179F435F0C
1 changed files with 19 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

46
src/components/filterdialog/filterdialog.js
View file

@ -19,10 +19,10 @@ import 'css!./style.css';
html += '<div class="checkboxList">'; html += '<div class="checkboxList">';
html += items.map(function (filter) { html += items.map(function (filter) {
let itemHtml = ''; let itemHtml = '';
const checkedHtml = isCheckedFn(filter) ? ' checked' : ''; const checkedHtml = isCheckedFn(filter) ? 'checked' : '';
itemHtml += '<label>'; itemHtml += '<label>';
itemHtml += '<input is="emby-checkbox" type="checkbox"' + checkedHtml + ' data-filter="' + filter + '" class="' + cssClass + '"/>'; itemHtml += `<input is="emby-checkbox" type="checkbox" ${checkedHtml} data-filter="${filter}" class="${cssClass}"/>`;
itemHtml += '<span>' + filter + '</span>'; itemHtml += `<span>${filter}</span>`;
itemHtml += '</label>'; itemHtml += '</label>';
return itemHtml; return itemHtml;
}).join(''); }).join('');
@ -75,16 +75,16 @@ import 'css!./style.css';
context.querySelector('.chkDislikes').checked = query.IsDisliked === true; context.querySelector('.chkDislikes').checked = query.IsDisliked === true;
} else { } else {
for (const elem of context.querySelectorAll('.chkStandardFilter')) { for (const elem of context.querySelectorAll('.chkStandardFilter')) {
const filters = ',' + (query.Filters || ''); const filters = `,${query.Filters || ''}`;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
elem.checked = filters.includes(',' + filterName); elem.checked = filters.includes(`,${filterName}`);
} }
} }
for (const elem of context.querySelectorAll('.chkVideoTypeFilter')) { for (const elem of context.querySelectorAll('.chkVideoTypeFilter')) {
const filters = ',' + (query.VideoTypes || ''); const filters = `,${query.VideoTypes || ''}`;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
elem.checked = filters.includes(',' + filterName); elem.checked = filters.includes(`,${filterName}`);
} }
context.querySelector('.chk3DFilter').checked = query.Is3D === true; context.querySelector('.chk3DFilter').checked = query.Is3D === true;
context.querySelector('.chkHDFilter').checked = query.IsHD === true; context.querySelector('.chkHDFilter').checked = query.IsHD === true;
@ -99,9 +99,9 @@ import 'css!./style.css';
context.querySelector('#chkMissingEpisode').checked = query.IsMissing === true; context.querySelector('#chkMissingEpisode').checked = query.IsMissing === true;
context.querySelector('#chkFutureEpisode').checked = query.IsUnaired === true; context.querySelector('#chkFutureEpisode').checked = query.IsUnaired === true;
for (const elem of context.querySelectorAll('.chkStatus')) { for (const elem of context.querySelectorAll('.chkStatus')) {
const filters = ',' + (query.SeriesStatus || ''); const filters = `,${query.SeriesStatus || ''}`;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
elem.checked = filters.includes(',' + filterName); elem.checked = filters.includes(`,${filterName}`);
} }
} }
@ -142,22 +142,14 @@ import 'css!./style.css';
} }
function showByClass(context, className) { function showByClass(context, className) {
const elems = context.querySelectorAll('.' + className); for (const elem of context.querySelectorAll(`.${className}`)) {
elem.classList.remove('hide');
let i = 0;
const length = elems.length;
for (; i < length; i++) {
elems[i].classList.remove('hide');
} }
} }
function hideByClass(context, className) { function hideByClass(context, className) {
const elems = context.querySelectorAll('.' + className); for (const elem of context.querySelectorAll(`.${className}`)) {
elem.classList.add('hide');
let i = 0;
const length = elems.length;
for (; i < length; i++) {
elems[i].classList.add('hide');
} }
} }
@ -190,10 +182,10 @@ import 'css!./style.css';
const query = this.options.query; const query = this.options.query;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
let filters = query.Filters || ''; let filters = query.Filters || '';
filters = (',' + filters).replace(',' + filterName, '').substring(1); filters = (`,${filters}`).replace(`,${filterName}`, '').substring(1);
if (elem.checked) { if (elem.checked) {
filters = filters ? filters + ',' + filterName : filterName; filters = filters ? `${filters},${filterName}` : filterName;
} }
query.StartIndex = 0; query.StartIndex = 0;
@ -208,10 +200,10 @@ import 'css!./style.css';
const query = this.options.query; const query = this.options.query;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
let filters = query.VideoTypes || ''; let filters = query.VideoTypes || '';
filters = (',' + filters).replace(',' + filterName, '').substring(1); filters = (`,${filters}`).replace(`,${filterName}`, '').substring(1);
if (elem.checked) { if (elem.checked) {
filters = filters ? filters + ',' + filterName : filterName; filters = filters ? `${filters},${filterName}` : filterName;
} }
query.StartIndex = 0; query.StartIndex = 0;
@ -226,10 +218,10 @@ import 'css!./style.css';
const query = this.options.query; const query = this.options.query;
const filterName = elem.getAttribute('data-filter'); const filterName = elem.getAttribute('data-filter');
let filters = query.SeriesStatus || ''; let filters = query.SeriesStatus || '';
filters = (',' + filters).replace(',' + filterName, '').substring(1); filters = (`,${filters}`).replace(`,${filterName}`, '').substring(1);
if (elem.checked) { if (elem.checked) {
filters = filters ? filters + ',' + filterName : filterName; filters = filters ? `${filters},${filterName}` : filterName;
} }
query.SeriesStatus = filters; query.SeriesStatus = filters;