From 58d9037986cb07df54408b60f9927551fa4eca44 Mon Sep 17 00:00:00 2001 From: MrTimscampi Date: Sun, 12 Apr 2020 14:29:42 +0200 Subject: [PATCH] Remove useless parameter in lazyImage --- src/components/images/imageLoader.js | 9 ++------- src/controllers/itemdetailpage.js | 10 +++++----- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/src/components/images/imageLoader.js b/src/components/images/imageLoader.js index 80bb24bcfe..2166d6ccff 100644 --- a/src/components/images/imageLoader.js +++ b/src/components/images/imageLoader.js @@ -3,21 +3,16 @@ import userSettings from 'userSettings'; import 'css!./style'; /* eslint-disable indent */ - export function lazyImage(elem, source, enableEffects) { - + export function lazyImage(elem, source = elem.getAttribute('data-src')) { if (!elem) { throw new Error('elem cannot be null'); } - if (!source) { - source = elem.getAttribute('data-src'); - } - if (!source) { return; } - fillImageElement(elem, source, enableEffects); + fillImageElement(elem, source); } export function fillImage(entry) { diff --git a/src/controllers/itemdetailpage.js b/src/controllers/itemdetailpage.js index 178419e284..81314ce7c1 100644 --- a/src/controllers/itemdetailpage.js +++ b/src/controllers/itemdetailpage.js @@ -473,7 +473,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "userSetti tag: item.ImageTags.Thumb }); page.classList.remove("noBackdrop"); - imageLoader.lazyImage(itemBackdropElement, imgUrl, false); + imageLoader.lazyImage(itemBackdropElement, imgUrl); hasbackdrop = true; } else if (usePrimaryImage && item.ImageTags && item.ImageTags.Primary) { imgUrl = apiClient.getScaledImageUrl(item.Id, { @@ -483,7 +483,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "userSetti tag: item.ImageTags.Primary }); page.classList.remove("noBackdrop"); - imageLoader.lazyImage(itemBackdropElement, imgUrl, false); + imageLoader.lazyImage(itemBackdropElement, imgUrl); hasbackdrop = true; } else if (item.BackdropImageTags && item.BackdropImageTags.length) { imgUrl = apiClient.getScaledImageUrl(item.Id, { @@ -493,7 +493,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "userSetti tag: item.BackdropImageTags[0] }); page.classList.remove("noBackdrop"); - imageLoader.lazyImage(itemBackdropElement, imgUrl, false); + imageLoader.lazyImage(itemBackdropElement, imgUrl); hasbackdrop = true; } else if (item.ParentBackdropItemId && item.ParentBackdropImageTags && item.ParentBackdropImageTags.length) { imgUrl = apiClient.getScaledImageUrl(item.ParentBackdropItemId, { @@ -503,7 +503,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "userSetti tag: item.ParentBackdropImageTags[0] }); page.classList.remove("noBackdrop"); - imageLoader.lazyImage(itemBackdropElement, imgUrl, false); + imageLoader.lazyImage(itemBackdropElement, imgUrl); hasbackdrop = true; } else if (item.ImageTags && item.ImageTags.Thumb) { imgUrl = apiClient.getScaledImageUrl(item.Id, { @@ -513,7 +513,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "userSetti tag: item.ImageTags.Thumb }); page.classList.remove("noBackdrop"); - imageLoader.lazyImage(itemBackdropElement, imgUrl, false); + imageLoader.lazyImage(itemBackdropElement, imgUrl); hasbackdrop = true; } else { itemBackdropElement.style.backgroundImage = "";