From 5c51b4b985def2a19d6e7cfb26d2d626c0983bd1 Mon Sep 17 00:00:00 2001 From: SenorSmartyPants Date: Tue, 7 Feb 2023 13:12:19 -0600 Subject: [PATCH] Code review changes implemented --- src/components/indicators/indicators.scss | 10 ---------- src/components/listview/listview.scss | 10 ++++++++++ src/controllers/itemDetails/index.js | 6 +++--- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/components/indicators/indicators.scss b/src/components/indicators/indicators.scss index ec875b53dc..3130150d31 100644 --- a/src/components/indicators/indicators.scss +++ b/src/components/indicators/indicators.scss @@ -38,16 +38,6 @@ color: #888; } -.listItemMediaInfo + .timerIndicator { - [dir="ltr"] & { - margin-left: 0.25em; - } - - [dir="rtl"] & { - margin-right: 0.25em; - } -} - .indicator + .indicator { [dir="ltr"] & { margin-left: 0.25em; diff --git a/src/components/listview/listview.scss b/src/components/listview/listview.scss index fb6d3a565f..2aafd936a2 100644 --- a/src/components/listview/listview.scss +++ b/src/components/listview/listview.scss @@ -320,3 +320,13 @@ .listItemCheckboxContainer { width: auto !important; } + +.listItemMediaInfo + .timerIndicator { + [dir="ltr"] & { + margin-left: 0.25em; + } + + [dir="rtl"] & { + margin-right: 0.25em; + } +} diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index e45a66060c..bb3586ed1e 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -96,7 +96,7 @@ function getContextMenuOptions(item, user, button) { }; } -function getProgramScheduleHtml(items, action) { +function getProgramScheduleHtml(items, action = 'none') { return listView.getListViewHtml({ items: items, enableUserDataButtons: false, @@ -106,7 +106,7 @@ function getProgramScheduleHtml(items, action) { showChannel: false, mediaInfo: true, runtime: false, - action: action, + action, moreButton: false, recordButton: false }); @@ -126,7 +126,7 @@ function renderSeriesTimerSchedule(page, apiClient, seriesTimerId) { result.Items = []; } - const html = getProgramScheduleHtml(result.Items, 'none'); + const html = getProgramScheduleHtml(result.Items); const scheduleTab = page.querySelector('#seriesTimerSchedule'); scheduleTab.innerHTML = html; imageLoader.lazyChildren(scheduleTab);