From d5d25619794b264e3c5a372b4c2b6e7e6ba36019 Mon Sep 17 00:00:00 2001 From: Guillermo Fernandez Date: Mon, 2 Oct 2023 20:17:23 +0200 Subject: [PATCH 1/2] Clean backdrops when tab is not selected --- src/components/backdrop/backdrop.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/components/backdrop/backdrop.js b/src/components/backdrop/backdrop.js index 46655777ff..9e97843294 100644 --- a/src/components/backdrop/backdrop.js +++ b/src/components/backdrop/backdrop.js @@ -37,8 +37,11 @@ class Backdrop { parent.appendChild(backdropImage); if (!enableAnimation()) { - if (existingBackdropImage?.parentNode) { - existingBackdropImage.parentNode.removeChild(existingBackdropImage); + if (existingBackdropImage) { + const backdropContainer = getBackdropContainer(); + while (backdropContainer.childNodes.length > 1) { + backdropContainer.removeChild(backdropContainer.firstChild); + } } internalBackdrop(true); return; @@ -51,8 +54,11 @@ class Backdrop { if (backdropImage === self.currentAnimatingElement) { self.currentAnimatingElement = null; } - if (existingBackdropImage?.parentNode) { - existingBackdropImage.parentNode.removeChild(existingBackdropImage); + if (existingBackdropImage) { + const backdropContainer = getBackdropContainer(); + while (backdropContainer.childNodes.length > 1) { + backdropContainer.removeChild(backdropContainer.firstChild); + } } }; From cd7e23ed593224666b49b2010fb1132773a7af5c Mon Sep 17 00:00:00 2001 From: Guillermo Fernandez Date: Mon, 2 Oct 2023 20:17:23 +0200 Subject: [PATCH 2/2] Clean backdrops when tab is not selected --- src/components/backdrop/backdrop.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/components/backdrop/backdrop.js b/src/components/backdrop/backdrop.js index 46655777ff..9e97843294 100644 --- a/src/components/backdrop/backdrop.js +++ b/src/components/backdrop/backdrop.js @@ -37,8 +37,11 @@ class Backdrop { parent.appendChild(backdropImage); if (!enableAnimation()) { - if (existingBackdropImage?.parentNode) { - existingBackdropImage.parentNode.removeChild(existingBackdropImage); + if (existingBackdropImage) { + const backdropContainer = getBackdropContainer(); + while (backdropContainer.childNodes.length > 1) { + backdropContainer.removeChild(backdropContainer.firstChild); + } } internalBackdrop(true); return; @@ -51,8 +54,11 @@ class Backdrop { if (backdropImage === self.currentAnimatingElement) { self.currentAnimatingElement = null; } - if (existingBackdropImage?.parentNode) { - existingBackdropImage.parentNode.removeChild(existingBackdropImage); + if (existingBackdropImage) { + const backdropContainer = getBackdropContainer(); + while (backdropContainer.childNodes.length > 1) { + backdropContainer.removeChild(backdropContainer.firstChild); + } } };