diff --git a/.eslintrc.js b/.eslintrc.js index 042c347feb..73a86537bf 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -64,6 +64,7 @@ module.exports = { 'no-throw-literal': ['error'], 'no-trailing-spaces': ['error'], 'no-undef-init': ['error'], + 'no-unneeded-ternary': ['error'], 'no-unused-expressions': ['off'], '@typescript-eslint/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }], 'no-unused-private-class-members': ['error'], diff --git a/src/apps/experimental/components/library/GenresSectionContainer.tsx b/src/apps/experimental/components/library/GenresSectionContainer.tsx index ebfd20d33d..14b061850d 100644 --- a/src/apps/experimental/components/library/GenresSectionContainer.tsx +++ b/src/apps/experimental/components/library/GenresSectionContainer.tsx @@ -71,8 +71,8 @@ const GenresSectionContainer: FC = ({ centerText: true, cardLayout: false, shape: itemType === BaseItemKind.MusicAlbum ? 'overflowSquare' : 'overflowPortrait', - showParentTitle: itemType === BaseItemKind.MusicAlbum ? true : false, - showYear: itemType === BaseItemKind.MusicAlbum ? false : true + showParentTitle: itemType === BaseItemKind.MusicAlbum, + showYear: itemType !== BaseItemKind.MusicAlbum }} />; }; diff --git a/src/components/guide/guide.js b/src/components/guide/guide.js index 76c54693f9..97c8bff2c1 100644 --- a/src/components/guide/guide.js +++ b/src/components/guide/guide.js @@ -291,7 +291,7 @@ function Guide(options) { showPremiereIndicator: allowIndicators && userSettings.get('guide-indicator-premiere') !== 'false', showNewIndicator: allowIndicators && userSettings.get('guide-indicator-new') !== 'false', showRepeatIndicator: allowIndicators && userSettings.get('guide-indicator-repeat') === 'true', - showEpisodeTitle: layoutManager.tv ? false : true + showEpisodeTitle: !layoutManager.tv }; apiClient.getLiveTvChannels(channelQuery).then(function (channelsResult) { diff --git a/src/components/listview/listview.js b/src/components/listview/listview.js index 1a230c31ed..4c05be198e 100644 --- a/src/components/listview/listview.js +++ b/src/components/listview/listview.js @@ -177,7 +177,7 @@ export function getListViewHtml(options) { const isLargeStyle = options.imageSize === 'large'; const enableOverview = options.enableOverview; - const clickEntireItem = layoutManager.tv ? true : false; + const clickEntireItem = layoutManager.tv; const outerTagName = clickEntireItem ? 'button' : 'div'; const enableSideMediaInfo = options.enableSideMediaInfo != null ? options.enableSideMediaInfo : true; diff --git a/src/components/playback/playersettingsmenu.js b/src/components/playback/playersettingsmenu.js index e0acde509b..9f9f54d56b 100644 --- a/src/components/playback/playersettingsmenu.js +++ b/src/components/playback/playersettingsmenu.js @@ -46,7 +46,7 @@ function showQualityMenu(player, btn) { const bitrate = parseInt(id, 10); if (bitrate !== selectedBitrate) { playbackManager.setMaxStreamingBitrate({ - enableAutomaticBitrateDetection: bitrate ? false : true, + enableAutomaticBitrateDetection: !bitrate, maxBitrate: bitrate }, player); } diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index 4efe69e781..123b3c3092 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -1374,8 +1374,8 @@ function renderChildren(page, item) { items: result.Items, showIndexNumber: false, enableOverview: true, - enablePlayedButton: layoutManager.mobile ? false : true, - infoButton: layoutManager.mobile ? false : true, + enablePlayedButton: !layoutManager.mobile, + infoButton: !layoutManager.mobile, imageSize: 'large', enableSideMediaInfo: false, highlight: false, diff --git a/src/elements/emby-checkbox/emby-checkbox.js b/src/elements/emby-checkbox/emby-checkbox.js index 2be4237d21..6fed51fe2e 100644 --- a/src/elements/emby-checkbox/emby-checkbox.js +++ b/src/elements/emby-checkbox/emby-checkbox.js @@ -21,7 +21,7 @@ function onKeyDown(e) { } } -const enableRefreshHack = browser.tizen || browser.orsay || browser.operaTv || browser.web0s ? true : false; +const enableRefreshHack = browser.tizen || browser.orsay || browser.operaTv || browser.web0s; function forceRefresh(loading) { const elem = this.parentNode; diff --git a/src/elements/emby-scrollbuttons/ScrollButtons.tsx b/src/elements/emby-scrollbuttons/ScrollButtons.tsx index aaeb9bc23e..87aa27d783 100644 --- a/src/elements/emby-scrollbuttons/ScrollButtons.tsx +++ b/src/elements/emby-scrollbuttons/ScrollButtons.tsx @@ -67,7 +67,7 @@ const ScrollButtons: FC = ({ scrollerFactoryRef, scrollState className='emby-scrollbuttons-button btnPrev' onClick={triggerScrollLeft} icon='chevron_left' - disabled={localeScrollPos > 0 ? false : true} + disabled={localeScrollPos <= 0} /> = ({ scrollerFactoryRef, scrollState className='emby-scrollbuttons-button btnNext' onClick={triggerScrollRight} icon='chevron_right' - disabled={scrollState.scrollWidth > 0 && localeScrollPos + scrollState.scrollSize >= scrollState.scrollWidth ? true : false} + disabled={scrollState.scrollWidth > 0 && localeScrollPos + scrollState.scrollSize >= scrollState.scrollWidth} /> ); diff --git a/src/scripts/browserDeviceProfile.js b/src/scripts/browserDeviceProfile.js index f6289522f3..afa8c8df76 100644 --- a/src/scripts/browserDeviceProfile.js +++ b/src/scripts/browserDeviceProfile.js @@ -692,7 +692,7 @@ export default function (options) { profile.TranscodingProfiles = []; - const hlsBreakOnNonKeyFrames = browser.iOS || browser.osx || browser.edge || !canPlayNativeHls() ? true : false; + const hlsBreakOnNonKeyFrames = browser.iOS || browser.osx || browser.edge || !canPlayNativeHls(); if (canPlayHls() && browser.enableHlsAudio !== false) { profile.TranscodingProfiles.push({