mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Fix review feedback

Browse source
This commit is contained in:
Bill Thornton 2024-04-19 08:15:45 -04:00
parent 0163da2df8
commit 633ae83611
1 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/components/playlisteditor/playlisteditor.ts
View file

@ -6,7 +6,7 @@ import escapeHtml from 'escape-html';
import dom from 'scripts/dom'; import dom from 'scripts/dom';
import globalize from 'scripts/globalize'; import globalize from 'scripts/globalize';
import * as userSettings from 'scripts/settings/userSettings'; import { currentSettings as userSettings } from 'scripts/settings/userSettings';
import { PluginType } from 'types/plugin'; import { PluginType } from 'types/plugin';
import { toApi } from 'utils/jellyfin-apiclient/compat'; import { toApi } from 'utils/jellyfin-apiclient/compat';
@ -45,17 +45,21 @@ function onSubmit(this: HTMLElement, e: Event) {
if (panel) { if (panel) {
const playlistId = panel.querySelector<HTMLSelectElement>('#selectPlaylistToAddTo')?.value; const playlistId = panel.querySelector<HTMLSelectElement>('#selectPlaylistToAddTo')?.value;
loading.show();
if (playlistId) { if (playlistId) {
userSettings.set('playlisteditor-lastplaylistid', playlistId); userSettings.set('playlisteditor-lastplaylistid', playlistId);
addToPlaylist(panel, playlistId) addToPlaylist(panel, playlistId)
?.catch(err => { ?.catch(err => {
console.error('[PlaylistEditor] Failed to add to playlist %s', playlistId, err); console.error('[PlaylistEditor] Failed to add to playlist %s', playlistId, err);
}); })
.finally(loading.hide);
} else { } else {
createPlaylist(panel) createPlaylist(panel)
?.catch(err => { ?.catch(err => {
console.error('[PlaylistEditor] Failed to create playlist', err); console.error('[PlaylistEditor] Failed to create playlist', err);
}); })
.finally(loading.hide);
} }
} else { } else {
console.error('[PlaylistEditor] Dialog element is missing!'); console.error('[PlaylistEditor] Dialog element is missing!');
@ -71,8 +75,6 @@ function createPlaylist(dlg: DialogElement) {
const itemIds = dlg.querySelector<HTMLInputElement>('.fldSelectedItemIds')?.value || ''; const itemIds = dlg.querySelector<HTMLInputElement>('.fldSelectedItemIds')?.value || '';
loading.show();
return getPlaylistsApi(api) return getPlaylistsApi(api)
.createPlaylist({ .createPlaylist({
name: dlg.querySelector<HTMLInputElement>('#txtNewPlaylistName')?.value, name: dlg.querySelector<HTMLInputElement>('#txtNewPlaylistName')?.value,
@ -80,7 +82,6 @@ function createPlaylist(dlg: DialogElement) {
userId: apiClient.getCurrentUserId() userId: apiClient.getCurrentUserId()
}) })
.then(result => { .then(result => {
loading.hide();
dlg.submitted = true; dlg.submitted = true;
dialogHelper.close(dlg); dialogHelper.close(dlg);
@ -107,8 +108,6 @@ function addToPlaylist(dlg: DialogElement, id: string) {
return; return;
} }
loading.show();
return getPlaylistsApi(api) return getPlaylistsApi(api)
.addItemToPlaylist({ .addItemToPlaylist({
playlistId: id, playlistId: id,
@ -116,8 +115,6 @@ function addToPlaylist(dlg: DialogElement, id: string) {
userId: apiClient.getCurrentUserId() userId: apiClient.getCurrentUserId()
}) })
.then(() => { .then(() => {
loading.hide();
dlg.submitted = true; dlg.submitted = true;
dialogHelper.close(dlg); dialogHelper.close(dlg);
}); });
@ -317,7 +314,7 @@ export class PlaylistEditor {
return Promise.resolve(); return Promise.resolve();
} }
return Promise.reject(); return Promise.reject(new Error());
}); });
} }
} }