mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

fix code smells

Browse source
This commit is contained in:
redSpoutnik 2020-05-16 15:16:18 +02:00
parent 6bb1cf3554
commit 64da797e78
3 changed files with 11 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/subtitleeditor/subtitleeditor.js
View file

@ -349,8 +349,8 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
function onOpenUploadMenu(e) { function onOpenUploadMenu(e) {
var context = dom.parentWithClass(e.target, 'subtitleEditorDialog'); var dialog = dom.parentWithClass(e.target, 'subtitleEditorDialog');
var selectLanguage = context.querySelector('#selectLanguage'); var selectLanguage = dialog.querySelector('#selectLanguage');
var apiClient = connectionManager.getApiClient(currentItem.ServerId); var apiClient = connectionManager.getApiClient(currentItem.ServerId);
require(['subtitleUploader'], function (subtitleUploader) { require(['subtitleUploader'], function (subtitleUploader) {
@ -368,7 +368,7 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
if (hasChanged) { if (hasChanged) {
hasChanges = true; hasChanges = true;
reload(context, apiClient, currentItem.Id); reload(dialog, apiClient, currentItem.Id);
} }
}); });
}); });

21
src/components/subtitleuploader/subtitleuploader.js
View file

@ -10,19 +10,11 @@ define(['dialogHelper', 'connectionManager', 'dom', 'loading', 'scrollHelper', '
loading.hide(); loading.hide();
switch (evt.target.error.code) { var error = evt.target.error;
case evt.target.error.NOT_FOUND_ERR: if (error.code !== error.ABORT_ERR) {
require(['toast'], function (toast) { require(['toast'], function (toast) {
toast(globalize.translate('MessageFileReadError')); toast(globalize.translate('MessageFileReadError'));
}); });
break;
case evt.target.error.ABORT_ERR:
break; // noop
default:
require(['toast'], function (toast) {
toast(globalize.translate('MessageFileReadError'));
});
break;
} }
} }
@ -85,7 +77,7 @@ define(['dialogHelper', 'connectionManager', 'dom', 'loading', 'scrollHelper', '
toast(globalize.translate('MessageSubtitleFileTypeAllowed')); toast(globalize.translate('MessageSubtitleFileTypeAllowed'));
}); });
e.preventDefault(); e.preventDefault();
return false; return;
} }
loading.show(); loading.show();
@ -103,7 +95,6 @@ define(['dialogHelper', 'connectionManager', 'dom', 'loading', 'scrollHelper', '
}); });
e.preventDefault(); e.preventDefault();
return false;
} }
function initEditor(page) { function initEditor(page) {

4
src/components/subtitleuploader/subtitleuploader.template.html
View file

@ -1,5 +1,5 @@
<div class="formDialogHeader"> <div class="formDialogHeader">
<button is="paper-icon-button-light" class="btnCancel autoSize" tabindex="-1"><i class="material-icons arrow_back"></i></button> <button is="paper-icon-button-light" class="btnCancel autoSize" tabindex="-1"><em class="material-icons arrow_back"></em></button>
<h3 class="formDialogHeaderTitle"> <h3 class="formDialogHeaderTitle">
${HeaderUploadSubtitle} ${HeaderUploadSubtitle}
</h3> </h3>
@ -14,7 +14,7 @@
<h2 style="margin:0;">${HeaderAddUpdateSubtitle}</h2> <h2 style="margin:0;">${HeaderAddUpdateSubtitle}</h2>
<button is="emby-button" type="button" class="raised raised-mini btnBrowse" style="margin-left:1.5em;"> <button is="emby-button" type="button" class="raised raised-mini btnBrowse" style="margin-left:1.5em;">
<i class="material-icons">folder</i> <em class="material-icons">folder</em>
<span>${Browse}</span> <span>${Browse}</span>
</button> </button>
</div> </div>