From 4bbd706294875b2c173d011344c19a39dbc3f689 Mon Sep 17 00:00:00 2001 From: Brandon Nguyen Date: Sat, 3 Jul 2021 01:08:22 -0700 Subject: [PATCH 1/3] Add hardware encoding status to playback data --- src/components/playerstats/playerstats.js | 4 ++++ src/strings/en-us.json | 1 + 2 files changed, 5 insertions(+) diff --git a/src/components/playerstats/playerstats.js b/src/components/playerstats/playerstats.js index d93534db09..6ccc04dfd6 100644 --- a/src/components/playerstats/playerstats.js +++ b/src/components/playerstats/playerstats.js @@ -173,6 +173,10 @@ import ServerConnections from '../ServerConnections'; value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('
') }); } + sessionStats.push({ + label: globalize.translate('LabelHardwareEncoding'), + value: session.TranscodingInfo.IsHardwareEncode + }); } return sessionStats; diff --git a/src/strings/en-us.json b/src/strings/en-us.json index 9e4132e586..82f295d202 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -644,6 +644,7 @@ "LabelH265Crf": "H265 encoding CRF:", "LabelHardwareAccelerationType": "Hardware acceleration:", "LabelHardwareAccelerationTypeHelp": "Hardware acceleration requires additional configuration.", + "LabelHardwareEncoding": "Hardware encoding:", "LabelHDHomerunPortRange": "HD Homerun port range:", "LabelHDHomerunPortRangeHelp": "Restricts the HD Homerun UDP port range to this value. (Default is 1024 - 645535).", "LabelHomeNetworkQuality": "Home network quality:", From f2b4ae881bf0ad01037483e8779f24850cb482a5 Mon Sep 17 00:00:00 2001 From: Brandon Nguyen Date: Sat, 3 Jul 2021 15:26:53 -0700 Subject: [PATCH 2/3] Use hardware encoding string over boolean --- src/components/playerstats/playerstats.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/playerstats/playerstats.js b/src/components/playerstats/playerstats.js index 6ccc04dfd6..ca4ecad85c 100644 --- a/src/components/playerstats/playerstats.js +++ b/src/components/playerstats/playerstats.js @@ -175,7 +175,7 @@ import ServerConnections from '../ServerConnections'; } sessionStats.push({ label: globalize.translate('LabelHardwareEncoding'), - value: session.TranscodingInfo.IsHardwareEncode + value: session.TranscodingInfo.HardwareAccelerationType }); } From aa81f651b72d9d9d3099fccfb2f6cf30c6c3f6a6 Mon Sep 17 00:00:00 2001 From: Brandon Date: Sat, 21 Aug 2021 23:49:04 -0700 Subject: [PATCH 3/3] Wrap HardwareAccelerationType with if Co-authored-by: Claus Vium --- src/components/playerstats/playerstats.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/components/playerstats/playerstats.js b/src/components/playerstats/playerstats.js index ca4ecad85c..6e36c38315 100644 --- a/src/components/playerstats/playerstats.js +++ b/src/components/playerstats/playerstats.js @@ -173,10 +173,12 @@ import ServerConnections from '../ServerConnections'; value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('
') }); } - sessionStats.push({ - label: globalize.translate('LabelHardwareEncoding'), - value: session.TranscodingInfo.HardwareAccelerationType - }); + if (session.TranscodingInfo.HardwareAccelerationType) { + sessionStats.push({ + label: globalize.translate('LabelHardwareEncoding'), + value: session.TranscodingInfo.HardwareAccelerationType + }); + } } return sessionStats;