mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Fixed review comments

Browse source
This commit is contained in:
Cromefire_ 2020-05-26 23:59:58 +02:00
parent 587b537cd6
commit 6d14ad0a76
No known key found for this signature in database
GPG key ID: D3D3DB179F435F0C
3 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/components/fetchhelper.js
View file

@ -77,6 +77,7 @@
function paramsToString(params) { function paramsToString(params) {
return Object.keys(params) return Object.keys(params)
.filter((k) => !!params[k])
.map(k => `${encodeURIComponent(k)}=${encodeURIComponent(params[k])}`) .map(k => `${encodeURIComponent(k)}=${encodeURIComponent(params[k])}`)
.join('&'); .join('&');
} }
@ -95,7 +96,7 @@
if (response.status < 400) { if (response.status < 400) {
if (request.dataType === 'json' || request.headers.accept === 'application/json') { if (request.dataType === 'json' || request.headers.accept === 'application/json') {
return response.json(); return response.json();
} else if (request.dataType === 'text' || (response.headers.get('Content-Type') || '').toLowerCase().includes('text/')) { } else if (request.dataType === 'text' || (response.headers.get('Content-Type') || '').toLowerCase().startsWith('text/')) {
return response.text(); return response.text();
} else { } else {
return response; return response;

10
src/components/filterdialog/filterdialog.js
View file

@ -342,8 +342,8 @@ import 'css!./style.css';
query.HasSubtitles = chkSubtitle.checked ? true : null; query.HasSubtitles = chkSubtitle.checked ? true : null;
triggerChange(this); triggerChange(this);
}); });
context.addEventListener('change', () => { context.addEventListener('change', (e) => {
const chkGenreFilter = dom.parentWithClass(context, 'chkGenreFilter'); const chkGenreFilter = dom.parentWithClass(e.target, 'chkGenreFilter');
if (chkGenreFilter) { if (chkGenreFilter) {
const filterName = chkGenreFilter.getAttribute('data-filter'); const filterName = chkGenreFilter.getAttribute('data-filter');
let filters = query.Genres || ''; let filters = query.Genres || '';
@ -357,7 +357,7 @@ import 'css!./style.css';
triggerChange(this); triggerChange(this);
return; return;
} }
const chkTagFilter = dom.parentWithClass(context, 'chkTagFilter'); const chkTagFilter = dom.parentWithClass(e.target, 'chkTagFilter');
if (chkTagFilter) { if (chkTagFilter) {
const filterName = chkTagFilter.getAttribute('data-filter'); const filterName = chkTagFilter.getAttribute('data-filter');
let filters = query.Tags || ''; let filters = query.Tags || '';
@ -371,7 +371,7 @@ import 'css!./style.css';
triggerChange(this); triggerChange(this);
return; return;
} }
const chkYearFilter = dom.parentWithClass(context, 'chkYearFilter'); const chkYearFilter = dom.parentWithClass(e.target, 'chkYearFilter');
if (chkYearFilter) { if (chkYearFilter) {
const filterName = chkYearFilter.getAttribute('data-filter'); const filterName = chkYearFilter.getAttribute('data-filter');
let filters = query.Years || ''; let filters = query.Years || '';
@ -385,7 +385,7 @@ import 'css!./style.css';
triggerChange(this); triggerChange(this);
return; return;
} }
const chkOfficialRatingFilter = dom.parentWithClass(context, 'chkOfficialRatingFilter'); const chkOfficialRatingFilter = dom.parentWithClass(e.target, 'chkOfficialRatingFilter');
if (chkOfficialRatingFilter) { if (chkOfficialRatingFilter) {
const filterName = chkOfficialRatingFilter.getAttribute('data-filter'); const filterName = chkOfficialRatingFilter.getAttribute('data-filter');
let filters = query.OfficialRatings || ''; let filters = query.OfficialRatings || '';

2
src/plugins/backdropScreensaver/plugin.js
View file

@ -22,7 +22,7 @@ class BackdropScreensaver {
}; };
const apiClient = connectionManager.currentApiClient(); const apiClient = connectionManager.currentApiClient();
apiClient.getItems(apiClient.getCurrentUserId(), query).then(function (result) { apiClient.getItems(apiClient.getCurrentUserId(), query).then((result) => {
if (result.Items.length) { if (result.Items.length) {