From 37fd4feb5573acd06d97beca86748f897bd744a4 Mon Sep 17 00:00:00 2001 From: Yasin Silavi Date: Wed, 26 Jul 2023 10:54:23 +0330 Subject: [PATCH 1/5] Remove useless assignment --- src/scripts/datetime.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/scripts/datetime.js b/src/scripts/datetime.js index 3903b58638..f1243a5076 100644 --- a/src/scripts/datetime.js +++ b/src/scripts/datetime.js @@ -230,7 +230,6 @@ export function getDisplayTime(date) { const timeLower = time.toLowerCase(); if (timeLower.indexOf('am') !== -1 || timeLower.indexOf('pm') !== -1) { - time = timeLower; let hour = date.getHours() % 12; const suffix = date.getHours() > 11 ? 'pm' : 'am'; if (!hour) { From 4dd8d7e73f2745fd083a119b967caa45890b5d7b Mon Sep 17 00:00:00 2001 From: Yasin Silavi Date: Wed, 26 Jul 2023 10:57:23 +0330 Subject: [PATCH 2/5] Refactor isEnabled function to always return boolean --- src/scripts/autocast.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/autocast.js b/src/scripts/autocast.js index 9ed7de5df7..0f63854336 100644 --- a/src/scripts/autocast.js +++ b/src/scripts/autocast.js @@ -26,7 +26,7 @@ export function isEnabled() { const playerId = localStorage.getItem('autocastPlayerId'); const currentPlayerInfo = playbackManager.getPlayerInfo(); - return (currentPlayerInfo && playerId && currentPlayerInfo.id === playerId); + return currentPlayerInfo?.id === playerId } function onOpen() { From a8e6eaff48e20fab2eeaab6b061eba49ca610802 Mon Sep 17 00:00:00 2001 From: Yasin Silavi Date: Wed, 26 Jul 2023 10:58:37 +0330 Subject: [PATCH 3/5] Remove comment out code --- src/plugins/bookPlayer/template.html | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/plugins/bookPlayer/template.html b/src/plugins/bookPlayer/template.html index 55fd02c8a1..255b8283a2 100644 --- a/src/plugins/bookPlayer/template.html +++ b/src/plugins/bookPlayer/template.html @@ -2,12 +2,6 @@ - From e4db027bbbe9199fe768d6c11dd47a585a6b9e39 Mon Sep 17 00:00:00 2001 From: Yasin Silavi <59373143+sttatusx@users.noreply.github.com> Date: Wed, 26 Jul 2023 17:41:08 +0330 Subject: [PATCH 4/5] Update src/scripts/autocast.js Co-authored-by: Bill Thornton --- src/scripts/autocast.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/autocast.js b/src/scripts/autocast.js index 0f63854336..95b694a3bc 100644 --- a/src/scripts/autocast.js +++ b/src/scripts/autocast.js @@ -26,7 +26,7 @@ export function isEnabled() { const playerId = localStorage.getItem('autocastPlayerId'); const currentPlayerInfo = playbackManager.getPlayerInfo(); - return currentPlayerInfo?.id === playerId + return currentPlayerInfo?.id === playerId; } function onOpen() { From ea47793820baf17a99583e1425947007ae624080 Mon Sep 17 00:00:00 2001 From: Yasin Silavi <59373143+sttatusx@users.noreply.github.com> Date: Sat, 9 Sep 2023 00:52:34 +0330 Subject: [PATCH 5/5] fix: check both player id and current player id Co-authored-by: Bill Thornton --- src/scripts/autocast.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/autocast.js b/src/scripts/autocast.js index 95b694a3bc..2633587ba5 100644 --- a/src/scripts/autocast.js +++ b/src/scripts/autocast.js @@ -26,7 +26,7 @@ export function isEnabled() { const playerId = localStorage.getItem('autocastPlayerId'); const currentPlayerInfo = playbackManager.getPlayerInfo(); - return currentPlayerInfo?.id === playerId; + return playerId && currentPlayerInfo?.id === playerId; } function onOpen() {