mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Merge pull request #2221 from thornbill/lint-array-returns

Browse source 
Add lint rule for array callback returns
This commit is contained in:
Bill Thornton 2020-12-16 11:27:53 -05:00 • committed by GitHub
commit 7f55da0d57
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.eslintrc.js
View file

@ -29,6 +29,7 @@ module.exports = {
'plugin:compat/recommended' 'plugin:compat/recommended'
], ],
rules: { rules: {
'array-callback-return': ['error'],
'block-spacing': ['error'], 'block-spacing': ['error'],
'brace-style': ['error', '1tbs', { 'allowSingleLine': true }], 'brace-style': ['error', '1tbs', { 'allowSingleLine': true }],
'comma-dangle': ['error', 'never'], 'comma-dangle': ['error', 'never'],

4
src/components/multiSelect/multiSelect.js
View file

@ -157,9 +157,7 @@ import confirm from '../confirm/confirm';
} }
confirm(msg, title).then(() => { confirm(msg, title).then(() => {
const promises = itemIds.map(itemId => { const promises = itemIds.map(itemId => apiClient.deleteItem(itemId));
apiClient.deleteItem(itemId);
});
Promise.all(promises).then(resolve, () => { Promise.all(promises).then(resolve, () => {
alertText(globalize.translate('ErrorDeletingItem')).then(reject, reject); alertText(globalize.translate('ErrorDeletingItem')).then(reject, reject);

14
src/components/playback/playbackmanager.js
View file

@ -283,15 +283,15 @@ function getAudioMaxValues(deviceProfile) {
let maxAudioBitDepth = null; let maxAudioBitDepth = null;
let maxAudioBitrate = null; let maxAudioBitrate = null;
deviceProfile.CodecProfiles.map(function (codecProfile) { deviceProfile.CodecProfiles.forEach(codecProfile => {
if (codecProfile.Type === 'Audio') { if (codecProfile.Type === 'Audio') {
(codecProfile.Conditions || []).map(function (condition) { (codecProfile.Conditions || []).forEach(condition => {
if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitDepth') { if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitDepth') {
return maxAudioBitDepth = condition.Value; maxAudioBitDepth = condition.Value;
} else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') { } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
return maxAudioSampleRate = condition.Value; maxAudioSampleRate = condition.Value;
} else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') { } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
return maxAudioBitrate = condition.Value; maxAudioBitrate = condition.Value;
} }
}); });
} }
@ -334,7 +334,7 @@ function getAudioStreamUrlFromDeviceProfile(item, deviceProfile, maxBitrate, api
let directPlayContainers = ''; let directPlayContainers = '';
deviceProfile.DirectPlayProfiles.map(function (p) { deviceProfile.DirectPlayProfiles.forEach(p => {
if (p.Type === 'Audio') { if (p.Type === 'Audio') {
if (directPlayContainers) { if (directPlayContainers) {
directPlayContainers += ',' + p.Container; directPlayContainers += ',' + p.Container;
@ -360,7 +360,7 @@ function getStreamUrls(items, deviceProfile, maxBitrate, apiClient, startPositio
let audioDirectPlayContainers = ''; let audioDirectPlayContainers = '';
deviceProfile.DirectPlayProfiles.map(function (p) { deviceProfile.DirectPlayProfiles.forEach(p => {
if (p.Type === 'Audio') { if (p.Type === 'Audio') {
if (audioDirectPlayContainers) { if (audioDirectPlayContainers) {
audioDirectPlayContainers += ',' + p.Container; audioDirectPlayContainers += ',' + p.Container;

2
src/plugins/sessionPlayer/plugin.js
View file

@ -86,7 +86,7 @@ function unsubscribeFromPlayerUpdates(instance) {
function processUpdatedSessions(instance, sessions, apiClient) { function processUpdatedSessions(instance, sessions, apiClient) {
const serverId = apiClient.serverId(); const serverId = apiClient.serverId();
sessions.map(function (s) { sessions.forEach(s => {
if (s.NowPlayingItem) { if (s.NowPlayingItem) {
s.NowPlayingItem.ServerId = serverId; s.NowPlayingItem.ServerId = serverId;
} }

4
src/scripts/shell.js
View file

@ -33,9 +33,7 @@ export default {
*/ */
downloadFiles(items) { downloadFiles(items) {
if (window.NativeShell) { if (window.NativeShell) {
items.map(function(item) { items.forEach(item => window.NativeShell.downloadFile(item));
window.NativeShell.downloadFile(item);
});
return true; return true;
} }
return false; return false;